Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Conversation

@KittyNoodle
Copy link
Contributor

@KittyNoodle KittyNoodle commented Feb 6, 2022

This reverts commit 5c91612.

Document the changes in your pull request

Fixes issues #13162 and #13200

Renaming a station broke voting so hard and nobody has fixed it despite it being weeks.
Please Testmerge while we wait for an actual fix.

Changelog

Edit the changelog below to reflect the changes made by this PR, even if the changes are minor - required for every PR.
If you add a name after the ':cl', that name will be used in the changelog. Leave it empty to use your GitHub name.

🆑

rscdel: Temporarily reverts the yogstation renaming pending an actual fix for the bugs it caused
bugfix: Voting works again
/:cl:

@KittyNoodle KittyNoodle requested review from a team as code owners February 6, 2022 22:26
@Yogbot-13 Yogbot-13 added Fix This fixes an issue. Please link issues in fix PRs Mapping Will result in a change to a map. Revert / Deletion Altoids is probably mad about this labels Feb 6, 2022
@ToasterBiome
Copy link
Contributor

ToasterBiome commented Feb 6, 2022

Voting will not work again as it is a problem with the game's interaction with the CDN and not a map name which is not used in local testing

@github-actions github-actions bot added the Config Config files need to be changed on the host for this to work label Feb 6, 2022
@maxion12345
Copy link
Contributor

please merge my pr before you do this I beg

@alexkar598
Copy link
Member

The CDN works as expected, this is a problem with tgui and/or the asset caching system.

@ToasterBiome
Copy link
Contributor

The CDN works as expected, this is a problem with tgui and/or the asset caching system.

^ Guy is mad

@alexkar598
Copy link
Member

The CDN works as expected, this is a problem with tgui and/or the asset caching system.

^ Guy is mad

Don't think I am

@Bibby0110
Copy link
Contributor

The CDN works as expected, this is a problem with tgui and/or the asset caching system.

^ Guy is mad

Don't think I am

Proof?

@adamsong
Copy link
Contributor

adamsong commented Feb 7, 2022

Voting was broken long before the original PR was merged, this doesn't fix either mentioned issue

@Hopekz
Copy link
Contributor

Hopekz commented Feb 7, 2022

Voting was broken long before the original PR was merged, this doesn't fix either mentioned issue

Well yeah who really knows because we test merged the name change for a while. Felt like it was test merged for like a week or two

@adamsong
Copy link
Contributor

adamsong commented Feb 7, 2022

Better fix in #13236

@adamsong adamsong closed this Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Config Config files need to be changed on the host for this to work Fix This fixes an issue. Please link issues in fix PRs Mapping Will result in a change to a map. Revert / Deletion Altoids is probably mad about this

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants