[WIP]{KeyVault} KeyVault Track 2 SDK adoption#12708
Closed
[WIP]{KeyVault} KeyVault Track 2 SDK adoption#12708
Conversation
bim-msft
requested review from
Juliehzl,
arrownj,
fengzhou-msft,
haroldrandom,
jiasli and
qianwens
as code owners
bim-msft
changed the title
bim-msft
changed the title
Collaborator
|
KeyVault Track 2 |
lmazuel
reviewed
Mar 25, 2020
Member
There was a problem hiding this comment.
You need to discuss with Yu about this
Contributor
Author
There was a problem hiding this comment.
You need to discuss with Yu about this
Thanks, I'll talk to him.
bim-msft
force-pushed
the
bim_kv_track2
branch
2 times, most recently
from
fb149f5 to
577c17d
Compare
…te long term retention backups, restore long term retention backup (Azure#12712) * added ltr mi policy to commands/params * add custom commands/params for ltr mi backup APIs; updated params for ltr restore * added LTR Policy tests * fixing pylint * fix pylint * updated commands * fix setting location for ltr restore * adding test cases for all LTR MI functions * removing unrelated files * added help, some fixes to parameters * edit test cases * removed print line * removing unneeded files; removing whitespace fixes * whitespace fixing; adding some details to params * updating help/params, some typos * updated help * more changes to help * recording file * switch back resource names * test resource names * fix a db name * shorten 'long-term-retention' and '--only-latest-per-database' * updated recording * - consolidate all list-by-* to list - added ltr restore to pitr restore under managed db restore * remove ltr restore from help * updated test recording for ltr * remove managed_db_restore_ltr_backup from commands * replace "list-by-*" with "list" in help * remove blank lines from params * revert restore ltr backup command to be separate from PITR * re-recorded * change help to use ltr restore * undo changes for restore (pitr) * revert changes in PITR restore tests * style/pylint * moved restore under ltr-backup * update ltr restore command in help * add wait to help * rename restore function for MI * rename restore custom function (again) * clarified param requirements for ltr-backup restore * changed help descriptions for retention params * remove whitespace * changed --name to represent backup name in ltr-backup commands * added lines for style * fix help * update week_of_year help * add \ to help; add confirmation for delete; add checks in tests; re-record * enable ltr-backup show to accept backup-id * enable delete with backup_id * adjust usage of --latest in test * remove py files * added hard length checks to tests; added show test using backup id; added is_preview=True to new commands; added ability to use int arguments to configure retention settings in days * test re-record
…int-connection (Azure#12960) * Add az cosmosdb private-link-resource and private-endpoint * modify history.rst * rename to private-endpoint-connection and fix style * style fix * fix following command guideline and comments * fix example * fix CI * fix ci * fix typo * revert history
Azure#13038) * code finish * finish test * fix style and linter * rerun the test
* Deprecate 'iotcentral' and use 'iot central' * lint * Update help sku value * Use show_custom_command for 'show' command * Update method comments * linting, run tests * record tests * re-run tests * run tests * update test_iot_hub.yaml * revert test_iot_hub.yaml to previous PR commit * Bump version * fix history * remove expiration date * run test * Remove History comments * Add confirmation message for deleteing an application * Revert confirmation * Add confirmation * remove text from help file * Update src/azure-cli/azure/cli/command_modules/iot/_help.py * Update src/azure-cli/azure/cli/command_modules/iot/commands.py * Update src/azure-cli/azure/cli/command_modules/iot/commands.py * fix style Co-authored-by: rodelga <rodelga@microsoft.com> Co-authored-by: Feng Zhou <fenzhou@microsoft.com> Co-authored-by: Zunli Hu <zuh@microsoft.com>
…h temporary folder back (Azure#13061)
* {Compute} Update help of --version of vm/vmss extension
* Update src/azure-cli/azure/cli/command_modules/vm/_params.py
* update azure-cli version to 2.4.0 * Update src/azure-cli-core/HISTORY.rst Co-Authored-By: Jiashuo Li <jiasli@microsoft.com> * Update src/azure-cli/HISTORY.rst Co-Authored-By: Zunli Hu <zuh@microsoft.com> * Apply suggestions from code review Co-Authored-By: Jiashuo Li <jiasli@microsoft.com> Co-Authored-By: Zunli Hu <zuh@microsoft.com> Co-Authored-By: Jianhui Harold <haroldrandom@gmail.com> * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review Co-Authored-By: Zunli Hu <zuh@microsoft.com> Co-authored-by: Feiyue Yu <fey@microsoft.com> Co-authored-by: Jiashuo Li <jiasli@microsoft.com> Co-authored-by: Zunli Hu <zuh@microsoft.com> Co-authored-by: qianwens <37290631+qianwens@users.noreply.github.com> Co-authored-by: Jianhui Harold <haroldrandom@gmail.com>
…esource storage vm (Azure#12499)
bim-msft
requested review from
bgklein,
jaredmoo,
jsntcy,
lewu-msft,
mmyyrroonn,
qwordy,
samkreter,
v-Ajnava and
zhoxing-ms
as code owners
Contributor
Author
|
Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for testing, do not merge
Python SDK PR: Azure/azure-sdk-for-python#10128
Swagger readme: https://github.com/bim-msft/azure-rest-api-specs/blob/bim_kv_track2/specification/keyvault/resource-manager/readme.python.md
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.