Skip to content

Registration Resources#10042

Merged
jwalz merged 28 commits into
developfrom
feature/registration_resources
Aug 29, 2022
Merged

Registration Resources#10042
jwalz merged 28 commits into
developfrom
feature/registration_resources

Conversation

@jwalz
Copy link
Copy Markdown
Contributor

@jwalz jwalz commented Aug 29, 2022

Purpose

Merging the feature branch to develop

Changes

  • All API Work for Registration Resources
    • New endpoints
    • New serializer
    • Serializer changes for Registrations
      • New relationship field
      • New annotation-populated fields for has_<resource_type>
    • Generic improvements to existing API infrastructure
      • new EnumField for serializers
      • Improved error reporting in JSONAPIException
      • Consistent handling of VOL keys in API self links
  • Expanded model logic for Outcomes and OutcomeArtifacts
  • Updates to SHARE to encode resource types for Registrations
  • Updates to Datacite client to populate relatedIdentifiers
  • Expansions to the Identifier infrastructure to enable validation of DOIs

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

jwalz and others added 28 commits July 21, 2022 13:12
@jwalz
[ENG-3895][ENG-3897]ResourceSerializer and ResourceDetail GET impleme…
4563673 
…ntation (#9980)

ResourceSerializer and GET functionality on ResourceDetail
Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
@jwalz
[ENG-3896] POST functionality on ResourceList endpoint (#9988)
0ac695c 
* Implement POST method on ResourceList endpoint

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
@jwalz
[ENG-3895][ENG-3897]ResourceSerializer and ResourceDetail GET impleme…
f1e3069 
…ntation (#9980)

ResourceSerializer and GET functionality on ResourceDetail
Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
@jwalz
[ENG-3896] POST functionality on ResourceList endpoint (#9988)
13d6e84 
* Implement POST method on ResourceList endpoint

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
Compatibility fixes with develop
1785166
Merge branch 'feature/registration_resources' of github.com:CenterFor…
2ce96a3 
…OpenScience/osf.io into feature/registration_resources
@jwalz @brianjgeiger
[ENG-3900] Registration resource list (#9990)
1945e52 
* Implement RegistrationResourceList endpoint

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
Co-authored-by: Brian J. Geiger <bgeiger@pobox.com>
@jwalz @brianjgeiger
[ENG-3898][ENG-3899]ResourceDetail PATCH and DELETE (#9991)
8868039 
* Implement PATCH and DELETE support for ResourceDetail

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
Co-authored-by: Brian J. Geiger <bgeiger@pobox.com>
@jwalz
[ENG-3901] Annotations and Registration Serializer changes for Open P…
c736177 
…ractice Badges (#9992)

* Add annotations for open practice badges

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
@jwalz
[ENG-3945]Validate DOIs on PATCH (#9996)
181172f 
* Validate DOIs on `update_identifier` call

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
@jwalz
[ENG-3962] Integration Bug Fixes (#9999)
d206f44 
* Integration bugs for Registration resources

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
@jwalz
Add 'status' to JSONAPIError dictionary (#10002)
23984ad 
* Add 'status' to JSONAPIError dictionary

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
@jwalz
Add has_papers and has_supplements fields/annotations (#10005)
8f41c0c 
* Annotations and tests for remaining ArtifactTypes

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
@jwalz
Add route for new Registration resources subpage (take 2) (#10006)
2d817c2 
* Add osf.io/<registration_guid>/resources to ember routes

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
@jwalz
Make Resources filterable by type (and dates) (#10008)
ae823cd 
* Make resources filterable

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
@jwalz
[ENG-3902] SHARE integration changes for osf_related_resource_types (…
b4a7b1a 
…#10004)

* Add `osf_related_resource_types` to Registration serialization on SHARE and update SHARE when artifacts are updated

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
@jwalz
[ENG-3903] Add artifacts to DOI metadata as relatedIdentifiers (#10013
8575a1a 
)

* Add artifacts to DOI metadata as `relatedIdentifiers`; update doi
metadata on artifact addition/update/removal

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
@jwalz
[ENG-3981] Add placeholder Identifier to Embargoed Registrations (#10015
46ea4fb 
)

* Make placeholder Identifiers for all registrations in the tree on
Embargo

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
Merge branch 'develop' into feature/registration_resources
09d96a0
@jwalz
Fix signature for calling update_doi_metadata_on_change (#10016)
27b7698 
Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
@jwalz
[ENG-3962] Enforce Integrity on update of finalized resources (#10018)
5f2dfc2 
* Enforce integrity when updating a finalized resource/artifact

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
Merge branch 'develop' into feature/registration_resources
bb2185b
@jwalz
[ENG-3962] Fix issues with Resource (A)VOLs (#10024)
b1c9720 
* Always append vol key to `self` links; surface `resource_type` in avols

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
@jwalz
Add has_<resource_type> fields to nonanonymized_fields (#10026)
4844cea 
Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
@jwalz
[ENG-3962] Prevent using the PID of the Primary Artifact as another A…
816b37e 
…rtifact (#10027)

* Prevent using the PID of the Primary Artifact as another Artifact

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
Merge branch 'develop' into feature/registration_resources
d265264
@jwalz
Fix DOI Updating (#10030)
3aab720 
* Fixes for DOI Updating

Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
@jwalz
Normalize PID input (#10032)
0d1b97a 
* Normalize PID input
Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
Co-authored-by: Jon Walz <jonwalz@Admins-MacBook-Pro.local>
@jwalz jwalz merged commit d8d54ba into develop Aug 29, 2022
Johnetordoff pushed a commit to Johnetordoff/osf.io that referenced this pull request Sep 1, 2022
Merge branch 'feature/django_upgrade' of https://github.com/CenterFor…
8a3fc10 
…OpenScience/osf.io into django-3-onmibus

* 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: (23 commits)
  Fix system check warnings for django admin
  Add migrations for django upgrade base fixes
  Comment out admin permissions that clash with built-in "view" ones
  Add/Enable missing templates and middlewares in api settings
  Fix django CORS whitelist settings due to orgin definition update
  Add required on_delete=CASCADE (default) to FKs missing it
  Make fields defined on typedmodels subclasses nullable
  Upgrade django to 3.2.15 (and related dependencies)
  Fix typo
  Prevent errors in Keen-less environments
  Add missing defaults
  Bump DEFAULT_API_VERSION to 2.20
  Improve import formatting
  Improve header comparison
  Add PLOS Metrics command - Update celery config/queues
  Fix local cookie samesite config and use 'Lax' instead of 'None'
  Add task to celery settings
  Pass and load Identifier ID instead of instance
  Bump version and update changelog
  Registration Resources (CenterForOpenScience#10042)
  ...

# Conflicts:
#	admin/base/settings/defaults.py
#	api/base/settings/defaults.py
#	osf/models/analytics.py
#	osf/models/banner.py
#	osf/models/brand.py
#	osf/models/conference.py
#	osf/models/institution.py
#	osf/models/preprint.py
#	osf/models/provider.py
#	osf/models/registrations.py
#	osf/models/schema_response.py
#	osf/models/storage.py
#	osf/models/subject.py
#	osf/models/user.py
#	requirements.txt
Johnetordoff pushed a commit to Johnetordoff/osf.io that referenced this pull request Sep 1, 2022
Merge branch 'feature/django_upgrade' of https://github.com/CenterFor…
cd156b5 
…OpenScience/osf.io into django-3-onmibus

* 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: (23 commits)
  Fix system check warnings for django admin
  Add migrations for django upgrade base fixes
  Comment out admin permissions that clash with built-in "view" ones
  Add/Enable missing templates and middlewares in api settings
  Fix django CORS whitelist settings due to orgin definition update
  Add required on_delete=CASCADE (default) to FKs missing it
  Make fields defined on typedmodels subclasses nullable
  Upgrade django to 3.2.15 (and related dependencies)
  Fix typo
  Prevent errors in Keen-less environments
  Add missing defaults
  Bump DEFAULT_API_VERSION to 2.20
  Improve import formatting
  Improve header comparison
  Add PLOS Metrics command - Update celery config/queues
  Fix local cookie samesite config and use 'Lax' instead of 'None'
  Add task to celery settings
  Pass and load Identifier ID instead of instance
  Bump version and update changelog
  Registration Resources (CenterForOpenScience#10042)
  ...

# Conflicts:
#	admin/base/settings/defaults.py
#	api/base/settings/defaults.py
#	osf/models/analytics.py
#	osf/models/banner.py
#	osf/models/brand.py
#	osf/models/conference.py
#	osf/models/institution.py
#	osf/models/preprint.py
#	osf/models/provider.py
#	osf/models/registrations.py
#	osf/models/schema_response.py
#	osf/models/storage.py
#	osf/models/subject.py
#	osf/models/user.py
#	requirements.txt
Johnetordoff pushed a commit to Johnetordoff/osf.io that referenced this pull request Sep 2, 2022
Merge branch 'feature/django_upgrade' of https://github.com/CenterFor…
4e4eeb4 
…OpenScience/osf.io into django-3-JSON-field-changes

* 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: (23 commits)
  Fix system check warnings for django admin
  Add migrations for django upgrade base fixes
  Comment out admin permissions that clash with built-in "view" ones
  Add/Enable missing templates and middlewares in api settings
  Fix django CORS whitelist settings due to orgin definition update
  Add required on_delete=CASCADE (default) to FKs missing it
  Make fields defined on typedmodels subclasses nullable
  Upgrade django to 3.2.15 (and related dependencies)
  Fix typo
  Prevent errors in Keen-less environments
  Add missing defaults
  Bump DEFAULT_API_VERSION to 2.20
  Improve import formatting
  Improve header comparison
  Add PLOS Metrics command - Update celery config/queues
  Fix local cookie samesite config and use 'Lax' instead of 'None'
  Add task to celery settings
  Pass and load Identifier ID instead of instance
  Bump version and update changelog
  Registration Resources (CenterForOpenScience#10042)
  ...
Johnetordoff pushed a commit to Johnetordoff/osf.io that referenced this pull request Sep 2, 2022
Merge branch 'feature/django_upgrade' of https://github.com/CenterFor…
d1206c1 
…OpenScience/osf.io into django-3-DRF-serializer

* 'feature/django_upgrade' of https://github.com/CenterForOpenScience/osf.io: (23 commits)
  Fix system check warnings for django admin
  Add migrations for django upgrade base fixes
  Comment out admin permissions that clash with built-in "view" ones
  Add/Enable missing templates and middlewares in api settings
  Fix django CORS whitelist settings due to orgin definition update
  Add required on_delete=CASCADE (default) to FKs missing it
  Make fields defined on typedmodels subclasses nullable
  Upgrade django to 3.2.15 (and related dependencies)
  Fix typo
  Prevent errors in Keen-less environments
  Add missing defaults
  Bump DEFAULT_API_VERSION to 2.20
  Improve import formatting
  Improve header comparison
  Add PLOS Metrics command - Update celery config/queues
  Fix local cookie samesite config and use 'Lax' instead of 'None'
  Add task to celery settings
  Pass and load Identifier ID instead of instance
  Bump version and update changelog
  Registration Resources (CenterForOpenScience#10042)
  ...
Johnetordoff pushed a commit to Johnetordoff/osf.io that referenced this pull request Sep 16, 2022
Merge branch 'develop' of https://github.com/CenterForOpenScience/osf.io
85f17e5 
 into remove-quickfiles

* 'develop' of https://github.com/CenterForOpenScience/osf.io: (94 commits)
  Bump version and update CHANGELOG
  [ENG-3568] keen replacement (CenterForOpenScience#9954)
  Bump NR Agent version
  Fix typo
  Prevent errors in Keen-less environments
  Add missing defaults
  Bump DEFAULT_API_VERSION to 2.20
  Improve import formatting
  Improve header comparison
  Add PLOS Metrics command - Update celery config/queues
  Fix local cookie samesite config and use 'Lax' instead of 'None'
  Add task to celery settings
  Pass and load Identifier ID instead of instance
  Bump version and update changelog
  Registration Resources (CenterForOpenScience#10042)
  Update test-build.yml
  Bump version and update CHANGELOG
  [ENG-3854] Add management command to sync all DOI metadata (CenterForOpenScience#9972)
  Re-add non-anonymized fields removed in CenterForOpenScience#10009 (CenterForOpenScience#10022)
  Update shield logo for colorado (UC Boulder)
  ...

# Conflicts:
#	api_tests/base/test_sloan_study.py
#	osf/models/nodelog.py
#	osf/models/quickfiles.py
#	osf_tests/test_sanctions.py
#	package.json
#	tests/test_views.py
#	website/settings/defaults.py
#	website/static/js/anonymousLogActionsList.json
#	website/static/js/components/logFeed.js
#	website/static/js/logActionsList.json
Johnetordoff pushed a commit to Johnetordoff/osf.io that referenced this pull request Sep 16, 2022
Merge branch 'develop' of https://github.com/CenterForOpenScience/osf.io
ea0d562 
 into remove-quickfiles-code

* 'develop' of https://github.com/CenterForOpenScience/osf.io:
  Bump version and update CHANGELOG
  [ENG-3568] keen replacement (CenterForOpenScience#9954)
  Bump NR Agent version
  Fix typo
  Prevent errors in Keen-less environments
  Add missing defaults
  Bump DEFAULT_API_VERSION to 2.20
  Improve import formatting
  Improve header comparison
  Add PLOS Metrics command - Update celery config/queues
  Fix local cookie samesite config and use 'Lax' instead of 'None'
  Add task to celery settings
  Pass and load Identifier ID instead of instance
  Bump version and update changelog
  Registration Resources (CenterForOpenScience#10042)
  Update test-build.yml
  Bump version and update CHANGELOG
  [ENG-3854] Add management command to sync all DOI metadata (CenterForOpenScience#9972)

# Conflicts:
#	scripts/analytics/file_summary.py
#	website/settings/defaults.py
@mfraezz mfraezz deleted the feature/registration_resources branch October 21, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jwalz