Thumbnail Rotation#45
Conversation
…ng rotated. Couldn't test actual changes, but tested all code added separately
devinmatte
left a comment
devinmatte
left a comment
There was a problem hiding this comment.
This would be a great change to see 🙌
* Initial file hiding and lockdown schema * Adding migration for model * Functioning lockdown and file hide * Fixing nav icon * Changing wording of alerts
|
@geoffmoss0 did you test this locally? |
|
Tested the python locally, worked with images I got from gallery. Basically copy/pasted that code and made sure it worked when I manually gave it a file. |
|
|
||
| # read metadata to find orientation of image | ||
| # then rotate accordingly. | ||
| rotation = img.metadata["exif:Orientation"] |
There was a problem hiding this comment.
Can you fix the indentation? Looks like you're maybe using tab characters which aren't playing nice w/ the surrounding 4-space tabs.
There was a problem hiding this comment.
In addition to this, where are you finding metadata? Looks like we use exif dicts, with a get_exif() function.
There was a problem hiding this comment.
From what I remember and just looked up, metadata is just a read-only part of Image that contains the exif data. This implementation is just what I found about how to get exif data and it worked so I didn't question it.
There was a problem hiding this comment.
Also ew 4 space tabs
There was a problem hiding this comment.
Can I easily edit change this without making a new PR? I cleaned it up locally
There was a problem hiding this comment.
Yeah just commit and push to your branch.
Version 2.1.0
Add Audio Support
* Remove hidden file from directory thumbnails * Fix typo * Fix show button * Update README with local dev instructions * Fix directory thumbnails showing hidden files
* Add .swp files to gitignore * Display more helpful lockdown page, move more routes behind lockdown
* Added mp3 support * Added wav support, added default thumbnail * Remove hidden files from directory thumbnails (ComputerScienceHouse#56) * Remove hidden file from directory thumbnails * Fix typo * Fix show button * Update README with local dev instructions * Fix directory thumbnails showing hidden files * Various lockdown fixes (ComputerScienceHouse#58) * Add .swp files to gitignore * Display more helpful lockdown page, move more routes behind lockdown * Version bump * Remove old password from localconfig * Update local development instructions and gitignore
* Allow alumni to view hidden files * Update nav.html
* Upgrade pip Fixes Docker build issue caused by an issue in pip 19 Issue occurred when using --no-cache-dir * Pip werkzeug version
Update to include squash merge from ComputerScienceHouse#59 (2.1.1)
7 participants
It was annoying me so I fixed it, I think