fix(entity_id): Handle Podman cgroupns=host cgroup path#1828
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom Apr 2, 2026
Merged
fix(entity_id): Handle Podman cgroupns=host cgroup path#1828gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
Conversation
…ontainer suffix systemd + cgroup v2 (cgroupns=host) │ ...libpod-<ID>.scope/container When a container runs with systemd + crgroup v2 (cgroupns=host) the cgroup path has /container after .scope. 0::/machine.slice/libpod-HEXID.scope/container (podman never seems to set anything other than the default "container" -- could find no reference to `run.oci.systemd.subgroup` -- but match other strings as well.
cataphract
force-pushed
the
glopes/podman-cgroupns-fix
branch
from
20019b4 to
75ab855
Compare
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1828 +/- ##
==========================================
+ Coverage 71.33% 71.35% +0.01%
==========================================
Files 424 424
Lines 66685 66687 +2
==========================================
+ Hits 47572 47586 +14
+ Misses 19113 19101 -12
🚀 New features to boost your workflow:
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 75ab855 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
bantonsson
reviewed
Apr 1, 2026
bantonsson
approved these changes
Apr 1, 2026
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
glopes/podman-cgroupns-fix
branch
This was referenced Apr 23, 2026
hoolioh
added a commit
that referenced
this pull request
Apr 23, 2026
# Release proposal for libdd-capabilities-impl and its dependencies This PR contains version bumps based on public API changes and commits since last release. ## libdd-capabilities **Next version:** `1.0.0` **Semver bump:** `major` **Tag:** `libdd-capabilities-v1.0.0` **Warning:** this is an initial release. Please verify that the version and commits included are correct. ## libdd-common **Next version:** `4.0.0` **Semver bump:** `major` **Tag:** `libdd-common-v4.0.0` ### Commits - chore(benchmarks): add allocation size tracking allocator (#1905) - refactor(libdd-capabilities)!: remove transitive dependency (#1895) - feat(runtime)!: add shared runtime (#1602) - fix(crypto): use `ring` for non-fips builds (#1816) - fix(ci): skip thread counting test (#1841) - chore(ci): mock now function for rate limiter in tests to make them deterministic (#1842) - fix(entity_id): Handle Podman cgroupns=host cgroup path (#1828) - feat(capabilities)!: trait architecture http (#1555) - feat!: implement HTTP common component (#1624) - fix(common): don't use reqwest http proxies (#1810) - test(miri): skip reqwest test that takes 10mn (#1784) ## libdd-capabilities-impl **Next version:** `1.0.0` **Semver bump:** `major` **Tag:** `libdd-capabilities-impl-v1.0.0` **Warning:** this is an initial release. Please verify that the version and commits included are correct. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: hoolioh <107922352+hoolioh@users.noreply.github.com>
hoolioh
added a commit
that referenced
this pull request
Apr 27, 2026
# Release proposal for libdd-capabilities-impl and its dependencies This PR contains version bumps based on public API changes and commits since last release. ## libdd-capabilities **Next version:** `1.0.0` **Semver bump:** `major` **Tag:** `libdd-capabilities-v1.0.0` **Warning:** this is an initial release. Please verify that the version and commits included are correct. ## libdd-common **Next version:** `4.0.0` **Semver bump:** `major` **Tag:** `libdd-common-v4.0.0` ### Commits - fix(libdd-common): fix condition so testing with --all-features works (#1919) - chore(benchmarks): add allocation size tracking allocator (#1905) - refactor(libdd-capabilities)!: remove transitive dependency (#1895) - feat(runtime)!: add shared runtime (#1602) - fix(crypto): use `ring` for non-fips builds (#1816) - fix(ci): skip thread counting test (#1841) - chore(ci): mock now function for rate limiter in tests to make them deterministic (#1842) - fix(entity_id): Handle Podman cgroupns=host cgroup path (#1828) - feat(capabilities)!: trait architecture http (#1555) - feat!: implement HTTP common component (#1624) - fix(common): don't use reqwest http proxies (#1810) - test(miri): skip reqwest test that takes 10mn (#1784) ## libdd-capabilities-impl **Next version:** `1.0.0` **Semver bump:** `major` **Tag:** `libdd-capabilities-impl-v1.0.0` **Warning:** this is an initial release. Please verify that the version and commits included are correct. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: hoolioh <107922352+hoolioh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes a regex generalizing cgroup path matching.
Motivation
systemd + cgroup v2 (cgroupns=host) │ ...libpod-.scope/container When a container runs with systemd + crgroup v2 (cgroupns=host) the cgroup path has /container after .scope.
0::/machine.slice/libpod-HEXID.scope/container
(podman never seems to set anything other than the default "container" -- could find no reference to
run.oci.systemd.subgroup-- but match other strings as well.Additional Notes
This problem was observed when running ssi system tests in the local (non-aws) environment.