Skip to content

chore(ci): mock now function for rate limiter in tests to make them deterministic#1842

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom
ekump/APMSP-2801-mock-now-for-rate-limiter-test
Apr 2, 2026
Merged

chore(ci): mock now function for rate limiter in tests to make them deterministic#1842
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom
ekump/APMSP-2801-mock-now-for-rate-limiter-test

Conversation

@ekump
Copy link
Copy Markdown
Contributor

@ekump ekump commented Apr 2, 2026

What does this PR do?

Makes the rate_limiter tests deterministic by mocking now().

Motivation

flakiness

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@github-actions github-actions Bot added the common label Apr 2, 2026
@ekump ekump changed the title mock now function for rate limiter in tests to make them deterministic chore(ci): mock now function for rate limiter in tests to make them deterministic Apr 2, 2026
@ekump ekump marked this pull request as ready for review April 2, 2026 17:34
@ekump ekump requested a review from a team as a code owner April 2, 2026 17:34
Copy link
Copy Markdown
Contributor

@gyuheon0h gyuheon0h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/ekump/APMSP-2801-mock-now-for-rate-limiter-test

Summary by Rule

Rule Base Branch PR Branch Change

Annotation Counts by File

File Base Branch PR Branch Change

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 21 21 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 55 55 No change (0%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 8 8 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 196 196 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

Copy link
Copy Markdown
Contributor

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! #[cfg(test)] is such an obvious solution that I just did not think of that.
I was expecting to have to patch gettimeofday from libc or something.

Thanks!

Copy link
Copy Markdown
Contributor

gyuheon0h commented Apr 2, 2026

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Apr 2, 2026

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 102.14 MB 102.14 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.76 MB 8.76 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 119.15 MB 119.15 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.37 MB 11.37 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 27.42 MB 27.42 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 80.69 KB 80.69 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 187.84 MB 187.85 MB +0% (+8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 924.71 MB 924.71 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.06 MB 9.06 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 80.69 KB 80.69 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 27.01 MB 27.01 MB --.02% (-8.00 KB) 💪
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 61.33 MB 61.33 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 23.27 MB 23.27 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 81.94 KB 81.94 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 192.39 MB 192.40 MB +0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 909.85 MB 909.85 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.90 MB 6.90 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 81.94 KB 81.94 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 29.12 MB 29.12 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 57.70 MB 57.70 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 88.99 MB 88.99 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 10.34 MB 10.34 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 111.80 MB 111.80 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 12.10 MB 12.10 MB 0% (0 B) 👌

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.58%. Comparing base (eff9d8a) to head (5d1f5f8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1842      +/-   ##
==========================================
+ Coverage   71.53%   71.58%   +0.05%     
==========================================
  Files         426      426              
  Lines       67289    67302      +13     
==========================================
+ Hits        48134    48177      +43     
+ Misses      19155    19125      -30     
Components Coverage Δ
libdd-crashtracker 65.99% <ø> (ø)
libdd-crashtracker-ffi 34.09% <ø> (ø)
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 86.20% <ø> (ø)
libdd-data-pipeline-ffi 72.22% <ø> (ø)
libdd-common 80.01% <100.00%> (+0.06%) ⬆️
libdd-common-ffi 73.87% <ø> (ø)
libdd-telemetry 62.80% <ø> (ø)
libdd-telemetry-ffi 16.75% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 73.10% <ø> (+2.10%) ⬆️
libdd-profiling 82.05% <ø> (ø)
libdd-profiling-ffi 64.94% <ø> (ø)
datadog-sidecar 31.18% <ø> (ø)
datdog-sidecar-ffi 11.84% <ø> (ø)
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 87.24% <ø> (ø)
libdd-trace-protobuf 68.25% <ø> (ø)
libdd-trace-utils 88.73% <ø> (ø)
datadog-tracer-flare 86.88% <ø> (ø)
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Copy Markdown
Contributor

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 71.58% (+0.05%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5d1f5f8 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit eb3c39b into main Apr 2, 2026
100 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the ekump/APMSP-2801-mock-now-for-rate-limiter-test branch April 2, 2026 18:55
hoolioh added a commit that referenced this pull request Apr 23, 2026
# Release proposal for libdd-capabilities-impl and its dependencies

This PR contains version bumps based on public API changes and commits
since last release.

## libdd-capabilities
**Next version:** `1.0.0`
**Semver bump:** `major`
**Tag:** `libdd-capabilities-v1.0.0`

**Warning:** this is an initial release. Please verify that the version
and commits included are correct.


## libdd-common
**Next version:** `4.0.0`
**Semver bump:** `major`
**Tag:** `libdd-common-v4.0.0`

### Commits

- chore(benchmarks): add allocation size tracking allocator (#1905)
- refactor(libdd-capabilities)!: remove transitive dependency (#1895)
- feat(runtime)!: add shared runtime (#1602)
- fix(crypto): use `ring` for non-fips builds (#1816)
- fix(ci): skip thread counting test (#1841)
- chore(ci): mock now function for rate limiter in tests to make them
deterministic (#1842)
- fix(entity_id): Handle Podman cgroupns=host cgroup path (#1828)
- feat(capabilities)!: trait architecture http (#1555)
- feat!: implement HTTP common component (#1624)
- fix(common): don't use reqwest http proxies (#1810)
- test(miri): skip reqwest test that takes 10mn (#1784)

## libdd-capabilities-impl
**Next version:** `1.0.0`
**Semver bump:** `major`
**Tag:** `libdd-capabilities-impl-v1.0.0`

**Warning:** this is an initial release. Please verify that the version
and commits included are correct.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: hoolioh <107922352+hoolioh@users.noreply.github.com>
hoolioh added a commit that referenced this pull request Apr 27, 2026
# Release proposal for libdd-capabilities-impl and its dependencies

This PR contains version bumps based on public API changes and commits
since last release.

## libdd-capabilities
**Next version:** `1.0.0`
**Semver bump:** `major`
**Tag:** `libdd-capabilities-v1.0.0`

**Warning:** this is an initial release. Please verify that the version
and commits included are correct.


## libdd-common
**Next version:** `4.0.0`
**Semver bump:** `major`
**Tag:** `libdd-common-v4.0.0`

### Commits

- fix(libdd-common): fix condition so testing with --all-features works
(#1919)
- chore(benchmarks): add allocation size tracking allocator (#1905)
- refactor(libdd-capabilities)!: remove transitive dependency (#1895)
- feat(runtime)!: add shared runtime (#1602)
- fix(crypto): use `ring` for non-fips builds (#1816)
- fix(ci): skip thread counting test (#1841)
- chore(ci): mock now function for rate limiter in tests to make them
deterministic (#1842)
- fix(entity_id): Handle Podman cgroupns=host cgroup path (#1828)
- feat(capabilities)!: trait architecture http (#1555)
- feat!: implement HTTP common component (#1624)
- fix(common): don't use reqwest http proxies (#1810)
- test(miri): skip reqwest test that takes 10mn (#1784)

## libdd-capabilities-impl
**Next version:** `1.0.0`
**Semver bump:** `major`
**Tag:** `libdd-capabilities-impl-v1.0.0`

**Warning:** this is an initial release. Please verify that the version
and commits included are correct.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: hoolioh <107922352+hoolioh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants