Skip to content

chore(benchmarks): add allocation size tracking allocator#1905

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
ban/add-counting-allocator
Apr 21, 2026
Merged

chore(benchmarks): add allocation size tracking allocator#1905
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
ban/add-counting-allocator

Conversation

@bantonsson
Copy link
Copy Markdown
Contributor

What does this PR do?

Adds an allocation size tracking allocator that can be used to benchmark memory used by functions.

Motivation

Measure all the things...

);

drop(channel);
worker.join().unwrap();
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unnecessary cleanup makes listing or filtering benchmarks lock up on Mac.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/ban/add-counting-allocator

Summary by Rule

Rule Base Branch PR Branch Change
unwrap_used 3 3 No change (0%)
Total 3 3 No change (0%)

Annotation Counts by File

File Base Branch PR Branch Change
libdd-common/src/lib.rs 3 3 No change (0%)

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 21 21 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 56 56 No change (0%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 8 8 No change (0%)
libdd-trace-stats 1 1 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 198 198 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@datadog-datadog-prod-us1-2
Copy link
Copy Markdown

datadog-datadog-prod-us1-2 Bot commented Apr 21, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 86.00%
Overall Coverage: 71.71% (-0.18%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a9172c5 | Docs | Datadog PR Page | Give us feedback!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 86.00000% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.70%. Comparing base (555a22e) to head (a9172c5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1905      +/-   ##
==========================================
- Coverage   71.88%   71.70%   -0.18%     
==========================================
  Files         433      434       +1     
  Lines       69707    69907     +200     
==========================================
+ Hits        50106    50127      +21     
- Misses      19601    19780     +179     
Components Coverage Δ
libdd-crashtracker 65.96% <ø> (-0.29%) ⬇️
libdd-crashtracker-ffi 34.09% <ø> (-2.42%) ⬇️
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 85.65% <ø> (-0.28%) ⬇️
libdd-data-pipeline-ffi 70.70% <ø> (-1.58%) ⬇️
libdd-common 79.41% <86.00%> (+0.31%) ⬆️
libdd-common-ffi 73.87% <ø> (ø)
libdd-telemetry 68.06% <ø> (ø)
libdd-telemetry-ffi 19.37% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 74.84% <ø> (-1.48%) ⬇️
libdd-profiling 81.60% <ø> (-0.02%) ⬇️
libdd-profiling-ffi 64.36% <ø> (ø)
datadog-sidecar 29.09% <ø> (-0.88%) ⬇️
datdog-sidecar-ffi 6.40% <ø> (-4.25%) ⬇️
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 87.26% <ø> (ø)
libdd-trace-protobuf 68.25% <ø> (ø)
libdd-trace-utils 89.24% <ø> (ø)
datadog-tracer-flare 86.88% <ø> (ø)
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Apr 21, 2026

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 83.34 MB 83.34 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.63 MB 7.63 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 99.41 MB 99.41 MB -0% (-8 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.10 MB 10.10 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 25.17 MB 25.17 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 79.90 KB 79.90 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 184.42 MB 184.41 MB -0% (-8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 918.36 MB 918.36 MB +0% (+4.00 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 7.89 MB 7.89 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 79.90 KB 79.90 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 23.67 MB 23.67 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 46.19 MB 46.19 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 21.66 MB 21.66 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 81.14 KB 81.14 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 188.52 MB 188.49 MB --.01% (-32.00 KB) 💪
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 903.77 MB 903.78 MB +0% (+4.00 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.13 MB 6.13 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 81.14 KB 81.14 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 25.36 MB 25.36 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 43.67 MB 43.67 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 74.43 MB 74.43 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.52 MB 8.52 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 91.78 MB 91.78 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.20 MB 10.20 MB 0% (0 B) 👌

@bantonsson bantonsson force-pushed the ban/add-counting-allocator branch from e01dc4d to d8deb22 Compare April 21, 2026 16:39
@bantonsson bantonsson force-pushed the ban/add-counting-allocator branch from d8deb22 to a9172c5 Compare April 21, 2026 16:41
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit d29b8d2 into main Apr 21, 2026
111 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the ban/add-counting-allocator branch April 21, 2026 17:47
hoolioh added a commit that referenced this pull request Apr 23, 2026
# Release proposal for libdd-capabilities-impl and its dependencies

This PR contains version bumps based on public API changes and commits
since last release.

## libdd-capabilities
**Next version:** `1.0.0`
**Semver bump:** `major`
**Tag:** `libdd-capabilities-v1.0.0`

**Warning:** this is an initial release. Please verify that the version
and commits included are correct.


## libdd-common
**Next version:** `4.0.0`
**Semver bump:** `major`
**Tag:** `libdd-common-v4.0.0`

### Commits

- chore(benchmarks): add allocation size tracking allocator (#1905)
- refactor(libdd-capabilities)!: remove transitive dependency (#1895)
- feat(runtime)!: add shared runtime (#1602)
- fix(crypto): use `ring` for non-fips builds (#1816)
- fix(ci): skip thread counting test (#1841)
- chore(ci): mock now function for rate limiter in tests to make them
deterministic (#1842)
- fix(entity_id): Handle Podman cgroupns=host cgroup path (#1828)
- feat(capabilities)!: trait architecture http (#1555)
- feat!: implement HTTP common component (#1624)
- fix(common): don't use reqwest http proxies (#1810)
- test(miri): skip reqwest test that takes 10mn (#1784)

## libdd-capabilities-impl
**Next version:** `1.0.0`
**Semver bump:** `major`
**Tag:** `libdd-capabilities-impl-v1.0.0`

**Warning:** this is an initial release. Please verify that the version
and commits included are correct.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: hoolioh <107922352+hoolioh@users.noreply.github.com>
hoolioh added a commit that referenced this pull request Apr 27, 2026
# Release proposal for libdd-capabilities-impl and its dependencies

This PR contains version bumps based on public API changes and commits
since last release.

## libdd-capabilities
**Next version:** `1.0.0`
**Semver bump:** `major`
**Tag:** `libdd-capabilities-v1.0.0`

**Warning:** this is an initial release. Please verify that the version
and commits included are correct.


## libdd-common
**Next version:** `4.0.0`
**Semver bump:** `major`
**Tag:** `libdd-common-v4.0.0`

### Commits

- fix(libdd-common): fix condition so testing with --all-features works
(#1919)
- chore(benchmarks): add allocation size tracking allocator (#1905)
- refactor(libdd-capabilities)!: remove transitive dependency (#1895)
- feat(runtime)!: add shared runtime (#1602)
- fix(crypto): use `ring` for non-fips builds (#1816)
- fix(ci): skip thread counting test (#1841)
- chore(ci): mock now function for rate limiter in tests to make them
deterministic (#1842)
- fix(entity_id): Handle Podman cgroupns=host cgroup path (#1828)
- feat(capabilities)!: trait architecture http (#1555)
- feat!: implement HTTP common component (#1624)
- fix(common): don't use reqwest http proxies (#1810)
- test(miri): skip reqwest test that takes 10mn (#1784)

## libdd-capabilities-impl
**Next version:** `1.0.0`
**Semver bump:** `major`
**Tag:** `libdd-capabilities-impl-v1.0.0`

**Warning:** this is an initial release. Please verify that the version
and commits included are correct.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: hoolioh <107922352+hoolioh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants