fix(libdd-common): fix condition so testing with --all-features works#1919
Conversation
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 847e24dc1b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| /// In FIPS mode, the caller must install the FIPS provider before any TLS use. | ||
| #[cfg(any(not(feature = "fips"), coverage))] | ||
| //#[cfg(any(not(feature = "fips"), coverage))] | ||
| #[cfg(feature = "https")] |
There was a problem hiding this comment.
This cfg(feature = "https") gate makes ensure_crypto_provider_initialized() install the non-FIPS ring provider whenever https is enabled, even if fips is also enabled through feature unification (for example --all-features or transitive defaults). Because rustls’ default provider is process-global and one-time, this can prevent later installation of the aws-lc FIPS provider and silently run non-FIPS crypto in builds that requested fips.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1919 +/- ##
==========================================
- Coverage 71.75% 71.74% -0.01%
==========================================
Files 434 434
Lines 69954 69951 -3
==========================================
- Hits 50192 50185 -7
- Misses 19762 19766 +4
🚀 New features to boost your workflow:
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: ef8e8c2 | Docs | Datadog PR Page | Give us feedback! |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
julio.gonzalez@datadoghq.com unqueued this merge request |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
|
/merge -c |
|
View all feedbacks in Devflow UI.
|
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
hoolioh
force-pushed
the
julio/fix-all-features-testing
branch
from
847e24d to
ef8e8c2
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
julio/fix-all-features-testing
branch
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
# Release proposal for libdd-capabilities-impl and its dependencies This PR contains version bumps based on public API changes and commits since last release. ## libdd-capabilities **Next version:** `1.0.0` **Semver bump:** `major` **Tag:** `libdd-capabilities-v1.0.0` **Warning:** this is an initial release. Please verify that the version and commits included are correct. ## libdd-common **Next version:** `4.0.0` **Semver bump:** `major` **Tag:** `libdd-common-v4.0.0` ### Commits - fix(libdd-common): fix condition so testing with --all-features works (#1919) - chore(benchmarks): add allocation size tracking allocator (#1905) - refactor(libdd-capabilities)!: remove transitive dependency (#1895) - feat(runtime)!: add shared runtime (#1602) - fix(crypto): use `ring` for non-fips builds (#1816) - fix(ci): skip thread counting test (#1841) - chore(ci): mock now function for rate limiter in tests to make them deterministic (#1842) - fix(entity_id): Handle Podman cgroupns=host cgroup path (#1828) - feat(capabilities)!: trait architecture http (#1555) - feat!: implement HTTP common component (#1624) - fix(common): don't use reqwest http proxies (#1810) - test(miri): skip reqwest test that takes 10mn (#1784) ## libdd-capabilities-impl **Next version:** `1.0.0` **Semver bump:** `major` **Tag:** `libdd-capabilities-impl-v1.0.0` **Warning:** this is an initial release. Please verify that the version and commits included are correct. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: hoolioh <107922352+hoolioh@users.noreply.github.com>
3 participants
What does this PR do?
Refactor cfg statements so it works wit all features enabled
Motivation
Publishing job requires that all tests pass with
--all-featuresand--no-default-features.