-
Notifications
You must be signed in to change notification settings - Fork 251
Project location #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project location #326
Conversation
Adds a warning to avoid creating a project in a cloud storage directory, like OneDrive, or with a non-ASCII file path. In response to Qendolin's request on the Fabric Discord server, [here](https://discord.com/channels/507304429255393322/807617284129423370/1367301359212167299).
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
its-miroma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice addition; thank you!
That's much better than mine. Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
its-miroma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint fix. LGTM!
|
You should also add your username to |
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
It's a very small change and you suggested a good deal of the wording; do you think it merits that? |
|
yes, of course! |
* upstream/main: Update rendering concepts page (FabricMC#362) "Setting up a Development Environment": VS Code (FabricMC#360) Running Game Tests In Github Actions (FabricMC#338) Items: Item Models (FabricMC#324) Call `.useBlockPrefixedTranslationKey()` (FabricMC#358) Clarify that `mod-id` placeholders must be customized (FabricMC#348) replace remaining mentions of tickDelta with tickProgress (FabricMC#361) Project location (FabricMC#326) improve the first items docs to state what's needed for item appearance, link fix (FabricMC#359)
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit fef78e7)
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit fef78e7)
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit fef78e7)
Adds a warning to avoid creating a project in a cloud storage directory, like OneDrive, or with a non-ASCII file path.
In response to Qendolin's request on the Fabric Discord server, here.