Skip to content

Conversation

@Thomas1034
Copy link
Contributor

Adds a warning to avoid creating a project in a cloud storage directory, like OneDrive, or with a non-ASCII file path.

In response to Qendolin's request on the Fabric Discord server, here.

Adds a warning to avoid creating a project in a cloud storage directory, like OneDrive, or with a non-ASCII file path. 

In response to Qendolin's request on the Fabric Discord server, [here](https://discord.com/channels/507304429255393322/807617284129423370/1367301359212167299).
@Thomas1034 Thomas1034 requested a review from a team as a code owner May 1, 2025 02:47
@netlify
Copy link

netlify bot commented May 1, 2025

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit 7e4669e
🔍 Latest deploy log https://app.netlify.com/projects/nimble-elf-d9d491/deploys/6825df55165a3300083f79b0
😎 Deploy Preview https://deploy-preview-326--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@its-miroma its-miroma added improvement A new addition to an already existing page todo:cleanup This should be cleaned up priority:medium This should be addressed relatively quickly labels May 1, 2025
Copy link
Member

@its-miroma its-miroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition; thank you!

That's much better than mine.

Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
Copy link
Member

@its-miroma its-miroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint fix. LGTM!

@its-miroma
Copy link
Member

You should also add your username to authors

@its-miroma its-miroma changed the title Add warning for project location. Project location May 2, 2025
@its-miroma its-miroma self-assigned this May 2, 2025
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
@Thomas1034
Copy link
Contributor Author

You should also add your username to authors

It's a very small change and you suggested a good deal of the wording; do you think it merits that?

@its-miroma
Copy link
Member

its-miroma commented May 4, 2025

yes, of course!
please preserve the alphabetical order

@its-miroma its-miroma removed their assignment May 15, 2025
@its-miroma its-miroma merged commit fef78e7 into FabricMC:main Sep 17, 2025
7 checks passed
@its-miroma its-miroma added stage:ready and removed priority:medium This should be addressed relatively quickly todo:cleanup This should be cleaned up labels Sep 17, 2025
its-miroma added a commit to dicedpixels/fabric-docs that referenced this pull request Sep 24, 2025
* upstream/main:
  Update rendering concepts page (FabricMC#362)
  "Setting up a Development Environment": VS Code (FabricMC#360)
  Running Game Tests In Github Actions (FabricMC#338)
  Items: Item Models (FabricMC#324)
  Call `.useBlockPrefixedTranslationKey()` (FabricMC#358)
  Clarify that `mod-id` placeholders must be customized (FabricMC#348)
  replace remaining mentions of tickDelta with tickProgress (FabricMC#361)
  Project location (FabricMC#326)
  improve the first items docs to state what's needed for item appearance, link fix (FabricMC#359)
kevinthegreat1 pushed a commit to kevinthegreat1/fabric-docs that referenced this pull request Oct 14, 2025
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
(cherry picked from commit fef78e7)
kevinthegreat1 pushed a commit to kevinthegreat1/fabric-docs that referenced this pull request Oct 14, 2025
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
(cherry picked from commit fef78e7)
kevinthegreat1 pushed a commit to kevinthegreat1/fabric-docs that referenced this pull request Oct 15, 2025
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
(cherry picked from commit fef78e7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement A new addition to an already existing page

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants