Running Game Tests #338
Merged
Running Game Tests #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
its-miroma
reviewed
Jul 2, 2025
its-miroma
added
improvement
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
its-miroma
reviewed
Aug 17, 2025
Contributor
Author
|
Turns out I literally didn't even add gametest to the jvm arg... Ooops. This pr now works as expected. The only problem is that I couldn't get code group to work with the enhanced snippets, so the last two snippets are two snippets instead of one code group, which shouldn't be a big issue. |
its-miroma
previously approved these changes
Sep 16, 2025
Member
its-miroma
left a comment
its-miroma
left a comment
There was a problem hiding this comment.
LGTM!
I don't think we can use code groups with transclusions.
its-miroma
removed
the
priority:low
modmuss50
reviewed
Sep 20, 2025
modmuss50
approved these changes
Sep 20, 2025
its-miroma
approved these changes
Sep 20, 2025
its-miroma
added a commit
to dicedpixels/fabric-docs
that referenced
this pull request
Sep 24, 2025
* upstream/main: Update rendering concepts page (FabricMC#362) "Setting up a Development Environment": VS Code (FabricMC#360) Running Game Tests In Github Actions (FabricMC#338) Items: Item Models (FabricMC#324) Call `.useBlockPrefixedTranslationKey()` (FabricMC#358) Clarify that `mod-id` placeholders must be customized (FabricMC#348) replace remaining mentions of tickDelta with tickProgress (FabricMC#361) Project location (FabricMC#326) improve the first items docs to state what's needed for item appearance, link fix (FabricMC#359)
kevinthegreat1
added a commit
to kevinthegreat1/fabric-docs
that referenced
this pull request
Oct 14, 2025
* Add running game tests * Fix gradle working directory * Apply suggestions from code review Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> * Remove xvfb * Use Loom production run tasks * Fix production run task configuration * Add client game test to prodClient * Only add game test jvm arg --------- Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit a01712f)
kevinthegreat1
added a commit
to kevinthegreat1/fabric-docs
that referenced
this pull request
Oct 14, 2025
* Add running game tests * Fix gradle working directory * Apply suggestions from code review Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> * Remove xvfb * Use Loom production run tasks * Fix production run task configuration * Add client game test to prodClient * Only add game test jvm arg --------- Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit a01712f)
kevinthegreat1
added a commit
to kevinthegreat1/fabric-docs
that referenced
this pull request
Oct 15, 2025
* Add running game tests * Fix gradle working directory * Apply suggestions from code review Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> * Remove xvfb * Use Loom production run tasks * Fix production run task configuration * Add client game test to prodClient * Only add game test jvm arg --------- Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit a01712f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds instructions on how to run game tests locally and on github actions.