Update rendering concepts page #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cassiancc
previously approved these changes
Sep 18, 2025
its-miroma
added
correction
Contributor
Author
|
I am going to merge this if there are no other reviews. |
its-miroma
requested changes
Sep 23, 2025
Member
its-miroma
left a comment
its-miroma
left a comment
There was a problem hiding this comment.
slight reword, LGTM!
kinda confusing, but that's passable
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
its-miroma
approved these changes
Sep 23, 2025
its-miroma
added a commit
to dicedpixels/fabric-docs
that referenced
this pull request
Sep 24, 2025
* upstream/main: Update rendering concepts page (FabricMC#362) "Setting up a Development Environment": VS Code (FabricMC#360) Running Game Tests In Github Actions (FabricMC#338) Items: Item Models (FabricMC#324) Call `.useBlockPrefixedTranslationKey()` (FabricMC#358) Clarify that `mod-id` placeholders must be customized (FabricMC#348) replace remaining mentions of tickDelta with tickProgress (FabricMC#361) Project location (FabricMC#326) improve the first items docs to state what's needed for item appearance, link fix (FabricMC#359)
kevinthegreat1
added a commit
to kevinthegreat1/fabric-docs
that referenced
this pull request
Oct 14, 2025
* Update rendering concepts page * Uncomment note in hud.md * Apply suggestions from code review --------- Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit 054180d)
kevinthegreat1
added a commit
to kevinthegreat1/fabric-docs
that referenced
this pull request
Oct 14, 2025
* Update rendering concepts page * Uncomment note in hud.md * Apply suggestions from code review --------- Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit 054180d)
kevinthegreat1
added a commit
to kevinthegreat1/fabric-docs
that referenced
this pull request
Oct 15, 2025
* Update rendering concepts page * Uncomment note in hud.md * Apply suggestions from code review --------- Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com> (cherry picked from commit 054180d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the code. It's still a bit confusing, but it should be at least correct and guide people on where to look.