Skip to content

Call .useBlockPrefixedTranslationKey() #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cassiancc merged 6 commits into from
Sep 17, 2025
Merged

Call .useBlockPrefixedTranslationKey() #358

cassiancc merged 6 commits into from
Sep 17, 2025

Conversation

@vgl266
Copy link
Contributor

@vgl266 vgl266 commented Sep 13, 2025 •
edited by its-miroma
Loading

fix #265
supersede and close #317

@vgl266 vgl266 requested a review from a team as a code owner September 13, 2025 11:20
@netlify
Copy link

netlify bot commented Sep 13, 2025 •
edited
Loading

✅ Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit 2273aca
🔍 Latest deploy log https://app.netlify.com/projects/nimble-elf-d9d491/deploys/68cac31d074cc80008638e98
😎 Deploy Preview https://deploy-preview-358--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@modmuss50
Copy link
Member

modmuss50 commented Sep 15, 2025

This seems to be causing the build to fail:

java.lang.RuntimeException: Existing translation key found - block.fabric-docs-reference.condensed_dirt - Duplicate will be ignored.

@vgl266
Copy link
Contributor Author

vgl266 commented Sep 15, 2025

@modmuss50 there are 2 ways to deal with it:

  1. remove
    translationBuilder.add(ModBlocks.CONDENSED_DIRT.asItem(), "Condensed Dirt");
    and similar entries from translationBuilder
  2. Add reference into Adding Block Translations page that the reader needs to also add item string separately if they aren't going to use datagen later

Since aforementioned code doesn't appear to be referenced on datagen page, I propose the first solution

@vgl266 vgl266 marked this pull request as draft September 16, 2025 07:49
@vgl266 vgl266 marked this pull request as ready for review September 16, 2025 11:36
@its-miroma its-miroma added improvement A new addition to an already existing page todo:verify This needs to be reviewed priority:low This is nice to have, but it can wait a little correction Something isn't right on a page and removed improvement A new addition to an already existing page labels Sep 17, 2025
@vgl266
Copy link
Contributor Author

vgl266 commented Sep 17, 2025

Don't really understand why it doesn't accept en_US.json

@its-miroma its-miroma removed the priority:low This is nice to have, but it can wait a little label Sep 17, 2025
@its-miroma its-miroma changed the title Added .useBlockPrefixedTranslationKey() Call .useBlockPrefixedTranslationKey() Sep 17, 2025
@its-miroma
Copy link
Member

its-miroma commented Sep 17, 2025

@vgl266 You should run datagen again locally.

@vgl266 vgl266 marked this pull request as draft September 17, 2025 09:34
@vgl266 vgl266 marked this pull request as ready for review September 17, 2025 14:19
@cassiancc cassiancc merged commit 45413c6 into FabricMC:main Sep 17, 2025
6 checks passed
@cassiancc
Copy link
Member

cassiancc commented Sep 17, 2025

Thank you for your contribution!

@its-miroma its-miroma added stage:ready and removed todo:verify This needs to be reviewed labels Sep 20, 2025
its-miroma added a commit to dicedpixels/fabric-docs that referenced this pull request Sep 24, 2025
@its-miroma
Merge remote-tracking branch 'upstream/main' into pr/357
04c1e8e 
* upstream/main:
  Update rendering concepts page (FabricMC#362)
  "Setting up a Development Environment": VS Code (FabricMC#360)
  Running Game Tests In Github Actions (FabricMC#338)
  Items: Item Models (FabricMC#324)
  Call `.useBlockPrefixedTranslationKey()` (FabricMC#358)
  Clarify that `mod-id` placeholders must be customized (FabricMC#348)
  replace remaining mentions of tickDelta with tickProgress (FabricMC#361)
  Project location (FabricMC#326)
  improve the first items docs to state what's needed for item appearance, link fix (FabricMC#359)
kevinthegreat1 pushed a commit to kevinthegreat1/fabric-docs that referenced this pull request Oct 14, 2025
@vgl266 @kevinthegreat1
Call .useBlockPrefixedTranslationKey() (FabricMC#358)
3d13cac 
* Added .useBlockPrefixedTranslationKey()

* Update FabricDocsReferenceEnglishLangProvider.java

removed duplicates

* Update en_us.json

* rerun datagen

(cherry picked from commit 45413c6)
kevinthegreat1 pushed a commit to kevinthegreat1/fabric-docs that referenced this pull request Oct 14, 2025
@vgl266 @kevinthegreat1
Call .useBlockPrefixedTranslationKey() (FabricMC#358)
747cb5d 
* Added .useBlockPrefixedTranslationKey()

* Update FabricDocsReferenceEnglishLangProvider.java

removed duplicates

* Update en_us.json

* rerun datagen

(cherry picked from commit 45413c6)
kevinthegreat1 pushed a commit to kevinthegreat1/fabric-docs that referenced this pull request Oct 15, 2025
@vgl266 @kevinthegreat1
Call .useBlockPrefixedTranslationKey() (FabricMC#358)
8dd8a40 
* Added .useBlockPrefixedTranslationKey()

* Update FabricDocsReferenceEnglishLangProvider.java

removed duplicates

* Update en_us.json

* rerun datagen

(cherry picked from commit 45413c6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cassiancc cassiancc cassiancc approved these changes

Assignees

No one assigned

Labels

correction Something isn't right on a page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Creating Your First Block": missing call to .useBlockPrefixedTranslationKey()

4 participants

@vgl266 @modmuss50 @its-miroma @cassiancc