Chore/electron30#411
Conversation
This commit contains changes that should be rebased on top of upstream.
Experimentally publish universal binaries on macOS. This should actually simplify matters with electron-builder significantly.
* chore: url whitespace workaround * chore: add workaround for insecure renegotation * chore: don't include cstdio * chore: fix default url flags * chore: avoid needing openssl header * Make test targets match release builds for ubuntu/mac * fix: bail early in SetUrlOpts on empty URL * fix: properly reset URL state in Easy::Reset * fix: copy ctor should copy urldata Co-authored-by: David Marby <david@dmarby.se>
* support electron 21 * add brew action actions/runner-images#6283 * bump node-gyp * pin node 16.16.0 * and pin windows to 16.16.0 * pin the rest * GetCreationContext * fix attempt clean up GH actions old node versions + fix deprecated set-output * add debug log to failed script * try to force openssl version * [chore] Attempt latest OS and vs versions (#7) * Attempt latest OS and vs versions * Remove appveyor, circleci and travis Co-authored-by: Filipe Freire <livrofubia@gmail.com>
* Bump electron 21.2 * bump package version Co-authored-by: jackkav <jackkav@gmail.com>
* Un-force the openssl version on build.sh * tidy up action version numbers * bump package.json version * rm cat_slower, use no-tests instead of no-test
* bump * skip http2 test * bump version
* node 18.17.1 electron 27 * mac version bump * bump deps * comment out brotli from node version * force zlib to 1.2.13 * typo * typo * tag 2.3.6-21 --------- Co-authored-by: Filipe Freire <livrofubia@gmail.com>
* update nvmrc and uncomment http2 test * Update http2.spec.ts
…#23) * use --with-secure-transport to build libcurl on macos * fix build errors
* bump deps * bump pkg * bump node-gyp * bump nan * chore(bump): electron-mocha
* fix(curl): revert to use openssl on macos * force rebuild for macos
* bump node * bump electron * bump nan * bump lockfile * remove max conflict macro * remove max conflict macro move to top * and in easy.cc * remove max conflict macro for goof * show node version in debug log * debug * move node under brew
|
Hey @jackkav, sorry for the lack of response to the PRs you opened. I know you guys have a separate fork, but wanted to mention that this PR was still useful as it helped me skip some build failures that you guys also had. I will probably also cherry-pick the URL options you added in the fork, however, this will probably only happen after porting the addon to use N-API, which I plan to start working on around February. |
|
I was opening them unintentionally because I had misconfigured this repo as my base branch rather than our fork. Its cool to hear you're interested in investing further in this, as without n-api we need to bump this module every few months. I've looked a little into just porting the C code to napi but struggled without your domain knowledge and C experience, hopefully my notes over here might be of some use Kong#50 |
7 participants
No description provided.