Add: HTTP Server and LSP server toggles to quick settings#14972
Add: HTTP Server and LSP server toggles to quick settings#14972Siedlerchr merged 10 commits intoJabRef:mainfrom
Conversation
|
Hey @Jalina2007! 👋 Thank you for contributing to JabRef! We have automated checks in place, based on which you will soon get feedback if any of them are failing. We also use Qodo for review assistance. It will update your pull request description with a review help and offer suggestions to improve the pull request. After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs. You can read about the whole pull request process in our contribution guide. Please ensure that your pull request is in line with our AI Usage Policy and make necessary disclosures. |
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
koppor
left a comment
There was a problem hiding this comment.
Please align the toggle buttons vertically.
koppor
left a comment
There was a problem hiding this comment.
I think,wrong approach. Now at preferences and quick settings http server restart.
Add a listener at the http+lsp preferences.
|
Hi, I made the changes by adding a listener instead of manually starting the servers at the toggles. Please let me know if any further changes are needed. |
|
@Jalina2007 Can you explain to me why you write me a message instead of fixing the "Unit tests -jablib"? Is it really hard to understand the message #14972? Please explain me. Please, please, please, ... Many contributors don't understand. Are you just NOT READING or ist it really too hard to understand? And if yes, which part of the message is too hard to understand? |
|
@Jalina2007 Either you did not adress my comment or not update the screenshot. If you did not update the screenshot - how can we guide contributors in general to UPDATE SCREENSHOT if the screen changed? Do we need an AI telling contributors to do so? |
koppor
left a comment
There was a problem hiding this comment.
Sorry for the back and forth; your PR fostered internal discussions 😅
…4902 * upstream/main: (23 commits) Some more recipes from OpenRewrite (JabRef#15030) feat: Add PDF Upload endpoint to EntryResource (JabRef#14963) Heuristics also used at batch (JabRef#15025) Fix cleanup-pr.yml New Crowdin updates (JabRef#15035) Use patched Gradle version (JabRef#15034) Add OpenAlex-based Citation Fetcher (JabRef#15023) Update null annotaitons at EntryBasedFetcher (JabRef#15024) Fix CHANGELOG.md test Use _ for unused variables (JabRef#15028) Use ubuntu-latest for checkstyle and javadoc Update Gradle Wrapper from 9.3.0-jabref-2 to 9.3.1 (JabRef#15021) Use "ubuntu-slim" for most workflows (JabRef#15019) Refine GroupsTree (JabRef#15013) New Crowdin updates (JabRef#15018) Added Clear group option (JabRef#15017) Chore(deps): Bump com.uber.nullaway:nullaway from 0.12.15 to 0.13.1 in /versions (JabRef#15006) Chore(deps): Bump tools.jackson:jackson-bom in /versions (JabRef#15007) No rush in Docker building Yaml issue workaround ...
|
Sorry I couldn’t follow up on the remaining review comments in time. I was unavailable for a couple of days. Thanks for taking care of the merge. |
…es/jablib/src/main/resources/csl-styles-6c79ffe * upstream/main: (68 commits) Chore(deps): Bump org.apache.httpcomponents.client5:httpclient5 (#15060) Chore(deps): Bump com.google.errorprone:error_prone_core in /versions (#15059) Chore(deps): Bump de.undercouch.download:de.undercouch.download.gradle.plugin (#15057) Chore(deps): Bump org.postgresql:postgresql in /versions (#15058) Chore(deps): Bump de.undercouch.download:de.undercouch.download.gradle.plugin (#15056) Updates on Wednesday, not on Sunday Add screenshot requirement (#15050) Switch image for javadoc Better docker layer caching during build (#15042) New Crowdin updates (#15045) Chore: reuse shared 'setup-gradle' in all places in test-code.yml (#15043) Chore: add 'testlens-app/setup-testlens' GH action (#15044) Add: HTTP Server and LSP server toggles to quick settings (#14972) Some more recipes from OpenRewrite (#15030) feat: Add PDF Upload endpoint to EntryResource (#14963) Heuristics also used at batch (#15025) Fix cleanup-pr.yml New Crowdin updates (#15035) Use patched Gradle version (#15034) Add OpenAlex-based Citation Fetcher (#15023) ...
User description
Closes #14902
Steps to test
Simply run the program and the changes will be visible under quick settings as requested in the issue.
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)PR Type
Enhancement
Description
Add HTTP Server and LSP server toggle switches to quick settings
Integrate HttpServerManager and LanguageServerController with UI toggles
Enable users to start/stop servers directly from welcome tab
Bind toggle states to remote preferences for persistence
Diagram Walkthrough
File Walkthrough
JabRefFrame.java
Inject server managers into WelcomeTabjabgui/src/main/java/org/jabref/gui/frame/JabRefFrame.java
LanguageServerController, and UiMessageHandler as constructor
arguments
WelcomeTab.java
Add server manager dependencies to WelcomeTabjabgui/src/main/java/org/jabref/gui/welcome/WelcomeTab.java
LanguageServerController, and UiMessageHandler
QuickSettings component
QuickSettings.java
Add HTTP and LSP server toggle switches with control logicjabgui/src/main/java/org/jabref/gui/welcome/components/QuickSettings.java
LanguageServerController, and related classes
dependencies
bidirectional binding to remote preferences
stopLanguageServer methods