Conversation
Review Summary by QodoAdd specific screenshot requirement to PR template
WalkthroughsDescription• Add specific screenshot requirement to PR template • Require screenshot showing library with single entry • Entry must have submitter as author and issue number as title Diagramflowchart LR
A["PR Template"] -- "Add screenshot requirement" --> B["Library entry screenshot"]
B -- "Author: submitter" --> C["Issue number as title"]
File Changes1. .github/PULL_REQUEST_TEMPLATE.md
|
Code Review by Qodo
✅ 1.
|
| - [.] I manually tested my changes in running JabRef (always required) | ||
| - [.] I added JUnit tests for changes (if applicable) | ||
| - [.] I added screenshots in the PR description (if change is visible to the user) | ||
| - [.] I added a screenshot in the PR description showing library with a single entry with me as author and as title the issue number. |
There was a problem hiding this comment.
1. Ci checkbox count mismatch 🐞 Bug ⛯ Reliability
• The PR template now contains 7 checkbox lines under “### Mandatory checks”. • The “Check PR Format” workflow enforces an exact checkbox-line count of 6, so PRs using the updated template will fail CI even if the author follows the template. • This creates a contribution blocker (false-negative) and will require manual intervention or template rollback.
Agent Prompt
### Issue description
The PR template adds a new mandatory checkbox line, but the GitHub Actions workflow `.github/workflows/pr-format.yml` still requires exactly 6 checkbox lines under `### Mandatory checks`. This will fail CI for otherwise-correct PRs.
### Issue Context
The workflow extracts checkbox lines (`grep "^- \["`) and enforces `LINE_COUNT != 6` as an error. The template now includes 7 checkbox lines.
### Fix Focus Areas
- .github/workflows/pr-format.yml[117-132]
- .github/PULL_REQUEST_TEMPLATE.md[37-43]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
✅ All tests passed ✅🏷️ Commit: c64283e Learn more about TestLens at testlens.app. |
…es/jablib/src/main/resources/csl-styles-6c79ffe * upstream/main: (68 commits) Chore(deps): Bump org.apache.httpcomponents.client5:httpclient5 (#15060) Chore(deps): Bump com.google.errorprone:error_prone_core in /versions (#15059) Chore(deps): Bump de.undercouch.download:de.undercouch.download.gradle.plugin (#15057) Chore(deps): Bump org.postgresql:postgresql in /versions (#15058) Chore(deps): Bump de.undercouch.download:de.undercouch.download.gradle.plugin (#15056) Updates on Wednesday, not on Sunday Add screenshot requirement (#15050) Switch image for javadoc Better docker layer caching during build (#15042) New Crowdin updates (#15045) Chore: reuse shared 'setup-gradle' in all places in test-code.yml (#15043) Chore: add 'testlens-app/setup-testlens' GH action (#15044) Add: HTTP Server and LSP server toggles to quick settings (#14972) Some more recipes from OpenRewrite (#15030) feat: Add PDF Upload endpoint to EntryResource (#14963) Heuristics also used at batch (#15025) Fix cleanup-pr.yml New Crowdin updates (#15035) Use patched Gradle version (#15034) Add OpenAlex-based Citation Fetcher (#15023) ...
No description provided.