Some more recipes from OpenRewrite

[koppor]

User description

Should have no effect.

Mandatory checks

• I own the copyright of the code submitted and I license it under the MIT license
• [/] I manually tested my changes in running JabRef (always required)
• I added JUnit tests for changes (if applicable)
• [/] I added screenshots in the PR description (if change is visible to the user)
• [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
• [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

---

PR Type

Enhancement

---

Description

• Add OpenRewrite recipes for code cleanup and modernization

• Enable Guava, Java migration, and static analysis recipes

• Add Picnic error-prone refaster rules for code improvements

• Disable configuration cache in separate rewrite workflow

---

Diagram Walkthrough

flowchart LR
  A["rewrite.yml"] -->|Add recipes| B["Java migration recipes"]
  A -->|Add recipes| C["Static analysis recipes"]
  A -->|Add recipes| D["Testing cleanup recipes"]
  A -->|Add recipes| E["Picnic refaster rules"]
  F["run-openrewrite.yml"] -->|Disable cache| G["Gradle rewrite task"]

Loading

File Walkthrough

	Relevant files
Enhancement	rewrite.yml Expand OpenRewrite recipe collection significantly              rewrite.yml Added 20+ new OpenRewrite recipes across multiple categories Enabled Guava migration, Java language features, and static analysis recipes Added Picnic error-prone refaster rules for string and class handling Reorganized and uncommented previously disabled recipes with version tracking +36/-5
Configuration changes	run-openrewrite.yml Disable configuration cache in rewrite workflow                    .github/workflows/run-openrewrite.yml Added --no-configuration-cache flag to Gradle rewrite task Prevents configuration cache issues in separate workflow execution +1/-1

---

[qodo-free-for-open-source-projects]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-free-for-open-source-projects]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Remove recipe that incorrectly changes behavior Remove the PreferSystemGetPropertyOverGetenv recipe because it incorrectly replaces System.getenv() with System.getProperty(), which are not interchangeable and will likely break functionality. rewrite.yml [178] -- org.openrewrite.staticanalysis.PreferSystemGetPropertyOverGetenv +# - org.openrewrite.staticanalysis.PreferSystemGetPropertyOverGetenv Apply / Chat Suggestion importance[1-10]: 10 __ Why: The suggestion correctly points out that the PreferSystemGetPropertyOverGetenv recipe is dangerous as it incorrectly equates system properties with environment variables, which could introduce subtle and critical runtime bugs.	High
	Remove non-existent OpenRewrite recipe Remove the non-existent OpenRewrite recipe org.openrewrite.java.testing.cleanup.AssertLiteralBooleanRemovedRecipe to prevent the rewrite process from failing. rewrite.yml [227-228] - org.openrewrite.java.testing.cleanup.AssertLiteralBooleanToFailRecipes -- org.openrewrite.java.testing.cleanup.AssertLiteralBooleanRemovedRecipe Apply / Chat Suggestion importance[1-10]: 9 __ Why: The suggestion correctly identifies a non-existent OpenRewrite recipe (AssertLiteralBooleanRemovedRecipe) which would cause the CI workflow to fail, thus preventing the PR from being effective.	High
High-level	Introduce new refactoring rules incrementally The suggestion advises against enabling numerous OpenRewrite recipes at once, as this will create a large, difficult-to-review automated pull request. It recommends introducing the new rules in smaller, themed batches for better manageability. Examples: rewrite.yml [108-255] - org.openrewrite.java.migrate.guava.NoMapsAndSetsWithExpectedSize - org.openrewrite.java.migrate.io.ReplaceFileInOrOutputStreamFinalizeWithClose - org.openrewrite.java.migrate.lang.StringFormatted - org.openrewrite.java.migrate.lang.SwitchCaseAssignmentsToSwitchExpression - org.openrewrite.java.migrate.lang.SwitchCaseReturnsToSwitchExpression - org.openrewrite.java.migrate.lang.SwitchExpressionYieldToArrow - org.openrewrite.java.migrate.net.JavaNetAPIs - org.openrewrite.java.migrate.net.URLConstructorToURICreate - org.openrewrite.java.migrate.net.URLConstructorsToNewURI ... (clipped 138 lines) Solution Walkthrough: Before: # rewrite.yml --- type: specs.openrewrite.org/v1beta/recipe name: org.jabref.config.rewrite.cleanup recipeList: # Enable many rules at once - org.openrewrite.java.migrate.guava.NoMapsAndSetsWithExpectedSize - org.openrewrite.java.migrate.lang.StringFormatted - org.openrewrite.java.migrate.lang.SwitchCaseAssignmentsToSwitchExpression # ... many more migration rules - org.openrewrite.staticanalysis.PreferEqualityComparisonOverDifferenceCheck - org.openrewrite.staticanalysis.SimplifyBooleanExpression # ... many more static analysis rules - tech.picnic.errorprone.refasterrules.StringRulesRecipes$EmptyStringRecipe # ... many more picnic rules After: # rewrite.yml (in the first of several PRs) --- type: specs.openrewrite.org/v1beta/recipe name: org.jabref.config.rewrite.cleanup recipeList: # Enable a small, thematic batch of rules - org.openrewrite.java.migrate.lang.StringFormatted - org.openrewrite.java.migrate.lang.SwitchCaseAssignmentsToSwitchExpression - org.openrewrite.java.migrate.lang.SwitchCaseReturnsToSwitchExpression - org.openrewrite.java.migrate.lang.SwitchExpressionYieldToArrow # Thematic batches for future PRs remain commented out # - org.openrewrite.staticanalysis.SimplifyBooleanExpression # - org.openrewrite.staticanalysis.SimplifyBooleanReturn # - tech.picnic.errorprone.refasterrules.StringRulesRecipes$EmptyStringRecipe Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies the significant risk of enabling many refactoring rules at once, which can lead to a massive, hard-to-review automated PR, and proposes a safer, incremental approach.	Medium
More

[Siedlerchr]

Really not working with cofniguration cache?

[koppor]

Yes, I tried out locally.