Skip to content

New Crowdin updates#15035

Merged
koppor merged 2 commits intomainfrom
l10n_main
Feb 4, 2026
Merged

New Crowdin updates#15035
koppor merged 2 commits intomainfrom
l10n_main

Conversation

@Siedlerchr
Copy link
Copy Markdown
Member

No description provided.

@qodo-free-for-open-source-projects
Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Add translations for Clear group action

📝 Documentation

Grey Divider

Walkthroughs

Description
• Add French translation for "Clear group" action
• Add Italian translation for "Clear group" action
• Update localization properties files with new UI strings
Diagram
flowchart LR
  A["Source English String"] -- "French translation" --> B["JabRef_fr.properties"]
  A -- "Italian translation" --> C["JabRef_it.properties"]
Loading

Grey Divider

File Changes

1. jablib/src/main/resources/l10n/JabRef_fr.properties 📝 Documentation +1/-0

Add French translation for Clear group

• Add French translation for "Clear group" key
• New entry: Clear\ group=Vider le groupe
• Inserted between "Remove selected entries from this group" and "Remove group" entries

jablib/src/main/resources/l10n/JabRef_fr.properties


2. jablib/src/main/resources/l10n/JabRef_it.properties 📝 Documentation +1/-0

Add Italian translation for Clear group

• Add Italian translation for "Clear group" key
• New entry: Clear\ group=Cancella il gruppo
• Inserted between "Remove selected entries from this group" and "Remove group" entries

jablib/src/main/resources/l10n/JabRef_it.properties


Grey Divider

Qodo Logo

@koppor koppor enabled auto-merge February 4, 2026 16:07
@qodo-free-for-open-source-projects
Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Action required

1. Manual translations violate Crowdin process 🐞 Bug ✓ Correctness
Description
• This PR manually adds translations for 'Clear\ group' to French and Italian property files,
  violating the documented localization process
• According to docs/code-howtos/localization.md line 62, translations for non-English languages
  should only be added through Crowdin and will be overwritten if added manually
• The key already exists in the English base file (JabRef_en.properties line 587) and is used in
  StandardActions.java line 226, but only 3 of 26 language files have this translation
• When the key is missing, Localization.java's lookup method (line 131-134) returns the key itself
  as fallback, so users of other languages will see 'Clear group' untranslated
Code

jablib/src/main/resources/l10n/JabRef_fr.properties[587]

+Clear\ group=Vider le groupe
Evidence
The localization documentation explicitly prohibits manual translations to non-English property
files, stating they will be overwritten by Crowdin. The PR adds translations only to French and
Italian files, while 23 other language files lack this key. The Localization.java implementation
shows that missing keys result in the key itself being returned as fallback text.

docs/code-howtos/localization.md[62-62]
jablib/src/main/java/org/jabref/logic/l10n/Localization.java[131-135]
jabgui/src/main/java/org/jabref/gui/actions/StandardActions.java[226-226]
jablib/src/main/resources/l10n/JabRef_en.properties[587-587]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue Description
This PR manually adds translations for the 'Clear group' localization key to French and Italian property files, which violates the project's documented localization process. According to the localization guidelines, all non-English translations must be managed through Crowdin and will be overwritten if added manually.

## Issue Context
- The 'Clear group' key already exists in the English base file (JabRef_en.properties line 587)
- The key is actively used in the codebase (StandardActions.java line 226)
- The project uses Crowdin for managing all non-English translations
- Manual translations will be overwritten during the next Crowdin sync
- There are 26 language property files in total, but only 3 have this translation

## Fix Focus Areas
- jablib/src/main/resources/l10n/JabRef_fr.properties[587-587]
- jablib/src/main/resources/l10n/JabRef_it.properties[587-587]

## Recommended Fix
1. Remove the manually added 'Clear\ group=' lines from both JabRef_fr.properties and JabRef_it.properties
2. Ensure the key exists in JabRef_en.properties (it already does at line 587)
3. Let Crowdin handle the translation to all supported languages through the normal translation workflow
4. If urgent translations are needed, they should be added through the Crowdin platform, not directly to the property files

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@koppor koppor added this pull request to the merge queue Feb 4, 2026
@github-actions github-actions Bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Feb 4, 2026
Merged via the queue into main with commit 57c19be Feb 4, 2026
61 checks passed
@koppor koppor deleted the l10n_main branch February 4, 2026 16:57
Siedlerchr added a commit that referenced this pull request Feb 4, 2026
* upstream/main:
  New Crowdin updates (#15035)
  Use patched Gradle version (#15034)
  Add OpenAlex-based Citation Fetcher (#15023)
  Update null annotaitons at EntryBasedFetcher (#15024)
  Fix CHANGELOG.md test
  Use _ for unused variables (#15028)
  Use ubuntu-latest for checkstyle and javadoc
  Update Gradle Wrapper from 9.3.0-jabref-2 to 9.3.1 (#15021)
  Use "ubuntu-slim" for most workflows (#15019)
  Refine GroupsTree (#15013)
Siedlerchr added a commit to Jalina2007/jabref that referenced this pull request Feb 5, 2026
…4902

* upstream/main: (23 commits)
  Some more recipes from OpenRewrite (JabRef#15030)
  feat: Add PDF Upload endpoint to EntryResource (JabRef#14963)
  Heuristics also used at batch (JabRef#15025)
  Fix cleanup-pr.yml
  New Crowdin updates (JabRef#15035)
  Use patched Gradle version (JabRef#15034)
  Add OpenAlex-based Citation Fetcher (JabRef#15023)
  Update null annotaitons at EntryBasedFetcher (JabRef#15024)
  Fix CHANGELOG.md test
  Use _ for unused variables (JabRef#15028)
  Use ubuntu-latest for checkstyle and javadoc
  Update Gradle Wrapper from 9.3.0-jabref-2 to 9.3.1 (JabRef#15021)
  Use "ubuntu-slim" for most workflows (JabRef#15019)
  Refine GroupsTree (JabRef#15013)
  New Crowdin updates (JabRef#15018)
  Added Clear group option (JabRef#15017)
  Chore(deps): Bump com.uber.nullaway:nullaway from 0.12.15 to 0.13.1 in /versions (JabRef#15006)
  Chore(deps): Bump tools.jackson:jackson-bom in /versions (JabRef#15007)
  No rush in Docker building
  Yaml issue workaround
  ...
Siedlerchr added a commit that referenced this pull request Feb 8, 2026
…es/jablib/src/main/resources/csl-styles-6c79ffe

* upstream/main: (68 commits)
  Chore(deps): Bump org.apache.httpcomponents.client5:httpclient5 (#15060)
  Chore(deps): Bump com.google.errorprone:error_prone_core in /versions (#15059)
  Chore(deps): Bump de.undercouch.download:de.undercouch.download.gradle.plugin (#15057)
  Chore(deps): Bump org.postgresql:postgresql in /versions (#15058)
  Chore(deps): Bump de.undercouch.download:de.undercouch.download.gradle.plugin (#15056)
  Updates on Wednesday, not on Sunday
  Add screenshot requirement (#15050)
  Switch image for javadoc
  Better docker layer caching during build (#15042)
  New Crowdin updates (#15045)
  Chore: reuse shared 'setup-gradle' in all places in test-code.yml (#15043)
  Chore: add 'testlens-app/setup-testlens' GH action (#15044)
  Add: HTTP Server and LSP server toggles to quick settings (#14972)
  Some more recipes from OpenRewrite (#15030)
  feat: Add PDF Upload endpoint to EntryResource (#14963)
  Heuristics also used at batch (#15025)
  Fix cleanup-pr.yml
  New Crowdin updates (#15035)
  Use patched Gradle version (#15034)
  Add OpenAlex-based Citation Fetcher (#15023)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: to-be-merged PRs which are accepted and should go into the merge-queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants