[PYTHON] generate code based on pydantic v2 by fa0311 · Pull Request #16636 · OpenAPITools/openapi-generator

fa0311 · 2023-09-21T07:48:53Z

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package 
./bin/generate-samples.sh ./bin/configs/*.yaml
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

* Update README.md * Update team.yml * Update pom.xml

* Fix spring scope property * Adapt test files

… skipIfSpecIsUnchanged=true (Fixes OpenAPITools#16490) (OpenAPITools#16491) * Don't delete output directory if spec is unchanged Resolves OpenAPITools#16490 * Fix some typos

* add nullable case to spring test spec * generate samples for changed spring input * add nullable case to general test spec * generate samples for changed general input * generate samples again * generates samples again * re-build from new sources, generates samples again

…ITools#16565) * update github workflow, use debug instead of warning * use debug instead of warn

…rator) (OpenAPITools#16563) * fix integer default value with double qutoe (kotlin jaxrs) * add enum tests * fix typo * update samples

…ols#16525) * [Go] return errors that happen while unmarshalling objects * Update model samples * More updates to samples * Update failing Go store API test to match the one that passes

* better tests for php nextgen * add new files

Fixed a bug in postProcessAllModels, changing an anyOf to a oneOf.

…6580) * spec for recommend test * add ValidateTask test for custom defined tasks * add ValidateTask test for recommend option * ValidateTask recommend default value is true

…penAPITools#16504)

…va (OkHttp) Implementation of OpenAPITools#16547 (OpenAPITools#16550) * Autosets the parameters with the only value specified as enum if the parameter is also marked as required * Autosets the parameters with the only value specified as enum if the parameter is also marked as required * Autosets the parameters with the only value specified as enum if the parameter is also marked as required for Java default client. * Autosets the parameters with the only value specified as enum if the parameter is also marked as required for Java default client. * Autosets the parameters with the only value specified as enum if the parameter is also marked as required for Java default client. * Autosets the parameters with the only value specified as enum if the parameter is also marked as required for Java default client.

* update go gin to newer version * update test

* update java undertow to newer version * update compiler plugin to newer version * test undertow in circleci * use 3.0 spec

* fix(go-server): Allow optional request bodies Closes OpenAPITools#16578 * chore: Run scripts * chore: Remove unnecessary whitespace change * fix: Use correct error

* v7.0.1 release * update readme * update template * update readme

* prepare v7.1.0 in master * update

wing328 · 2023-09-22T02:10:59Z

thank you 👍

but looks like a recent rebase messed up this PR which now contains commits not authored by you.

do you mind submitting a new PR by cherry-picking the commits owned by you?

fa0311 · 2023-09-22T02:28:43Z

but looks like a recent rebase messed up this PR which now contains commits not authored by you.

This PR is based on #16549 and contains commits I have not made.
Should the base branch be OpenAPITools:oshmoun-master?

wing328 · 2023-09-22T02:31:55Z

Should the base branch be OpenAPITools:oshmoun-master?

yes please as I made some enhancements on top of #16469

fa0311 · 2023-09-22T02:38:00Z

This PR contains a commit to resolve a conflict with OpenAPITools:master.

wing328 · 2023-09-22T02:44:59Z

Just PM you via Slack to further discuss this.

multani · 2023-09-23T08:34:39Z

Hey @fa0311 , I was doing something related in #16624: I'm not sure how much it will conflict with your changes for Pydantic v2, but I'm putting my work on hold and I'll wait for your pull request to be merged first because I will need Pydantic v2 to actually achieve what I want to do.

I'll rebase/readjust my work once your pull request has been merged, it's hard how much work it will be right now ;)

I'll keep an eye on your changes, let me know if I can help!

wing328 · 2023-09-23T08:53:29Z

@multani I'd a discussion with @fa0311 yesterday about your PR and we would like to get your PR merged first.

Signed-off-by: ふぁ <yuki@yuki0311.com>

fa0311 · 2023-09-24T00:01:27Z

My environmental test was 206 passed, 2 skipped, 1 warning in 33.10s 🎉

Signed-off-by: ふぁ <yuki@yuki0311.com>

wing328 · 2023-09-24T01:18:02Z

@fa0311 I'd a discussion with @multani last night and just want to share the game plan with you and get your feedback as well.

We'll create another client generator called python-pydantic-v1 and python client generator will support pydantic v2 only moving forward since it's not easy to maintain both pydantic v1 and v2 in the same generator, and we can then more easily consolidate efforts to focus on pydantic v2 support.

We'll get #16624 merged first (as it was tested with pydantic v2 when @multani worked on it) and then we will merge this one.

Let me know your thought as well.

wing328 · 2023-09-24T02:42:47Z

(and looks like a rebase wasn't performed correctly as this PR contains commits not authored by you)

fa0311 · 2023-09-24T10:07:58Z

Continue to #16655

spacether and others added 30 commits September 11, 2023 12:49

Removes spacether (OpenAPITools#16551)

78f3b19

* Update README.md * Update team.yml * Update pom.xml

use TypeInfoResolver (OpenAPITools#16548)

1901bf2

Use backed enums in php-nextgen (OpenAPITools#16556)

8b15d48

fix parent class check in ObjectSerializer (OpenAPITools#16558)

cd0fde4

better null check for schema types (OpenAPITools#16564)

ad589c7

Fix spring scope property (OpenAPITools#16553)

c6d355e

* Fix spring scope property * Adapt test files

[maven-generator] Do not cleanup output if spec file is unchanged and…

196c2b1

… skipIfSpecIsUnchanged=true (Fixes OpenAPITools#16490) (OpenAPITools#16491) * Don't delete output directory if spec is unchanged Resolves OpenAPITools#16490 * Fix some typos

fix jaxrs sample tests (OpenAPITools#16566)

7054312

[python] Update github workflow, use debug instead of warning (OpenAP…

a5f79a7

…ITools#16565) * update github workflow, use debug instead of warning * use debug instead of warn

Fix integer default value with double quote (kotlin jaxrs server gene…

9c4f6c4

…rator) (OpenAPITools#16563) * fix integer default value with double qutoe (kotlin jaxrs) * add enum tests * fix typo * update samples

[Go] return errors that happen while unmarshalling objects (OpenAPITo…

5b4d970

…ols#16525) * [Go] return errors that happen while unmarshalling objects * Update model samples * More updates to samples * Update failing Go store API test to match the one that passes

add go echo api tests (OpenAPITools#16570)

781ccae

Better tests for php-nextgen (OpenAPITools#16569)

4260c7a

* better tests for php nextgen * add new files

fix enum in python flask (OpenAPITools#16576)

9170e10

Java 11 (OpenAPITools#16581)

353507e

Update AbstractCSharpCodegen.java (OpenAPITools#16577)

82e3590

Fixed a bug in postProcessAllModels, changing an anyOf to a oneOf.

Fix ValidateTask failure if recommend is not assigned (OpenAPITools#1…

ec59334

…6580) * spec for recommend test * add ValidateTask test for custom defined tasks * add ValidateTask test for recommend option * ValidateTask recommend default value is true

[swift] remove unavailable property to fix Xcode 15 compiler error (O…

e75e5a2

…penAPITools#16504)

better null check to avoid NPE (OpenAPITools#16588)

d671fe2

remove option, update doc (OpenAPITools#16592)

70bffff

Update go gin to newer version (OpenAPITools#16593)

5f0d705

* update go gin to newer version * update test

Add postman-collection generator to list (others) (OpenAPITools#16599)

7d86adc

Update java undertow to newer version (OpenAPITools#16606)

8c8be74

* update java undertow to newer version * update compiler plugin to newer version * test undertow in circleci * use 3.0 spec

fix(go-server): Allow optional request bodies (OpenAPITools#16579)

352182a

* fix(go-server): Allow optional request bodies Closes OpenAPITools#16578 * chore: Run scripts * chore: Remove unnecessary whitespace change * fix: Use correct error

7.0.1 release (OpenAPITools#16607)

875c3ec

* v7.0.1 release * update readme * update template * update readme

trigger build

5b720de

Prepare v7.1.0 in master (OpenAPITools#16608)

5e8e2d7

* prepare v7.1.0 in master * update

add -SkipPublisherCheck (OpenAPITools#16610)

bab67e4

fa0311 changed the base branch from oshmoun-master to master September 22, 2023 01:19

fa0311 added 2 commits September 22, 2023 10:33

[python] replace __fields_set__ with model_fields_set

cf1781f

[python] replace getheaders with headers

6e43dd9

wing328 changed the base branch from master to oshmoun-master September 22, 2023 02:30

wing328 changed the base branch from oshmoun-master to master September 22, 2023 02:30

fa0311 changed the base branch from master to oshmoun-master September 22, 2023 02:32

[python] replace update_forward_refs with model_rebuild

2a38bbf

multani mentioned this pull request Sep 23, 2023

python: generate Pydantic v2 + typing complete code #16624

Merged

5 tasks

fa0311 added 7 commits September 24, 2023 00:36

[python] remove __properties

335761f

Signed-off-by: ふぁ <yuki@yuki0311.com>

[python] fix private property not initialized

4fa39c7

Signed-off-by: ふぁ <yuki@yuki0311.com>

[python] update test cases

b82dbfd

Signed-off-by: ふぁ <yuki@yuki0311.com>

[python] fix validation error for oneOf and anyOf

4b6d91f

Signed-off-by: ふぁ <yuki@yuki0311.com>

[python] update test cases

f36b540

Signed-off-by: ふぁ <yuki@yuki0311.com>

[python] update circular import

fc3e024

Signed-off-by: ふぁ <yuki@yuki0311.com>

[python] update samples

99b39ee

Signed-off-by: ふぁ <yuki@yuki0311.com>

[python] restore getheaders

91a1d9a

Signed-off-by: ふぁ <yuki@yuki0311.com>

fa0311 marked this pull request as ready for review September 24, 2023 00:42

fa0311 requested a review from jimschubert as a code owner September 24, 2023 00:42

fa0311 closed this Sep 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[PYTHON] generate code based on pydantic v2#16636

[PYTHON] generate code based on pydantic v2#16636
fa0311 wants to merge 60 commits intoOpenAPITools:oshmoun-masterfrom
fa0311:oshmoun-master

fa0311 commented Sep 21, 2023 •

edited

Loading

Uh oh!

wing328 commented Sep 22, 2023

Uh oh!

fa0311 commented Sep 22, 2023

Uh oh!

wing328 commented Sep 22, 2023 •

edited

Loading

Uh oh!

fa0311 commented Sep 22, 2023 •

edited

Loading

Uh oh!

wing328 commented Sep 22, 2023

Uh oh!

multani commented Sep 23, 2023

Uh oh!

wing328 commented Sep 23, 2023

Uh oh!

fa0311 commented Sep 24, 2023

Uh oh!

wing328 commented Sep 24, 2023

Uh oh!

wing328 commented Sep 24, 2023

Uh oh!

fa0311 commented Sep 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Uh oh!

Conversation

fa0311 commented Sep 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Uh oh!

wing328 commented Sep 22, 2023

Uh oh!

fa0311 commented Sep 22, 2023

Uh oh!

wing328 commented Sep 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fa0311 commented Sep 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wing328 commented Sep 22, 2023

Uh oh!

multani commented Sep 23, 2023

Uh oh!

wing328 commented Sep 23, 2023

Uh oh!

fa0311 commented Sep 24, 2023

Uh oh!

wing328 commented Sep 24, 2023

Uh oh!

wing328 commented Sep 24, 2023

Uh oh!

fa0311 commented Sep 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

fa0311 commented Sep 21, 2023 •

edited

Loading

wing328 commented Sep 22, 2023 •

edited

Loading

fa0311 commented Sep 22, 2023 •

edited

Loading