Beta (1.12.0) by d-gubert · Pull Request #205 · RocketChat/Rocket.Chat.Apps-engine

d-gubert · 2020-01-13T21:31:46Z

What? ⛵

Changes:

Auto create user for app during installation
UIKit

* Update user type * Add interface IUserCreator * Implement UserCreator * Update enum UserType * Add new user type app * Remove app user when purged the app * Add new public method getAppUser * Make the App's user the default sender for messages sent by app * Adapt user bridge to new structure * Add a prefix to the App's user's username Co-authored-by: Upendra Reddy <upendrareddy2511@gmail.com> Co-authored-by: Douglas Gubert <d-gubert@users.noreply.github.com>

codecov · 2020-01-27T20:14:25Z

Codecov Report

Merging #205 into master will decrease coverage by 2.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   55.83%   53.81%   -2.03%     
==========================================
  Files          78       70       -8     
  Lines        2681     2568     -113     
  Branches      380      380              
==========================================
- Hits         1497     1382     -115     
- Misses       1184     1186       +2

Impacted Files	Coverage Δ
src/server/AppManager.ts	`14.28% <ø> (ø)`	⬆️
src/server/ProxiedApp.ts	`13.75% <0%> (-0.36%)`	⬇️
src/server/managers/AppListenerManager.ts	`4.56% <100%> (ø)`	⬆️
src/server/errors/index.ts
src/server/managers/index.ts
src/server/accessors/index.ts
src/server/marketplace/license/index.ts
src/server/compiler/index.ts
src/server/storage/index.ts
src/server/logging/index.ts
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc6be9f...d8cf4f6. Read the comment docs.

* revert IUser to be the same as master and add appId property * fix unit-tests

d-gubert · 2020-02-03T19:54:10Z

@d-gubert We named an app user with the name app.${ app.getInfo().nameSlug } in other places, here we need to add app. as prefix. What do you think of it?

@lolimay not sure I follow - what do you think we need to update?

* Introduce Blocks definition * Better definitions for blocks and builders * Add blockit handler * Actions block * Blockit response * Improve typings for builder * Detach BlockBuilder from MessageBuilder * Publish changes under @blockit-chat tag * Improve types * Implement view submit action * Make triggerId optional * View submit action handler * Add view close event * Change to receive whole user and message objects * Add Room and View definitions * Implement context element * Add available elements * Implement UI Interaction notifier * New APIs for UIKit * Add new block types to builder * Add the UIController component * Add triggerId to the slash command context * Enable slashcommands with triggerId * Introducing UIController and some renamings * Add StaticSelect and MultiStaticSelect element * Remove auto deploy for the blockit-chat tag * Fix `addBlocks` method on `MessageBuilder` * Add error return type Co-authored-by: Diego Sampaio <chinello@gmail.com>

…echatRead`

claassistantio · 2020-02-06T13:38:45Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

✅ lolimay
✅ d-gubert
❌ ggazzo
❌ sampaiodiego
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

* Updates to the UIKit API * Add type to static select

* Apps.engine.ui (#131) * Add interfaces IExternalComponent and IExternalComponentExtend * Add externalComponents property for IConfigurationExtend * export IExternalComponent * Add interface IExternalComponentLocationOptions * implement the interface IExternalComponentsExtend * export ExternalComponentsExtend * Add externalComponentManager for AppManager * implement AppExternalComponentManager * Implement IExternalComponentBridge * Add getExternalComponentBridge method for AppBridges * export AppExternalComponentManager * Update getConfigurationExtend method for AppAccessorManager * [TEST] Update appBridge and add externalComponentBridge * Update related test scripts * Remove IExternalComponentBridge interface * AppExternalComponentManager maintains the list of all registered components itself * Update test scripts * Add webhooks interface for the external component * Update the interface IExternalComponent * Add description field to the interface IExternalComponent * Apps.engine.ui.sdk (#132) * update IWebHooks interface * Add util randomString * add AppEmbeddedSDK * move constants to src/client/constants directory * separate initListener from call method * rename initListener to init * Bump alpha version * Change version checking function to allow pre-release tags * Add go-publish-alpha npm script * Bump alpha version * Add options for http requests * Add Livechat functionality * Add further integration with Livechat * Refactor minor inconsistency * Formatting improvement * Add createToken method to LivechatCreator * Add file property to message interface * Add types to compiler option to allow usage of Buffer type * Add livechat reader getter to read interface * Add Upload reader * Update visitor interface * 1.6.0-beta.0 * Validate the LIVE_CHAT rooms correctly * Update version for CI * Access livechat room’s deparment data (#142) * Revert "Change version checking function to allow pre-release tags" This reverts commit 0b88a18. * 1.7.0-alpha * Add missing unregister component method (#144) * chore: change comment style to obtain VS Code Intellisense * feat: add unregisterComponent method We made follwing changes for the AppExternalComponentManager: * add new private property - appTouchedComponents * add new public method unregisterComponent * add new public method getExternalComponent * Add unregisterComponent in the lifecycle methods We need to call unregisterComponent method to remove the corresponding external components from the providedComponents when following AppManager's methods are called: * `unload` is called * `disable` is called <-> Disable an app * `remove` is called <-> Uninstall an app * `updateAppsMarketplaceInfo` is called and validateLicense not pass * `initializeApp` is called and validateLicense not pass * `enableApp` is called but is not success * Add new AppExternalComponentManager method purgeComponent when remove an app from the system, we need delete its external component from both providedComponents map set and appTouchedCompoents map set. * fix: new deployed app registers externalComponents automatically since the new deployed app will try to register their externalComponent when the `initializeApp` method of AppManager is called. This is not expected behavior. We introduce a new parameter `addToProvidedComponents` for the method `registerComponent` to handle the above problem. Without specifying `registerComponent` to true, the app only "declares" it touched the external component when it is initialized. Only if the `enableApp` method is called, the external component will truly added to providedComponents map set, which means we can access it in the `Game Center`. * Add new location to the external components called MODAL (#137) * Add new location to external components * MODAL (new) * update enum ExternalComponentLocation * Update external component configration (#134) * update IWebHooks interface * Add util randomString * add AppEmbeddedSDK * move constants to src/client/constants directory * separate initListener from call method * rename initListener to init * add appId to IExternalComponent interface * Rename the client sdk to state what it is and improve the documentation * Add interfaces IUserInfo and IRoomInfo * Add documentation for the public methods * getUserInfo * getRoomInfo * Rename AppEmbeddedSDK to AppClientEmbeddedSDK * rename to make sure others can see that it's for client-side * add the class documentation for the AppClientEmbeddedSDK * Rename the AppClientEmbeddedSDK methods * Rename to make sure others can see it's for client-side * Add documentation for the IClientRoomInfo and IClientInfo interfaces * Rename external component pieces to be consistent in wording & logic * remove tests externalComponentBridge * remove the extra blank line * fix typos and add necessary blank lines * fix a grammar error in comments * Rename names to avoid confusions * rename IExternalComponentsExtend to IExternalComponentExtend * rename externalComponents to externalComponent * Add documentation to register external components method (#156) * Add documentation to register method * wording changes for IExternalComponentExtend * Merge from 'master' and bump to 1.8.0-beta * Bump to 1.8.0-alpha * Support multiple external components per app (#150) * Revert "Rename names to avoid confusions" This reverts commit d444646. * support multiple external components per app * Add error handlers for AppExternalComponentManager * Add unit tests for two new errors * ExternalComponentAlreadyTouchedError * ExternalComponentNotMatchWithAppError * Add getters for AppExternalComponentManager * Add unit tests for AppExternalComponentManager * did some changes to AppExternalComponentManager according to tests * fix a serious logic error * compare objects after serialization * add space before parenttheses * Modify documentation to state the name unique * Redesign getExternalComponents * Rename providedExternalComponents to registeredExternalComponents * Redesign getExternalComponents * Remove ExternalComponentAlreadyTouchedError * overwrite an external component with the same name * Remove ExternalComponentNotMatchWithAppError * Because of the caller of the method addExternalComponent is apps-engine. So we can trust the appId provided. * Always overwrite the externalComponent.appId to the appId via the method addExternalComponent * Add external components only if it is not empty * Add a new public method getProvidedComponents * Make sure the return is an array * Move external component host logic (#169) * [ALPHA] Move host logic into apps-engine repo * Rename EClientEmbeddedSDKActions * Remove the word `embedded` from client SDK files * Rename the client SDK to AppsEngineClient * Redesign external component webhooks (#168) * Remove IWebHooks * Remove IWebHooks * Remove webhooks options from IExternalComponentOptions and redesign it Introduce state for external components Add IPreExternalComponentOpenedPrevent handler Add IPostExternalComponentOpened handler * add accessors for IPreExternalComponentOpenedPrevent handler * Add IPostExternalComponentOpened handler Add IPostExternalComponentClosed handler Remove IPreExternalComponentOpenedPrevent * export modules * Update metadata AppMethod * Update AppImplements * Add methods to AppListenerManager * Remove IWebHooks * Remove IWebHooks * Remove webhooks options from IExternalComponentOptions and redesign it Introduce state for external components Add IPreExternalComponentOpenedPrevent handler Add IPostExternalComponentOpened handler * add accessors for IPreExternalComponentOpenedPrevent handler * Add IPostExternalComponentOpened handler Add IPostExternalComponentClosed handler Remove IPreExternalComponentOpenedPrevent * export modules * Update metadata AppMethod * Update AppImplements * Add methods to AppListenerManager * rebase onto move-host-logic * Remove check methods from event handlers * Rename a few interfaces * Rename a few interfaces * Renamings * Refactor * Remove unused files * Make AppsEngineUIClient use the MESSAGE_ID constant * Add the command `bundle` for bundling apps engine ui client (#182) * Add the command `bundle` for bundling SDK * Bundle sdk before publishing * Update circleci node version to the same as Rocket.Chat * Bump beta version * Bump version * Definition bump * Beta version * Add beta publishing script * 1.9.0 * 1.10.0-beta * 1.10.0-alpha * Bump beta version * Fix lint * Fix errors * Bump alpha version * Bump definition version * Bump version to 1.13.0-alpha * Beta (1.12.0) (#205) * UIKit (#184) * Auto create user for app during installation Co-authored-by: Shiqi Mei <shiqi.mei@lolimay.cn> Co-authored-by: Upendra Reddy <upendrareddy2511@gmail.com> Co-authored-by: Diego Sampaio <chinello@gmail.com> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> * 1.12.0 * 1.13.0-beta Co-authored-by: lolimay <lolimay@lolimay.cn> Co-authored-by: Rodrigo Nascimento <rodrigoknascimento@gmail.com> Co-authored-by: Shiqi Mei <shiqi.mei@rocket.chat> Co-authored-by: Shiqi Mei <shiqi.mei@lolimay.cn> Co-authored-by: Upendra Reddy <upendrareddy2511@gmail.com> Co-authored-by: Diego Sampaio <chinello@gmail.com> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>

CLAassistant · 2020-03-17T14:03:14Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ ggazzo
✅ d-gubert
✅ lolimay
❌ sampaiodiego
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

d-gubert and others added 3 commits January 9, 2020 16:02

Bump to beta version

51512a7

Ensure App has a user during update routine (#206)

2713ef1

Shiqi Mei and others added 2 commits January 31, 2020 17:07

[FIX] Revert breaking changes on IUser definition (#208)

00ed259

* revert IUser to be the same as master and add appId property * fix unit-tests

Merge remote-tracking branch 'origin/master' into beta

b678c18

d-gubert and others added 9 commits February 3, 2020 21:50

Fix input block definitions

2924e30

Introduce the isOnlineAsync method and deprecate isOnline on `Liv…

c042411

…echatRead`

Update src/server/accessors/LivechatRead.ts

8167768

Merge branch 'isOnlineAsync-livechat-method' into beta

d9fab36

Merge remote-tracking branch 'origin/master' into beta

cc6be9f

Merge remote-tracking branch 'origin/master' into beta

ef4ff13

Fix modal update

a7a0905

Fix modal update #216

29567ea

Shiqi Mei and others added 8 commits February 6, 2020 10:49

Add new API getAppUserUsername (#214)

8d8d51c

Add container definitions

036856d

Add container definition

287f202

Uikit updates (#221)

f35426e

* Updates to the UIKit API * Add type to static select

Add UIKit Incoming Interaction Container Type (#222)

02b3b10

Add overflow menu element (#223)

7a7fc3a

UIKit Modal response close and submit optional (#225)

087e1c3

Remove confirmation objects from uikit definitions

d8cf4f6

d-gubert marked this pull request as ready for review February 12, 2020 21:56

d-gubert merged commit 5bad9ca into master Feb 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Beta (1.12.0)#205

Beta (1.12.0)#205
d-gubert merged 22 commits intomasterfrom
beta

d-gubert commented Jan 13, 2020 •

edited

Loading

Uh oh!

codecov bot commented Jan 27, 2020 •

edited

Loading

Uh oh!

d-gubert commented Feb 3, 2020 •

edited

Loading

Uh oh!

claassistantio commented Feb 6, 2020

Uh oh!

CLAassistant commented Mar 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

Conversation

d-gubert commented Jan 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What? ⛵

Uh oh!

codecov bot commented Jan 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

d-gubert commented Feb 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claassistantio commented Feb 6, 2020

Uh oh!

CLAassistant commented Mar 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

d-gubert commented Jan 13, 2020 •

edited

Loading

codecov bot commented Jan 27, 2020 •

edited

Loading

d-gubert commented Feb 3, 2020 •

edited

Loading