ci: fix services container not building in build step#32075
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32075 +/- ##
===========================================
+ Coverage 54.75% 54.79% +0.03%
===========================================
Files 2303 2303
Lines 50832 50832
Branches 10413 10413
===========================================
+ Hits 27832 27852 +20
+ Misses 20488 20469 -19
+ Partials 2512 2511 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
|
sampaiodiego
force-pushed
the
ci-build-services-containers-first
branch
from
2876cd8 to
2057063
Compare
sampaiodiego
force-pushed
the
ci-build-services-containers-first
branch
from
41098ec to
6229adb
Compare
ggazzo
added
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
ggazzo
approved these changes
Apr 5, 2024
dionisio-bot
bot
removed
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Apr 9, 2024
Via GitHub (2) and Guilherme Gazzo (1) * develop: (40 commits) chore: Fix some check/lint warnings (#32048) Revert "fix!: api login should not suggest which credential is wrong" (#32156) test: Prevent playwright from unselecting options by mistake (#32158) chore(meteor/packages): apply code style (#32145) fix: New messages export overwrites previous one from the same day when using Amazon S3 (#32062) Release 6.7.0 chore: bump to 6.8.0 (#32153) chore: remove unused onStartup function (#32149) Release 6.7.0-rc.4 chore: remove collections when db watcher is disabled (#32150) chore: Bump Apps-Engine version (#32144) regression(fuselage-ui-kit): Use default translation namespace for `-core` apps (#32105) regression(fuselage-ui-kit): Use default translation namespace for `-core` apps (#32105) chore: move imported `Apps` to proxy (#32142) feat: allowing forward to offline dep (#31976) ci: fix services container not building in build step (#32075) feat: `Contextualbar` resizable (#29461) fix: Missing space between name and user name on system messages (#32136) fix: livechat room desync on different windows (#32135) fix: livechat room desync on different windows (#32135) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARCH-1282
because of a missing variable, we were building the images more than once
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments