regression(fuselage-ui-kit): Use default translation namespace for -core apps#32105
Merged
kodiakhq[bot] merged 6 commits intodevelopfrom Apr 8, 2024
Merged
regression(fuselage-ui-kit): Use default translation namespace for -core apps#32105kodiakhq[bot] merged 6 commits intodevelopfrom
-core apps#32105kodiakhq[bot] merged 6 commits intodevelopfrom
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32105 +/- ##
===========================================
- Coverage 54.81% 54.76% -0.06%
===========================================
Files 2303 2303
Lines 50833 50833
Branches 10413 10413
===========================================
- Hits 27864 27838 -26
- Misses 20459 20487 +28
+ Partials 2510 2508 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
previously approved these changes
Apr 1, 2024
tassoevan
force-pushed
the
fix/core-apps-translations
branch
from
93bfeaf to
a9b8c69
Compare
tassoevan
changed the title
-core apps-core apps
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
Contributor
|
Looks like this PR is ready to merge! 🎉 |
dionisio-bot
bot
added
stat: QA assured
MarcosSpessatto
suggested changes
Apr 3, 2024
Contributor
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Can a unit-test be added to cover this?
MarcosSpessatto
approved these changes
Apr 8, 2024
ggazzo
added
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
ggazzo
pushed a commit
that referenced
this pull request
Apr 8, 2024
gabriellsh
added a commit
that referenced
this pull request
Apr 9, 2024
Via GitHub (2) and Guilherme Gazzo (1) * develop: (40 commits) chore: Fix some check/lint warnings (#32048) Revert "fix!: api login should not suggest which credential is wrong" (#32156) test: Prevent playwright from unselecting options by mistake (#32158) chore(meteor/packages): apply code style (#32145) fix: New messages export overwrites previous one from the same day when using Amazon S3 (#32062) Release 6.7.0 chore: bump to 6.8.0 (#32153) chore: remove unused onStartup function (#32149) Release 6.7.0-rc.4 chore: remove collections when db watcher is disabled (#32150) chore: Bump Apps-Engine version (#32144) regression(fuselage-ui-kit): Use default translation namespace for `-core` apps (#32105) regression(fuselage-ui-kit): Use default translation namespace for `-core` apps (#32105) chore: move imported `Apps` to proxy (#32142) feat: allowing forward to offline dep (#31976) ci: fix services container not building in build step (#32075) feat: `Contextualbar` resizable (#29461) fix: Missing space between name and user name on system messages (#32136) fix: livechat room desync on different windows (#32135) fix: livechat room desync on different windows (#32135) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Core apps differ from regular apps by the ID suffix
-core. Before this change, it'd be assumed that any app might have a translation namespace available, namedapp-<app ID>. This is simple not true for core apps, as they use default namespaces (e.g.core) only. The absence of a core app translation namespace would cause UIKit blocks to be suspended ("blink") while a request to server for translations on the expected namespace is going on.Issue(s)
CORE-227
Steps to test or reproduce
Further comments