Skip to content

fix: Missing space between name and user name on system messages#32136

Merged
kodiakhq[bot] merged 4 commits intodevelopfrom
fix/systemMessageSpace
Apr 5, 2024
Merged

fix: Missing space between name and user name on system messages#32136
kodiakhq[bot] merged 4 commits intodevelopfrom
fix/systemMessageSpace

Conversation

@dougfabris
Copy link
Copy Markdown
Member

@dougfabris dougfabris commented Apr 4, 2024

Proposed changes (including videos or screenshots)

before

Screenshot 2024-04-04 at 16 45 54

after

Screenshot 2024-04-04 at 16 43 32

Issue(s)

Steps to test or reproduce

Further comments

CORE-281

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 4, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 4, 2024

🦋 Changeset detected

Latest commit: f2c1954

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris added this to the 7.0 milestone Apr 4, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.80%. Comparing base (ec544d6) to head (f2c1954).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32136      +/-   ##
===========================================
- Coverage    54.83%   54.80%   -0.04%     
===========================================
  Files         2302     2298       -4     
  Lines        50828    50779      -49     
  Branches     10413    10406       -7     
===========================================
- Hits         27874    27827      -47     
- Misses       20443    20444       +1     
+ Partials      2511     2508       -3     
Flag Coverage Δ
e2e 53.74% <0.00%> (-0.08%) ⬇️
e2e-api 40.11% <ø> (ø)
unit 75.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review April 4, 2024 20:29
@dougfabris dougfabris requested a review from a team as a code owner April 4, 2024 20:29
@gabriellsh gabriellsh modified the milestones: 7.0, 6.8 Apr 4, 2024
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Apr 4, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 4, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 4, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 5, 2024
@kodiakhq kodiakhq bot merged commit e5bbf83 into develop Apr 5, 2024
@kodiakhq kodiakhq bot deleted the fix/systemMessageSpace branch April 5, 2024 13:51
gabriellsh added a commit that referenced this pull request Apr 9, 2024
 Via GitHub (2) and Guilherme Gazzo (1)
* develop: (40 commits)
  chore: Fix some check/lint warnings (#32048)
  Revert "fix!: api login should not suggest which credential is wrong" (#32156)
  test: Prevent playwright from unselecting options by mistake (#32158)
  chore(meteor/packages): apply code style (#32145)
  fix: New messages export overwrites previous one from the same day when using Amazon S3 (#32062)
  Release 6.7.0
  chore: bump to 6.8.0 (#32153)
  chore: remove unused onStartup function (#32149)
  Release 6.7.0-rc.4
  chore: remove collections when db watcher is disabled (#32150)
  chore: Bump Apps-Engine version (#32144)
  regression(fuselage-ui-kit): Use default translation namespace for `-core` apps (#32105)
  regression(fuselage-ui-kit): Use default translation namespace for `-core` apps (#32105)
  chore: move imported `Apps` to proxy (#32142)
  feat: allowing forward to offline dep (#31976)
  ci: fix services container not building in build step (#32075)
  feat: `Contextualbar` resizable (#29461)
  fix: Missing space between name and user name on system messages (#32136)
  fix: livechat room desync on different windows (#32135)
  fix: livechat room desync on different windows (#32135)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants