fix: sidebar last message E2EE#32431
Merged
kodiakhq[bot] merged 10 commits intodevelopfrom Jun 17, 2024
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: c595592 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32431 +/- ##
===========================================
+ Coverage 56.46% 56.54% +0.08%
===========================================
Files 2455 2455
Lines 54100 54098 -2
Branches 11149 11148 -1
===========================================
+ Hits 30546 30590 +44
+ Misses 20899 20847 -52
- Partials 2655 2661 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
milton-rucks
added
stat: QA assured
yash-rajpal
approved these changes
Jun 12, 2024
tassoevan
approved these changes
Jun 14, 2024
hugocostadev
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jun 18, 2024
…retention * 'develop' of github.com:RocketChat/Rocket.Chat: fix: Not possible to edit room without proper permission with retention policy enabled (#32547) feat: Apps-Engine Deno Runtime update (#31821) feat: E2EE room setup header (#32446) fix: E2EE thread main message reactivity (#32381) chore: Add telemetry to CI so we can get a better understanding of resource usage (#32113) fix: Long katex strings breaking overflow in x axis (#32609) fix: Force highlighted code language registration (#32507) fix: sidebar last message E2EE (#32431) chore: remove message column on moderation console (#32432) fix: Accepted Media Types settings validation (#32478)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
If End-to-End Encryption is enabled and you delete the last message in a room the is updated to the last message without a type (t) attribute set which will be last message before the encryption was enabled for this room or no message if no unencrypted message is available.
If you send an encrypted message the lastMessage is updated correctly but on deletion the method Rooms.resetLastMessageById is called which will get the last message by calling Messages.getLastVisibleMessageSentWithNoTypeByRoomId. But an e2e message has the t set to "e2e" and will be ignored.
I did:
Messages.getLastVisibleMessageSentWithNoTypeByRoomIdfunction toMessages.getLastVisibleUserMessageSentByRoomIdIssue(s)
Steps to test or reproduce
Expected behavior:
The last message is shown nevermind if its an encrypted or unencrypted message
Further comments
https://rocketchat.atlassian.net/browse/E2EE2-12