fix: Accepted Media Types settings validation#32478
Merged
kodiakhq[bot] merged 8 commits intodevelopfrom Jun 14, 2024
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: b7e8cd5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32478 +/- ##
===========================================
+ Coverage 56.43% 56.50% +0.07%
===========================================
Files 2455 2455
Lines 54098 54100 +2
Branches 11149 11149
===========================================
+ Hits 30529 30570 +41
+ Misses 20909 20878 -31
+ Partials 2660 2652 -8
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
previously requested changes
May 23, 2024
Member
KevLehman
left a comment
KevLehman
left a comment
There was a problem hiding this comment.
This one should have API tests
Contributor
Author
I created tests for the function that I changed and that's being used in frontend and backend. |
rique223
previously approved these changes
Jun 11, 2024
matheusbsilva137
previously requested changes
Jun 12, 2024
tassoevan
approved these changes
Jun 13, 2024
rique223
approved these changes
Jun 13, 2024
hugocostadev
dismissed stale reviews from KevLehman and matheusbsilva137
out of scope
hugocostadev
added
the
stat: QA assured
matheusbsilva137
approved these changes
Jun 13, 2024
dionisio-bot
bot
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jun 18, 2024
…retention * 'develop' of github.com:RocketChat/Rocket.Chat: fix: Not possible to edit room without proper permission with retention policy enabled (#32547) feat: Apps-Engine Deno Runtime update (#31821) feat: E2EE room setup header (#32446) fix: E2EE thread main message reactivity (#32381) chore: Add telemetry to CI so we can get a better understanding of resource usage (#32113) fix: Long katex strings breaking overflow in x axis (#32609) fix: Force highlighted code language registration (#32507) fix: sidebar last message E2EE (#32431) chore: remove message column on moderation console (#32432) fix: Accepted Media Types settings validation (#32478)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The setting
Accepted Media Typesin the File Upload menu was not working as expected since an Empty setting or wildcard*value should allow all types of files if they are not in theBlockedsettingsIssue(s)
fix #31906
fix #31692
Steps to test or reproduce
*or leave it emptyFurther comments
https://rocketchat.atlassian.net/browse/CONN-214