fix: Force highlighted code language registration#32507
Merged
kodiakhq[bot] merged 9 commits intodevelopfrom Jun 17, 2024
Merged
fix: Force highlighted code language registration#32507kodiakhq[bot] merged 9 commits intodevelopfrom
kodiakhq[bot] merged 9 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: 10a2c32 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32507 +/- ##
===========================================
- Coverage 56.57% 56.39% -0.19%
===========================================
Files 2455 2477 +22
Lines 54098 54555 +457
Branches 11148 11265 +117
===========================================
+ Hits 30606 30766 +160
- Misses 20833 21113 +280
- Partials 2659 2676 +17
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
suggested changes
May 30, 2024
Contributor
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Can we add a PR description?
MarcosSpessatto
previously approved these changes
Jun 3, 2024
MarcosSpessatto
previously approved these changes
Jun 3, 2024
scuciatto
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
dougfabris
dismissed stale reviews from yash-rajpal and MarcosSpessatto
via
ff3f026
MarcosSpessatto
approved these changes
Jun 17, 2024
yash-rajpal
approved these changes
Jun 17, 2024
yash-rajpal
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jun 18, 2024
…retention * 'develop' of github.com:RocketChat/Rocket.Chat: fix: Not possible to edit room without proper permission with retention policy enabled (#32547) feat: Apps-Engine Deno Runtime update (#31821) feat: E2EE room setup header (#32446) fix: E2EE thread main message reactivity (#32381) chore: Add telemetry to CI so we can get a better understanding of resource usage (#32113) fix: Long katex strings breaking overflow in x axis (#32609) fix: Force highlighted code language registration (#32507) fix: sidebar last message E2EE (#32431) chore: remove message column on moderation console (#32432) fix: Accepted Media Types settings validation (#32478)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
When a certain code language isn't on the
Message_Code_highlightsetting it wasn't registering it before trying to use on the client side. So the fix forces the registration right before being used preventing the ui from crashing.Issue(s)
Steps to test or reproduce
Further comments
CORE-468