Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 049a683 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33283 +/- ##
===========================================
- Coverage 58.42% 58.42% -0.01%
===========================================
Files 2744 2744
Lines 66249 66242 -7
Branches 14991 14987 -4
===========================================
- Hits 38708 38703 -5
+ Misses 24720 24719 -1
+ Partials 2821 2820 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
aleksandernsilva
previously approved these changes
Sep 26, 2024
tassoevan
requested changes
Sep 26, 2024
tassoevan
previously approved these changes
Sep 27, 2024
ggazzo
reviewed
Sep 27, 2024
apps/meteor/client/views/room/composer/messageBox/MessageBoxHint.tsx
Outdated
Show resolved
Hide resolved
ggazzo
requested changes
Sep 27, 2024
Member
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
can you check my review? if you believe that doesnt make sense, please, just dismiss
packages/ui-composer/src/MessageComposer/MessageComposerHint.stories.tsx
Show resolved
Hide resolved
hugocostadev
force-pushed
the
feat/e2ee-composer-hint
branch
from
2deadf2 to
658628a
Compare
ggazzo
previously approved these changes
Sep 27, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
stat: ready to merge
tassoevan
previously approved these changes
Oct 8, 2024
ggazzo
dismissed stale reviews from tassoevan and themself
The merge-base changed after approval.
ggazzo
force-pushed
the
feat/e2ee-composer-hint
branch
from
f01f943 to
a5b2299
Compare
ggazzo
approved these changes
Oct 12, 2024
gabriellsh
added a commit
that referenced
this pull request
Oct 15, 2024
…ctor/avatar * 'develop' of github.com:RocketChat/Rocket.Chat: (58 commits) refactor: unified users page header content into a single component (#33498) chore: store contact emails and phones on the same format as user's and visitor's (#33484) fix: broken jump-to-thread-message functionality using link (#33332) feat: Apps-Engine method for reading and counting unread room messages for a user (#32194) feat: adds a new featured room action on the header for non-default category (#33562) chore(deps): bump actions/setup-node from 4.0.3 to 4.0.4 (#33327) fix: consider query strings in Twilio request validation (#33364) ci: add restore cache for `deploy-preview` (#33579) feat: add history endpoint (#33349) ci: cache artifacts to reduce api calls (#33567) feat: new E2EE composer hint (#33283) chore: Add `force` option to `rmSync` call (#33570) chore: remove nameInsensitive sorting on /v1/users.listByStatus (#33401) chore: Use `rmSync` instead of `rmdirSync` (#33551) feat: add contact channels (#33308) chore: split ImportDataConverter into multiple classes and add unit testing (#33394) test: added MockedDeviceContext to voip unit tests (#33553) refactor: adjusted voip endpoints error messages (#33515) fix: Cannot send messages after E2EE keys are refreshed (#33527) fix: Custom sounds not working when storage is set to filesystem (#33424) ...
This was referenced Oct 20, 2024
Closed
Closed
Merged
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Problem statement
When the setting
Unencrypted messagesin encrypted rooms is turned off, there is a warning in the UI for the cases the user has inserted their E2EE password but doesn’t have the E2EE room key. However, when the setting is ON, there is no indicator in the UI making it clear they don’t have the room key.As a result, the user may send unencrypted messages in an encrypted room believing it is E2EE encrypted, or may believe a bug prevents the messages from being encrypted.
Solution
Create a composer hint to make users aware they don’t have the room key.
Issue(s)
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/E2EE2-63