Merged
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Contributor
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33308 +/- ##
===========================================
- Coverage 58.44% 58.42% -0.02%
===========================================
Files 2744 2744
Lines 66235 66249 +14
Branches 14987 14991 +4
===========================================
Hits 38708 38708
- Misses 24706 24720 +14
Partials 2821 2821
Flags with carried forward coverage won't be shown. Click here to find out more. |
pierre-lehnen-rc
requested changes
Sep 30, 2024
pierre-lehnen-rc
requested changes
Oct 1, 2024
KevLehman
requested changes
Oct 1, 2024
MarcosSpessatto
suggested changes
Oct 9, 2024
tapiarafael
requested review from
KevLehman,
MarcosSpessatto and
pierre-lehnen-rc
MarcosSpessatto
previously approved these changes
Oct 9, 2024
pierre-lehnen-rc
previously requested changes
Oct 9, 2024
KevLehman
requested changes
Oct 10, 2024
added 2 commits
October 11, 2024 14:14
MarcosSpessatto
approved these changes
Oct 11, 2024
KevLehman
approved these changes
Oct 11, 2024
Member
KevLehman
left a comment
KevLehman
left a comment
There was a problem hiding this comment.
No more complains than the usual complains
tapiarafael
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Oct 15, 2024
…ctor/avatar * 'develop' of github.com:RocketChat/Rocket.Chat: (58 commits) refactor: unified users page header content into a single component (#33498) chore: store contact emails and phones on the same format as user's and visitor's (#33484) fix: broken jump-to-thread-message functionality using link (#33332) feat: Apps-Engine method for reading and counting unread room messages for a user (#32194) feat: adds a new featured room action on the header for non-default category (#33562) chore(deps): bump actions/setup-node from 4.0.3 to 4.0.4 (#33327) fix: consider query strings in Twilio request validation (#33364) ci: add restore cache for `deploy-preview` (#33579) feat: add history endpoint (#33349) ci: cache artifacts to reduce api calls (#33567) feat: new E2EE composer hint (#33283) chore: Add `force` option to `rmSync` call (#33570) chore: remove nameInsensitive sorting on /v1/users.listByStatus (#33401) chore: Use `rmSync` instead of `rmdirSync` (#33551) feat: add contact channels (#33308) chore: split ImportDataConverter into multiple classes and add unit testing (#33394) test: added MockedDeviceContext to voip unit tests (#33553) refactor: adjusted voip endpoints error messages (#33515) fix: Cannot send messages after E2EE keys are refreshed (#33527) fix: Custom sounds not working when storage is set to filesystem (#33424) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Ensure that when a new room is created, it creates a channel for the existing contact if there's none with the same
visitorIdand room type.Also, include the destination for better visualization of the channel. (e.g whatsapp number, SMS number, widget host)
Issue(s)
Steps to test or reproduce
Further comments
SCI-74