fix: Cannot send messages after E2EE keys are refreshed#33527
Merged
kodiakhq[bot] merged 9 commits intodevelopfrom Oct 11, 2024
Merged
fix: Cannot send messages after E2EE keys are refreshed#33527kodiakhq[bot] merged 9 commits intodevelopfrom
kodiakhq[bot] merged 9 commits intodevelopfrom
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 8776506 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33527 +/- ##
========================================
Coverage 58.59% 58.59%
========================================
Files 2739 2739
Lines 65696 65696
Branches 14826 14826
========================================
Hits 38496 38496
Misses 24420 24420
Partials 2780 2780
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
requested changes
Oct 10, 2024
apps/meteor/client/views/room/providers/hooks/useChatMessagesInstance.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/providers/hooks/useInstance.spec.ts
Outdated
Show resolved
Hide resolved
KevLehman
approved these changes
Oct 11, 2024
Member
KevLehman
left a comment
KevLehman
left a comment
There was a problem hiding this comment.
symbolic approve since i want the fix :)
gabriellsh
changed the title
gabriellsh
approved these changes
Oct 11, 2024
hugocostadev
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
hugocostadev
removed
the
stat: QA assured
dionisio-bot
bot
removed
the
stat: ready to merge
hugocostadev
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Oct 15, 2024
…ctor/avatar * 'develop' of github.com:RocketChat/Rocket.Chat: (58 commits) refactor: unified users page header content into a single component (#33498) chore: store contact emails and phones on the same format as user's and visitor's (#33484) fix: broken jump-to-thread-message functionality using link (#33332) feat: Apps-Engine method for reading and counting unread room messages for a user (#32194) feat: adds a new featured room action on the header for non-default category (#33562) chore(deps): bump actions/setup-node from 4.0.3 to 4.0.4 (#33327) fix: consider query strings in Twilio request validation (#33364) ci: add restore cache for `deploy-preview` (#33579) feat: add history endpoint (#33349) ci: cache artifacts to reduce api calls (#33567) feat: new E2EE composer hint (#33283) chore: Add `force` option to `rmSync` call (#33570) chore: remove nameInsensitive sorting on /v1/users.listByStatus (#33401) chore: Use `rmSync` instead of `rmdirSync` (#33551) feat: add contact channels (#33308) chore: split ImportDataConverter into multiple classes and add unit testing (#33394) test: added MockedDeviceContext to voip unit tests (#33553) refactor: adjusted voip endpoints error messages (#33515) fix: Cannot send messages after E2EE keys are refreshed (#33527) fix: Custom sounds not working when storage is set to filesystem (#33424) ...
This was referenced Oct 20, 2024
Closed
Closed
Merged
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
ggazzo
pushed a commit
that referenced
this pull request
Nov 6, 2024
ggazzo
pushed a commit
that referenced
this pull request
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
After the PR #31589 the composer stopped updating in every state change, and because of that caused this issue with E2EE.
When the user waits for the room key to be distributed by other online users, after the distribution the room appears with the composer but the user is unable to send any message.
When the
RoomBodyappears the composer reference is updated but the used instance is using the old reference causing issues with the composer.Issue(s)
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/E2EE2-81