Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33349 +/- ##
===========================================
- Coverage 58.42% 58.41% -0.02%
===========================================
Files 2744 2744
Lines 66242 66255 +13
Branches 14987 14990 +3
===========================================
Hits 38703 38703
- Misses 24719 24732 +13
Partials 2820 2820
Flags with carried forward coverage won't be shown. Click here to find out more. |
7aff8b9 to
7c00139
Compare
7c00139 to
a720ecd
Compare
MarcosSpessatto
left a comment
There was a problem hiding this comment.
We need a changeset here. Or will this be added only when the whole feature is available?
We'll add it when the whole feature is available |
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Forgot to ask before 😞, can we write some tests for the endpoint?
…ctor/avatar * 'develop' of github.com:RocketChat/Rocket.Chat: (58 commits) refactor: unified users page header content into a single component (#33498) chore: store contact emails and phones on the same format as user's and visitor's (#33484) fix: broken jump-to-thread-message functionality using link (#33332) feat: Apps-Engine method for reading and counting unread room messages for a user (#32194) feat: adds a new featured room action on the header for non-default category (#33562) chore(deps): bump actions/setup-node from 4.0.3 to 4.0.4 (#33327) fix: consider query strings in Twilio request validation (#33364) ci: add restore cache for `deploy-preview` (#33579) feat: add history endpoint (#33349) ci: cache artifacts to reduce api calls (#33567) feat: new E2EE composer hint (#33283) chore: Add `force` option to `rmSync` call (#33570) chore: remove nameInsensitive sorting on /v1/users.listByStatus (#33401) chore: Use `rmSync` instead of `rmdirSync` (#33551) feat: add contact channels (#33308) chore: split ImportDataConverter into multiple classes and add unit testing (#33394) test: added MockedDeviceContext to voip unit tests (#33553) refactor: adjusted voip endpoints error messages (#33515) fix: Cannot send messages after E2EE keys are refreshed (#33527) fix: Custom sounds not working when storage is set to filesystem (#33424) ...
Proposed changes (including videos or screenshots)
Include a new endpoint to list the chat history of a contact. It does basically the same query as the current visitor history but for multiple visitors.
[GET]
api/v1/omnichannel/contacts.history?contactId=[id]response example
{ "history": [ { "_id": "E7DxYy9HNX4xPqhyy", "v": { "_id": "66df0ccb6f2de823455bca97", "username": "guest-52", "token": "8e5ae65364b2190c228a49368896677674d77ffa7fb00014189d37d30b553c31", "status": "offline", "activity": [ "2024-09" ], "lastMessageTs": "2024-09-09T14:57:36.144Z" }, "fname": "guest-52", "source": { "type": "widget" }, "ts": "2024-09-09T14:57:31.164Z", "msgs": 8, "servedBy": { "_id": "jnuReT9zctgoNKz7t", "username": "johndoe", "ts": "2024-09-09T14:57:31.195Z" }, "closedAt": "2024-09-09T14:57:40.250Z", "closedBy": { "_id": "66df0ccb6f2de823455bca97", "username": "guest-52" }, "closer": "visitor" }, ], "count": 25, "offset": 0, "total": 1, "success": true }Issue(s)
Steps to test or reproduce
Further comments
SCI-82