merge release/2025.4.1 into release/2026.1.0#1605
Merged
Merged
Conversation
* [MS-1341] Adding on tap focus for the OCR scanner * [MS-1341] Removing 'camera' field and verifying lifecycle state before using binding (cherry picked from commit 9c1e017)
* Cherry picking latest linter rulesˆ from the main branch * [MS-1338] Removing checkbox from the credential confirmation (cherry picked from commit 376ca5d)
* [MS-1339] Adding 'Has number, no card (booklet)' skip reason for MFID * [MS-1339] Adding `HAS_NUMBER_NO_ID` credential skip reason (cherry picked from commit cefefb6)
* Cherry picking latest linter rulesˆ from the main branch * [MS-1340] Adding validation for the credential fields edit text * [MS-1340] Updating tests * [MS-1340] Removing existing text watch when rendering updated state * [MS-1340] Fixing code comments * [MS-1340] Confirmation checkbox is disabled if credential is being edited * [MS-1340] Renaming credential validation use cases for better readability (cherry picked from commit 295763e)
…ntial data (#1591) * [MS-1346] Identificaiton response now contains scanned external credential data * [MS-1346] Renaming variables to be more consistent * [MS-1346] Fixing tests * [MS-1346] Fixing tests, removing unnecessary variables * [MS-1346] Fixing tests * [MS-1346] Fixing tests * [MS-1346] Adding test coverage for credential response in Identification response (cherry picked from commit b12990e)
meladRaouf
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
luhmirin-s and
ybourgery
and removed request for
a team
|
luhmirin-s
approved these changes
Mar 4, 2026
Contributor
luhmirin-s
left a comment
luhmirin-s
left a comment
There was a problem hiding this comment.
Looks correct, but I would wait for Alex's review to be sure.
alexandr-simprints
approved these changes
Mar 11, 2026
Contributor
alexandr-simprints
left a comment
alexandr-simprints
left a comment
There was a problem hiding this comment.
Changes look about right off top of my head. Regression testing is definitely required, but the code structure seems safe overall
alexandr-simprints
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.