Reform proposal to add CrowdLevel#3
Reform proposal to add CrowdLevel#3sccmcca wants to merge 29 commits intoTransitApp:occupancy_v2from sccmcca:crowd-level
Conversation
Fields in pathways.txt and attributions.txt also may be translated.
…bles The following standard fields in those tables can be translated: * pathways.txt - signposted_as, reversed_signposted_as * levels.txt - level_name * attributions.txt - organization_name, attribution_url, attribution_phone Previously, the documentation placed them in a list of tables whose standard fields should not be translated.
Updated GTFS revision history for transit/gtfs/CHANGES.md as of May 21, 2020.
* Support DUPLICATED trips in GTFS-RT * Revert deprecation of ADDED * Remove auto-format change * Better explanation of "forbidden" * Add experimental labels for message/fields * Add experimental labels for field * Add experimental label for message * Clarify DUPLICATED use with VehiclePosition * Clarify that true frequency-based trips can't be duplicated * Explicitly define how the duplicated trip schedule and RT values are calculated * docs: Add migration guide for transition from ADDED to DUPLICATED trips * docs: Normalize comments in code * docs: Allow trip.trip_id->trip_properties.trip_id link in migration guide
This is an editorial follow-up to google#221 to fix two items: * New messages should have the extensions fields to allow 3rd party and internal extensions - this commit adds these fields * An erroneous comment was added that labeled schedule_relationship as experimental - this commit removes it
headway_secs=0 does not have a physical meaning. This must be the time between departures for the same stop for a single trip.
Define positive and non-null number field types They are already used in the table descriptions. Co-authored-by: scmcca <scott@mobilitydata.org>
* Clarification of stop_times.stop_id - It explicitly tells that the referenced locations must be stops/platforms and have a `stops.location_type` value of `0` or empty. - Future-proof phrasing: it references only what must be done.
barbeau
left a comment
barbeau
left a comment
There was a problem hiding this comment.
Thanks @scmcca for putting this together. It looks pretty good to me. Some comments/thoughts in-line.
gtfs-realtime/spec/en/reference.md
Outdated
|
|
||
| ## _enum_ CrowdLevel | ||
|
|
||
| The passenger crowd level for the vehicle or carriage. CrowdLevel enum values must be interpreted on an ordinal scale in increasing order from _**NOT_CROWDED**_ to _**CROWDED**_. |
There was a problem hiding this comment.
I would add another sentence saying "In other words, producers must represent the minimum crowdedness level with NOT_CROWDED and the maximum crowdedness level with CROWDED."
There are going to be questions as to when CrowdLevel should be used and when OccupancyStatus should be used. I'd be inclined to provide an explicit example to make sure there is no confusion.
There was a problem hiding this comment.
Also, should producers take operational considerations like social distancing into account when publishing CrowdLevel? There is a line in occupancy_percentage definition about this - I'd suggest a similar mention here.
There was a problem hiding this comment.
As a producer, we prefer not to change the crowd level that we publish according to social distancing rules. We prefer to "tell it as it is" and let the client decide wether he is confortable or not with crowding in the vehicle. (since some clients are more nervous than others)
There was a problem hiding this comment.
Please see my latest commit where I added the sentence "or as otherwise defined by current operating regulations". If not otherwise defined, I think there won't be any introduced ambiguity. Thoughts?
- Reverted .proto field value assignments change - Clarified ordinal usage of CrowdLevel - Clarified CrowdLevel as subject to current allowed operating regulations (i.e., social distancing) - Examples for simultaneous use of OccupancyStatus and CrowdLevel - Corrected type
|
👍 on the actual field and description. 🤷 Adding this on top of the two existing fields seems overkill, but I understand this is probably the solution that will get accepted vs replacement. 👎 The ordering of the field changed. That makes the .proto not backward compatible. |
|
@gcamp Thank you for the review! I agree this proposal seems like overkill right now, but it's possible that it replaces the other experimental occupancy descriptions in the future. It looks like CrowdLevel should have been at value 11 under VehiclePosition, after occupancy_percentage that has value 10. I'll commit the fix! |
Move to backward-compatible value
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been closed due to inactivity. Pull requests can always be reopened after they have been closed. See the Specification Amendment Process. |
8 participants
Add a separate enum for CrowdLevel that does not conflict with OccupancyStatus.