Skip to content

Conversation

@CurtHagenlocher
Copy link
Contributor

@CurtHagenlocher CurtHagenlocher commented May 20, 2023

Rationale for this change

The FlatBuffers definitions in the C# code don't seem to have been updated for a while. Adding the latest FlatBuffers code ensures that we're up to date with both the Arrow definitions and the FlatBuffers compiler.

What changes are included in this PR?

The latest version of the C# FlatBuffers runtime files were copied into the project (with visibility changed from public to internal).
The latest version of the FlatBuffers compiler was used against the latest version of the Arrow .fbs source. The output of the compiler was edited to more closely match the existing code by moving it into the directory structure and namespaces of the existing classes and by changing class visibility from public to internal.
A few small changes were made to the existing source to accommodate changes in the FlatBuffers runtime, most specifically that the files have moved from the namespace "FlatBuffers" to the namespace "Google.FlatBuffers".

Are these changes tested?

No substantive product changes were made. All tests still pass.

Are there any user-facing changes?

No.

Resolves #35698

@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #35698 has been automatically assigned in GitHub to PR creator.

@westonpace
Copy link
Member

@CurtHagenlocher is there still value in this PR (I'm not aware of any reason there isn't but it's been a few minutes and I just wanted to double-check before spending any significant time reviewing).

@CurtHagenlocher
Copy link
Contributor Author

@westonpace Yes, this is still worthwhile. At some point we'll want to implement whatever the final "alternate string view" design is, and being up-to-date on fbs-derived stuff will make that an easier to follow change.

Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now, this is just updating some vendored/generated code and there isn't much of a content update (looks like a namespace change). I agree this is a good idea. Thanks for putting this together.

@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 0e677d2.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.

@CurtHagenlocher CurtHagenlocher deleted the FlatBufferUpdate branch August 21, 2023 18:54
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
### Rationale for this change

The FlatBuffers definitions in the C# code don't seem to have been updated for a while. Adding the latest FlatBuffers code ensures that we're up to date with both the Arrow definitions and the FlatBuffers compiler.

### What changes are included in this PR?

The latest version of the C# FlatBuffers runtime files were copied into the project (with visibility changed from public to internal).
The latest version of the FlatBuffers compiler was used against the latest version of the Arrow .fbs source. The output of the compiler was edited to more closely match the existing code by moving it into the directory structure and namespaces of the existing classes and by changing class visibility from public to internal.
A few small changes were made to the existing source to accommodate changes in the FlatBuffers runtime, most specifically that the files have moved from the namespace "FlatBuffers" to the namespace "Google.FlatBuffers".

### Are these changes tested?

No substantive product changes were made. All tests still pass.

### Are there any user-facing changes?

No.

Resolves apache#35698 
* Closes: apache#35698

Authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C#] Update Flatbuffers definitions in the C# code

2 participants