Skip to content

[Feature]Support external table sample stats collection. #24376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Sep 19, 2023
Merged

[Feature]Support external table sample stats collection. #24376

morningman merged 1 commit into from
Sep 19, 2023

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Sep 14, 2023 •
edited
Loading

Support hive table sample stats collection. Gramma is like

analyze table with sample percent 10

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Jibing-Li Jibing-Li force-pushed the sample branch 5 times, most recently from a12ce95 to 57c115d Compare September 14, 2023 15:41
@Jibing-Li Jibing-Li marked this pull request as ready for review September 14, 2023 15:42
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Sep 14, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Sep 14, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.07 seconds
stream load tsv: 597 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162232152 Bytes

morningman
morningman previously approved these changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2023

PR approved by anyone and no changes requested.

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Sep 18, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 18, 2023
@doris-robot
Copy link

doris-robot commented Sep 18, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.57 seconds
stream load tsv: 594 seconds loaded 74807831229 Bytes, about 120 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162524146 Bytes

morningman
morningman approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit 80bcb43 into apache:master Sep 19, 2023
@Jibing-Li Jibing-Li deleted the sample branch September 19, 2023 05:36
JingDas pushed a commit to JingDas/doris that referenced this pull request Sep 20, 2023
@Jibing-Li
[Feature]Support external table sample stats collection (apache#24376)
decff44 
Support hive table sample stats collection. Gramma is like

`analyze table with sample percent 10`
BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Sep 20, 2023
@BiteTheDDDDt
Revert "[Feature]Support external table sample stats collection (apac…
130d94c 
…he#24376)"

This reverts commit 80bcb43.
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Oct 13, 2023
@Jibing-Li
[Feature]Support external table sample stats collection (apache#24376)
262f651 
Support hive table sample stats collection. Gramma is like

`analyze table with sample percent 10`
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Oct 16, 2023
@Jibing-Li
[refactor](statistics) Merge external stats related pr to branch2.0
1680739 
apache#23170
apache#23574
apache#23751
apache#24414
apache#24154
apache#24376
apache#24696
apache#24540
apache#24891
apache#25175
@Jibing-Li Jibing-Li mentioned this pull request Oct 16, 2023
Merged
morningman pushed a commit that referenced this pull request Oct 16, 2023
@Jibing-Li
[branch2.0](backport)(statistics) Merge external stats related pr to …
23d7b4d 
…branch2.0 (#25462)

#23170
#23574
#23751
#24414
#24154
#24376
#24696
#24540
#24891
#25175
@xiaokang xiaokang mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

+1 more reviewer

@Kikyou1997 Kikyou1997 Kikyou1997 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jibing-Li @doris-robot @morningman @Kikyou1997