Skip to content

[Improvement](statistics) Improve sample count accuracy. #25175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Oct 12, 2023
Merged

[Improvement](statistics) Improve sample count accuracy. #25175

morningman merged 1 commit into from
Oct 12, 2023

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Oct 9, 2023 •
edited
Loading

While doing sample analyze, the result of row count, null number and datasize need to multiply a coefficient based on the sample percent/rows. This pr is mainly to calculate the coefficient according to the sampled file size over total size.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Jibing-Li Jibing-Li force-pushed the sample branch 6 times, most recently from 77f7de7 to 3a0d336 Compare October 9, 2023 12:20
@Jibing-Li Jibing-Li marked this pull request as ready for review October 10, 2023 01:59
@Jibing-Li Jibing-Li force-pushed the sample branch 5 times, most recently from 25fe617 to 4656dd9 Compare October 10, 2023 06:10
morningman
morningman reviewed Oct 10, 2023
View reviewed changes
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Oct 10, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Oct 10, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.59 seconds
stream load tsv: 579 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162404506 Bytes

@Jibing-Li Jibing-Li force-pushed the sample branch 3 times, most recently from bd6a208 to ad75f41 Compare October 11, 2023 03:39
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Oct 11, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Oct 11, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.11 seconds
stream load tsv: 563 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162290863 Bytes

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Oct 11, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Oct 11, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.82 seconds
stream load tsv: 560 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162288363 Bytes

morningman
morningman approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

PR approved by anyone and no changes requested.

@morningman morningman merged commit c63bf24 into apache:master Oct 12, 2023
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Oct 13, 2023
@Jibing-Li
[Improvement](statistics) Improve sample count accuracy (apache#25175)
036d3be 
While doing sample analyze, the result of row count, null number and datasize need to multiply a coefficient based on
the sample percent/rows. This pr is mainly to calculate the coefficient according to the sampled file size over total size.
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Oct 15, 2023
@Jibing-Li
[Improvement](statistics) Improve sample count accuracy (apache#25175)
a5857ad 
While doing sample analyze, the result of row count, null number and datasize need to multiply a coefficient based on
the sample percent/rows. This pr is mainly to calculate the coefficient according to the sampled file size over total size.
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Oct 15, 2023
@Jibing-Li
[Improvement](statistics) Improve sample count accuracy (apache#25175)
e81294f 
While doing sample analyze, the result of row count, null number and datasize need to multiply a coefficient based on
the sample percent/rows. This pr is mainly to calculate the coefficient according to the sampled file size over total size.
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Oct 15, 2023
@Jibing-Li
[Improvement](statistics) Improve sample count accuracy (apache#25175)
229725b 
While doing sample analyze, the result of row count, null number and datasize need to multiply a coefficient based on
the sample percent/rows. This pr is mainly to calculate the coefficient according to the sampled file size over total size.
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Oct 16, 2023
@Jibing-Li
[refactor](statistics) Merge external stats related pr to branch2.0
1680739 
apache#23170
apache#23574
apache#23751
apache#24414
apache#24154
apache#24376
apache#24696
apache#24540
apache#24891
apache#25175
@Jibing-Li Jibing-Li mentioned this pull request Oct 16, 2023
Merged
morningman pushed a commit that referenced this pull request Oct 16, 2023
@Jibing-Li
[branch2.0](backport)(statistics) Merge external stats related pr to …
23d7b4d 
…branch2.0 (#25462)

#23170
#23574
#23751
#24414
#24154
#24376
#24696
#24540
#24891
#25175
@Jibing-Li Jibing-Li deleted the sample branch October 17, 2023 04:05
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@Jibing-Li
[Improvement](statistics) Improve sample count accuracy (apache#25175)
dcbd705 
While doing sample analyze, the result of row count, null number and datasize need to multiply a coefficient based on 
the sample percent/rows. This pr is mainly to calculate the coefficient according to the sampled file size over total size.
@xiaokang xiaokang mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

+1 more reviewer

@Kikyou1997 Kikyou1997 Kikyou1997 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged merge_conflict reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Jibing-Li @doris-robot @morningman @Kikyou1997 @xiaokang