Skip to content

[Fix](statistics)Fix alter column stats data size is always 0 bug. #24891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Oct 9, 2023
Merged

[Fix](statistics)Fix alter column stats data size is always 0 bug. #24891

morningman merged 1 commit into from
Oct 9, 2023

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Sep 26, 2023

Fix alter column stats data size is always 0 bug.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Jibing-Li Jibing-Li force-pushed the alter branch 4 times, most recently from ade9367 to 3452ef8 Compare September 27, 2023 02:50
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

PR approved by anyone and no changes requested.

morningman
morningman previously approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman marked this pull request as ready for review October 8, 2023 01:57
@morningman
Copy link
Contributor

morningman commented Oct 8, 2023

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

doris-robot commented Oct 8, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.23 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162014421 Bytes

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Oct 9, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Oct 9, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.82 seconds
stream load tsv: 557 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162236906 Bytes

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Oct 9, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 9, 2023
@doris-robot
Copy link

doris-robot commented Oct 9, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.16 seconds
stream load tsv: 560 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162335899 Bytes

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Oct 9, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Oct 9, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.95 seconds
stream load tsv: 568 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162567327 Bytes

morningman
morningman approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit 7ceb029 into apache:master Oct 9, 2023
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Oct 13, 2023
@Jibing-Li
[Fix](statistics)Fix alter column stats data size is always 0 bug (ap…
f2ae6ee 
…ache#24891)

Fix alter column stats data size is always 0 bug.
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Oct 16, 2023
@Jibing-Li
[refactor](statistics) Merge external stats related pr to branch2.0
1680739 
apache#23170
apache#23574
apache#23751
apache#24414
apache#24154
apache#24376
apache#24696
apache#24540
apache#24891
apache#25175
@Jibing-Li Jibing-Li mentioned this pull request Oct 16, 2023
Merged
morningman pushed a commit that referenced this pull request Oct 16, 2023
@Jibing-Li
[branch2.0](backport)(statistics) Merge external stats related pr to …
23d7b4d 
…branch2.0 (#25462)

#23170
#23574
#23751
#24414
#24154
#24376
#24696
#24540
#24891
#25175
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@Jibing-Li
[Fix](statistics)Fix alter column stats data size is always 0 bug (ap…
ce1662c 
…ache#24891)

Fix alter column stats data size is always 0 bug.
@Jibing-Li Jibing-Li deleted the alter branch October 30, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

+1 more reviewer

@Kikyou1997 Kikyou1997 Kikyou1997 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged merge_conflict reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Jibing-Li @morningman @doris-robot @Kikyou1997 @xiaokang