-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](statistics)Fix analyze olap table couldn't get partition names bug. #24696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
08b82d4 to
217401c
Compare
|
run buildall |
|
Add some regression test or unit test to cover this problem? |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
217401c to
4390c52
Compare
4390c52 to
102a684
Compare
Added |
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
… bug (apache#24696) Call getPartitionNames to get all partitions while analyzing for olap table. Couldn't return NULL, otherwise analyze for olap table will do nothing.
Fix bug introduced by #24154
Call getPartitionNames to get all partitions while analyzing for olap table. Couldn't return NULL, otherwise analyze for olap table will do nothing.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...