Skip to content

Conversation

@eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Jul 24, 2024

This will correct result when meet json value like '2020-01-01'

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@eldenmoon eldenmoon changed the title [Fix](Variant) cast from jsonb with string value when enable `jsonb_s… [Fix](Variant) cast from jsonb with string value when enable jsonb_string_as_string should consider others types include date,datateime,array ... Jul 24, 2024
@eldenmoon
Copy link
Member Author

run buildall

1 similar comment
@eldenmoon
Copy link
Member Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39418 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0cfd6268d6d006d1f26eca127cbf794331081133, data reload: false

------ Round 1 ----------------------------------
q1	17614	4312	4245	4245
q2	2015	190	190	190
q3	10523	1184	1061	1061
q4	10184	855	713	713
q5	7543	2686	2656	2656
q6	224	140	136	136
q7	950	594	593	593
q8	9217	2068	2070	2068
q9	8880	6547	6521	6521
q10	8841	3736	3744	3736
q11	443	231	238	231
q12	463	222	221	221
q13	17915	2957	2999	2957
q14	271	241	232	232
q15	518	484	493	484
q16	502	397	380	380
q17	954	610	663	610
q18	7969	7552	7350	7350
q19	7387	1339	1355	1339
q20	659	303	316	303
q21	4917	3114	3339	3114
q22	351	278	286	278
Total cold run time: 118340 ms
Total hot run time: 39418 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4448	4251	4284	4251
q2	368	269	256	256
q3	3019	2880	2942	2880
q4	2005	1702	1736	1702
q5	5614	5520	5423	5423
q6	226	134	131	131
q7	2241	1864	1857	1857
q8	3280	3450	3413	3413
q9	8734	8856	8802	8802
q10	4131	3752	3833	3752
q11	577	492	516	492
q12	816	659	667	659
q13	17033	3194	3195	3194
q14	321	287	308	287
q15	522	483	497	483
q16	488	430	432	430
q17	1826	1504	1501	1501
q18	8113	7990	7911	7911
q19	1713	1510	1570	1510
q20	2147	1888	1863	1863
q21	8437	4814	4913	4814
q22	577	499	533	499
Total cold run time: 76636 ms
Total hot run time: 56110 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172971 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0cfd6268d6d006d1f26eca127cbf794331081133, data reload: false

query1	924	368	365	365
query2	6357	1869	1787	1787
query3	6651	200	211	200
query4	27817	17418	17281	17281
query5	3594	487	478	478
query6	269	163	168	163
query7	4574	290	285	285
query8	239	186	194	186
query9	8539	2414	2392	2392
query10	433	291	282	282
query11	10796	9962	10081	9962
query12	117	96	82	82
query13	1647	376	368	368
query14	8662	7980	6841	6841
query15	223	172	166	166
query16	7596	431	491	431
query17	1588	551	547	547
query18	1740	288	283	283
query19	201	156	161	156
query20	92	83	87	83
query21	211	130	127	127
query22	4305	4236	4233	4233
query23	34149	33797	33636	33636
query24	10787	2975	2865	2865
query25	639	400	414	400
query26	1088	155	155	155
query27	2479	278	279	278
query28	7275	2063	2074	2063
query29	931	656	648	648
query30	254	165	232	165
query31	976	762	744	744
query32	92	62	54	54
query33	752	326	324	324
query34	939	500	497	497
query35	871	736	750	736
query36	1149	999	983	983
query37	149	83	88	83
query38	2967	2899	2838	2838
query39	897	831	869	831
query40	201	117	116	116
query41	44	47	42	42
query42	118	93	96	93
query43	488	473	465	465
query44	1207	717	725	717
query45	192	161	162	161
query46	1079	721	708	708
query47	1862	1764	1791	1764
query48	368	293	285	285
query49	864	396	405	396
query50	783	378	388	378
query51	6790	6706	6624	6624
query52	99	90	93	90
query53	361	288	276	276
query54	874	443	434	434
query55	72	75	91	75
query56	291	270	260	260
query57	1141	1054	1084	1054
query58	251	244	257	244
query59	2777	2656	2692	2656
query60	296	277	266	266
query61	93	92	93	92
query62	794	645	647	645
query63	319	284	285	284
query64	9513	2216	1627	1627
query65	3165	3080	3105	3080
query66	781	327	320	320
query67	15675	15072	15024	15024
query68	4638	536	545	536
query69	633	433	352	352
query70	1172	1136	1155	1136
query71	438	271	273	271
query72	8567	5373	5471	5373
query73	753	320	322	320
query74	6192	5635	5732	5635
query75	4239	2664	2661	2661
query76	3359	895	929	895
query77	696	299	290	290
query78	11120	9256	9072	9072
query79	8132	529	535	529
query80	1178	485	490	485
query81	596	219	229	219
query82	883	139	133	133
query83	402	164	161	161
query84	274	82	84	82
query85	997	299	354	299
query86	446	327	310	310
query87	3343	3129	3070	3070
query88	5217	2393	2376	2376
query89	537	379	378	378
query90	2014	194	198	194
query91	129	100	99	99
query92	64	47	51	47
query93	5442	518	513	513
query94	1289	294	293	293
query95	409	321	314	314
query96	615	272	276	272
query97	3155	3042	3046	3042
query98	226	194	196	194
query99	1512	1294	1246	1246
Total cold run time: 292134 ms
Total hot run time: 172971 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.57 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0cfd6268d6d006d1f26eca127cbf794331081133, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.23	0.06	0.05
query4	1.68	0.07	0.08
query5	0.50	0.49	0.48
query6	1.13	0.74	0.73
query7	0.02	0.01	0.01
query8	0.06	0.05	0.05
query9	0.55	0.49	0.49
query10	0.55	0.55	0.54
query11	0.16	0.11	0.11
query12	0.16	0.13	0.12
query13	0.60	0.59	0.59
query14	0.76	0.78	0.83
query15	0.88	0.83	0.83
query16	0.37	0.37	0.36
query17	0.98	0.97	0.95
query18	0.22	0.21	0.21
query19	1.93	1.74	1.71
query20	0.01	0.00	0.02
query21	15.43	0.78	0.67
query22	4.13	7.64	1.71
query23	18.28	1.39	1.29
query24	2.20	0.23	0.21
query25	0.16	0.09	0.08
query26	0.31	0.21	0.21
query27	0.46	0.23	0.23
query28	13.25	1.06	1.02
query29	12.64	3.29	3.32
query30	0.25	0.07	0.05
query31	2.86	0.41	0.40
query32	3.24	0.50	0.48
query33	2.91	2.95	2.92
query34	17.09	4.41	4.35
query35	4.38	4.49	4.45
query36	0.67	0.47	0.47
query37	0.19	0.15	0.15
query38	0.15	0.16	0.15
query39	0.04	0.04	0.04
query40	0.16	0.12	0.13
query41	0.09	0.04	0.05
query42	0.05	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.89 s
Total hot run time: 30.57 s

@eldenmoon
Copy link
Member Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40186 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b6ce3f99189406a91349962175a44cff90d59187, data reload: false

------ Round 1 ----------------------------------
q1	18149	4569	4473	4473
q2	2490	197	196	196
q3	10950	1241	1100	1100
q4	11301	779	808	779
q5	7840	2813	2666	2666
q6	222	140	141	140
q7	990	621	613	613
q8	9566	2070	2089	2070
q9	8629	6580	6553	6553
q10	8677	3792	3780	3780
q11	483	241	244	241
q12	390	220	221	220
q13	18752	2988	2992	2988
q14	288	233	236	233
q15	540	484	478	478
q16	502	387	379	379
q17	975	690	640	640
q18	8151	7625	7507	7507
q19	3382	1425	1301	1301
q20	701	321	332	321
q21	4900	3222	3300	3222
q22	356	292	286	286
Total cold run time: 118234 ms
Total hot run time: 40186 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4336	4264	4237	4237
q2	377	272	262	262
q3	3032	2733	2802	2733
q4	1888	1604	1573	1573
q5	5312	5338	5337	5337
q6	221	129	131	129
q7	2112	1738	1707	1707
q8	3210	3357	3364	3357
q9	8399	8415	8422	8415
q10	3922	3631	3681	3631
q11	573	512	496	496
q12	779	606	597	597
q13	17526	2963	3052	2963
q14	300	276	278	276
q15	520	466	485	466
q16	493	429	419	419
q17	1780	1489	1465	1465
q18	7913	7612	7424	7424
q19	2498	1575	1637	1575
q20	1997	1813	1752	1752
q21	4891	4668	4670	4668
q22	603	514	527	514
Total cold run time: 72682 ms
Total hot run time: 53996 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172588 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b6ce3f99189406a91349962175a44cff90d59187, data reload: false

query1	910	377	365	365
query2	6445	1869	1777	1777
query3	6649	207	218	207
query4	23392	17397	17485	17397
query5	4221	479	476	476
query6	263	168	174	168
query7	4591	295	289	289
query8	244	201	199	199
query9	8509	2415	2387	2387
query10	449	299	274	274
query11	10348	10111	10117	10111
query12	138	84	81	81
query13	1642	376	375	375
query14	10058	7647	7079	7079
query15	229	164	168	164
query16	7203	457	429	429
query17	1585	540	530	530
query18	1255	287	284	284
query19	203	148	157	148
query20	95	84	81	81
query21	203	132	151	132
query22	4321	4074	3930	3930
query23	33650	33176	33097	33097
query24	11972	2898	2797	2797
query25	644	363	390	363
query26	1823	150	152	150
query27	2816	271	275	271
query28	7219	1996	2008	1996
query29	1046	629	609	609
query30	289	147	147	147
query31	1007	758	726	726
query32	95	52	53	52
query33	775	322	323	322
query34	877	487	484	484
query35	853	736	731	731
query36	1094	956	929	929
query37	226	79	79	79
query38	2862	2757	2715	2715
query39	861	809	824	809
query40	268	122	117	117
query41	48	48	44	44
query42	114	97	103	97
query43	485	465	458	458
query44	1208	730	728	728
query45	232	174	176	174
query46	1087	747	711	711
query47	1840	1785	1748	1748
query48	365	296	292	292
query49	1203	411	400	400
query50	767	397	395	395
query51	6806	6811	6618	6618
query52	113	87	95	87
query53	359	286	288	286
query54	955	447	460	447
query55	78	72	74	72
query56	281	281	264	264
query57	1135	1049	1056	1049
query58	253	246	250	246
query59	2865	2611	2566	2566
query60	335	275	280	275
query61	99	94	94	94
query62	870	620	665	620
query63	326	294	289	289
query64	10561	2223	1692	1692
query65	3366	3141	3106	3106
query66	1315	341	402	341
query67	15405	15001	14800	14800
query68	4552	568	555	555
query69	514	412	342	342
query70	1131	1112	1133	1112
query71	366	305	280	280
query72	6983	6177	5887	5887
query73	756	331	324	324
query74	6135	5718	5753	5718
query75	3437	2668	2711	2668
query76	2757	907	937	907
query77	574	311	300	300
query78	9505	9092	10683	9092
query79	3845	525	525	525
query80	1776	480	482	480
query81	576	223	223	223
query82	1303	135	145	135
query83	324	171	178	171
query84	273	86	88	86
query85	1572	328	416	328
query86	481	329	307	307
query87	3277	3054	3105	3054
query88	3688	2373	2364	2364
query89	465	400	389	389
query90	1848	196	187	187
query91	129	100	102	100
query92	59	48	55	48
query93	2895	523	519	519
query94	1292	300	273	273
query95	408	325	310	310
query96	596	271	267	267
query97	3184	3007	3023	3007
query98	219	193	193	193
query99	1603	1301	1261	1261
Total cold run time: 280324 ms
Total hot run time: 172588 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.23 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b6ce3f99189406a91349962175a44cff90d59187, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.04	0.06
query4	1.66	0.09	0.09
query5	0.48	0.48	0.47
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.06	0.04	0.05
query9	0.57	0.49	0.49
query10	0.53	0.53	0.54
query11	0.15	0.11	0.12
query12	0.16	0.13	0.12
query13	0.61	0.58	0.58
query14	0.76	0.79	0.81
query15	0.86	0.80	0.81
query16	0.35	0.35	0.37
query17	0.95	0.96	1.02
query18	0.22	0.22	0.22
query19	1.78	1.68	1.71
query20	0.02	0.01	0.01
query21	15.40	0.78	0.64
query22	4.14	7.85	1.67
query23	18.30	1.40	1.26
query24	2.12	0.24	0.21
query25	0.16	0.09	0.08
query26	0.30	0.20	0.21
query27	0.45	0.24	0.23
query28	13.24	1.02	1.00
query29	12.63	3.28	3.26
query30	0.25	0.06	0.05
query31	2.87	0.39	0.39
query32	3.28	0.47	0.47
query33	2.88	2.90	2.94
query34	17.11	4.31	4.35
query35	4.40	4.42	4.44
query36	0.64	0.46	0.51
query37	0.19	0.17	0.15
query38	0.15	0.15	0.16
query39	0.05	0.04	0.03
query40	0.15	0.12	0.13
query41	0.09	0.05	0.05
query42	0.05	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.54 s
Total hot run time: 30.23 s

…tring_as_string` should consider others types include date,datateime,array ...
@eldenmoon
Copy link
Member Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40020 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9b13308dbc15425f100b9fd99822dcf07985157c, data reload: false

------ Round 1 ----------------------------------
q1	17641	4339	4298	4298
q2	2022	193	191	191
q3	10554	1159	1175	1159
q4	10298	744	795	744
q5	7543	2721	2724	2721
q6	223	141	138	138
q7	971	602	612	602
q8	9223	2088	2090	2088
q9	8777	6590	6544	6544
q10	8889	3843	3779	3779
q11	446	251	246	246
q12	494	234	223	223
q13	17769	2960	3010	2960
q14	283	246	231	231
q15	520	483	474	474
q16	501	387	383	383
q17	970	653	665	653
q18	8204	7458	7468	7458
q19	1587	1414	1341	1341
q20	679	317	333	317
q21	4958	3180	3240	3180
q22	349	292	290	290
Total cold run time: 112901 ms
Total hot run time: 40020 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4359	4262	4263	4262
q2	370	262	259	259
q3	3030	2812	2815	2812
q4	1884	1605	1605	1605
q5	5307	5301	5318	5301
q6	224	134	129	129
q7	2096	1769	1722	1722
q8	3222	3378	3337	3337
q9	8456	8488	8452	8452
q10	3941	3767	3718	3718
q11	570	500	493	493
q12	761	599	600	599
q13	16610	2955	3008	2955
q14	302	285	292	285
q15	513	477	485	477
q16	466	408	417	408
q17	1804	1508	1474	1474
q18	7704	7384	7340	7340
q19	1701	1531	1605	1531
q20	1999	1781	1768	1768
q21	4784	4634	4857	4634
q22	570	490	504	490
Total cold run time: 70673 ms
Total hot run time: 54051 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173066 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9b13308dbc15425f100b9fd99822dcf07985157c, data reload: false

query1	911	383	379	379
query2	6458	1957	1848	1848
query3	6657	207	219	207
query4	28454	17594	17419	17419
query5	4206	487	484	484
query6	260	189	159	159
query7	4590	285	300	285
query8	242	187	187	187
query9	8586	2412	2392	2392
query10	450	295	281	281
query11	10581	10149	10013	10013
query12	146	85	81	81
query13	1641	394	366	366
query14	10364	7106	7723	7106
query15	240	162	166	162
query16	7925	418	469	418
query17	1585	540	537	537
query18	1952	298	274	274
query19	195	151	153	151
query20	89	84	80	80
query21	204	131	121	121
query22	4427	4238	4010	4010
query23	33898	33209	33093	33093
query24	11778	2925	2882	2882
query25	644	369	395	369
query26	1712	150	156	150
query27	2919	267	282	267
query28	7608	2000	2016	2000
query29	1035	633	625	625
query30	288	149	146	146
query31	982	733	741	733
query32	95	51	54	51
query33	772	335	334	334
query34	896	501	499	499
query35	878	732	734	732
query36	1092	942	890	890
query37	143	80	85	80
query38	2882	2819	2751	2751
query39	883	816	830	816
query40	271	128	126	126
query41	50	47	47	47
query42	128	104	112	104
query43	513	482	479	479
query44	1238	745	736	736
query45	216	174	179	174
query46	1117	739	752	739
query47	1834	1760	1760	1760
query48	416	295	293	293
query49	1178	427	425	425
query50	795	404	400	400
query51	6844	6713	6715	6713
query52	97	97	92	92
query53	356	301	291	291
query54	946	455	453	453
query55	78	76	74	74
query56	303	279	272	272
query57	1160	1044	1075	1044
query58	262	248	258	248
query59	2961	2566	2607	2566
query60	305	291	285	285
query61	98	136	99	99
query62	833	623	626	623
query63	332	295	296	295
query64	10491	2235	1697	1697
query65	3147	3117	3114	3114
query66	1143	345	325	325
query67	15469	14985	14920	14920
query68	4572	550	562	550
query69	466	359	336	336
query70	1162	1132	1166	1132
query71	414	285	286	285
query72	6889	5654	5988	5654
query73	760	331	338	331
query74	6166	5639	5742	5639
query75	3620	2722	2650	2650
query76	2776	938	960	938
query77	492	321	319	319
query78	9507	9605	8993	8993
query79	2334	535	539	535
query80	1225	491	493	491
query81	573	218	224	218
query82	790	134	132	132
query83	274	169	169	169
query84	251	88	89	88
query85	1800	325	315	315
query86	484	311	299	299
query87	3270	3121	3116	3116
query88	3693	2388	2412	2388
query89	507	396	389	389
query90	1858	203	205	203
query91	143	116	116	116
query92	65	55	53	53
query93	2345	524	524	524
query94	1280	319	377	319
query95	420	330	321	321
query96	618	281	279	279
query97	3166	3055	3084	3055
query98	221	191	196	191
query99	1586	1308	1266	1266
Total cold run time: 284976 ms
Total hot run time: 173066 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.04 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9b13308dbc15425f100b9fd99822dcf07985157c, data reload: false

query1	0.04	0.04	0.03
query2	0.09	0.04	0.04
query3	0.22	0.05	0.05
query4	1.69	0.07	0.07
query5	0.51	0.50	0.49
query6	1.13	0.73	0.73
query7	0.02	0.01	0.01
query8	0.04	0.04	0.04
query9	0.57	0.49	0.50
query10	0.56	0.55	0.54
query11	0.16	0.12	0.11
query12	0.16	0.12	0.13
query13	0.61	0.58	0.58
query14	0.79	0.78	0.81
query15	0.86	0.81	0.83
query16	0.35	0.37	0.37
query17	0.96	1.01	1.01
query18	0.23	0.22	0.21
query19	1.82	1.76	1.84
query20	0.01	0.00	0.00
query21	15.39	0.79	0.67
query22	4.24	7.83	2.23
query23	18.28	1.51	1.29
query24	2.07	0.24	0.24
query25	0.15	0.08	0.08
query26	0.30	0.21	0.20
query27	0.46	0.23	0.23
query28	13.19	1.02	1.01
query29	12.60	3.28	3.27
query30	0.24	0.06	0.05
query31	2.88	0.38	0.39
query32	3.26	0.46	0.46
query33	2.89	2.94	2.89
query34	17.09	4.34	4.37
query35	4.41	4.42	4.45
query36	0.65	0.49	0.48
query37	0.19	0.16	0.15
query38	0.14	0.14	0.14
query39	0.04	0.03	0.04
query40	0.15	0.13	0.13
query41	0.09	0.05	0.04
query42	0.05	0.04	0.04
query43	0.05	0.03	0.03
Total cold run time: 109.63 s
Total hot run time: 31.04 s

Copy link
Contributor

@amorynan amorynan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 26, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@qidaye qidaye merged commit 13cfe3d into apache:master Jul 26, 2024
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Jul 30, 2024
…tring_as_string` should consider others types include date,datateime,array ... (apache#38291)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants