[Fix](Variant) fix outof range exception after calling function element_at for variant type #38318

eldenmoon · 2024-07-24T11:35:25Z

…nt_at for variant type

src subcolumns empty but src row count may not be 0, so need to padding rows to at least src.size() and finlize at last

[CANCELLED][E6] Parameter out of bound in IColumnStr<T>::insert_range_from me !

Proposed changes

Issue Number: close #xxx

…nt_at for variant type src subcolumns empty but src row count may not be 0, so need to padding rows to at least src.size() and finlize at last

doris-robot · 2024-07-24T11:35:34Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

eldenmoon · 2024-07-24T11:35:57Z

run buildall

github-actions · 2024-07-24T11:41:33Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-07-24T11:56:17Z

TPC-H: Total hot run time: 40106 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a443c56ae7834a6e68d3ae90ada972157e6368ec, data reload: false

------ Round 1 ----------------------------------
q1	18052	4491	4406	4406
q2	2477	195	195	195
q3	11557	1197	1116	1116
q4	10776	788	829	788
q5	7738	2740	2716	2716
q6	224	141	135	135
q7	965	609	602	602
q8	9231	2085	2078	2078
q9	8558	6560	6552	6552
q10	8751	3774	3769	3769
q11	452	230	234	230
q12	392	225	216	216
q13	17890	2988	2972	2972
q14	286	235	239	235
q15	520	483	496	483
q16	508	379	374	374
q17	971	655	688	655
q18	8187	7463	7456	7456
q19	7435	1475	1363	1363
q20	690	317	330	317
q21	4840	3167	3335	3167
q22	349	281	289	281
Total cold run time: 120849 ms
Total hot run time: 40106 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4388	4288	4272	4272
q2	377	261	258	258
q3	3004	2795	2745	2745
q4	1937	1626	1618	1618
q5	5314	5311	5352	5311
q6	215	128	128	128
q7	2110	1742	1715	1715
q8	3229	3343	3306	3306
q9	8354	8358	8323	8323
q10	3926	3713	3714	3713
q11	576	498	493	493
q12	754	631	595	595
q13	16858	2991	2980	2980
q14	328	297	264	264
q15	520	483	480	480
q16	470	429	419	419
q17	1762	1470	1463	1463
q18	7812	7639	7385	7385
q19	1657	1493	1451	1451
q20	1998	1791	1779	1779
q21	4773	4713	4737	4713
q22	559	494	495	494
Total cold run time: 70921 ms
Total hot run time: 53905 ms

doris-robot · 2024-07-24T12:07:29Z

TPC-DS: Total hot run time: 173515 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a443c56ae7834a6e68d3ae90ada972157e6368ec, data reload: false

query1	917	375	362	362
query2	6465	1911	1844	1844
query3	6677	210	215	210
query4	24688	17563	17254	17254
query5	4173	501	494	494
query6	268	185	163	163
query7	4605	294	290	290
query8	232	195	186	186
query9	8533	2453	2398	2398
query10	434	274	269	269
query11	10692	10075	10119	10075
query12	131	84	80	80
query13	1642	372	367	367
query14	10238	7753	7487	7487
query15	214	172	172	172
query16	7805	459	467	459
query17	1271	548	551	548
query18	1948	283	275	275
query19	194	147	145	145
query20	95	83	82	82
query21	211	127	124	124
query22	4141	4109	4114	4109
query23	33791	33305	33309	33305
query24	12177	2874	2846	2846
query25	680	359	375	359
query26	1807	149	146	146
query27	2906	272	274	272
query28	7529	2024	1992	1992
query29	1125	664	612	612
query30	289	148	151	148
query31	944	739	725	725
query32	89	53	55	53
query33	752	322	326	322
query34	888	482	495	482
query35	874	717	718	717
query36	1087	932	961	932
query37	181	78	81	78
query38	2841	2744	2737	2737
query39	874	809	798	798
query40	280	121	117	117
query41	46	46	47	46
query42	123	105	100	100
query43	506	466	474	466
query44	1197	742	728	728
query45	205	178	177	177
query46	1109	762	741	741
query47	1847	1768	1758	1758
query48	372	305	299	299
query49	1229	408	419	408
query50	795	398	400	398
query51	6814	6782	6611	6611
query52	111	88	97	88
query53	359	292	294	292
query54	909	448	451	448
query55	75	74	75	74
query56	293	268	290	268
query57	1130	1065	1053	1053
query58	251	265	258	258
query59	2793	2550	2530	2530
query60	301	278	280	278
query61	127	95	98	95
query62	851	647	662	647
query63	328	295	294	294
query64	10529	2255	1675	1675
query65	3236	3120	3110	3110
query66	1384	371	337	337
query67	15577	15174	15063	15063
query68	4589	560	550	550
query69	463	347	354	347
query70	1192	1159	1083	1083
query71	390	276	283	276
query72	7312	5797	5947	5797
query73	772	327	333	327
query74	6145	5706	5640	5640
query75	3408	2707	2699	2699
query76	2627	955	922	922
query77	478	297	317	297
query78	11221	9243	8972	8972
query79	3063	529	525	525
query80	1279	484	473	473
query81	577	221	217	217
query82	622	144	132	132
query83	286	169	173	169
query84	279	86	92	86
query85	1014	322	397	322
query86	495	312	333	312
query87	3331	3086	3092	3086
query88	4426	2398	2403	2398
query89	506	387	402	387
query90	1939	199	197	197
query91	132	102	104	102
query92	66	49	52	49
query93	4235	519	523	519
query94	1207	266	261	261
query95	410	319	326	319
query96	629	284	283	283
query97	3172	3021	3106	3021
query98	218	203	200	200
query99	1574	1271	1276	1271
Total cold run time: 285242 ms
Total hot run time: 173515 ms

doris-robot · 2024-07-24T12:13:00Z

ClickBench: Total hot run time: 31.22 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a443c56ae7834a6e68d3ae90ada972157e6368ec, data reload: false

query1	0.05	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.04	0.05
query4	1.68	0.06	0.07
query5	0.50	0.49	0.49
query6	1.14	0.73	0.73
query7	0.02	0.01	0.01
query8	0.06	0.04	0.04
query9	0.56	0.49	0.50
query10	0.54	0.54	0.54
query11	0.15	0.11	0.11
query12	0.14	0.12	0.12
query13	0.60	0.58	0.58
query14	0.76	0.78	0.79
query15	0.84	0.81	0.80
query16	0.37	0.37	0.36
query17	1.00	0.98	0.98
query18	0.22	0.22	0.22
query19	1.82	1.69	1.73
query20	0.01	0.01	0.03
query21	15.40	0.76	0.66
query22	3.91	6.50	2.61
query23	18.29	1.41	1.20
query24	2.13	0.23	0.21
query25	0.14	0.09	0.09
query26	0.30	0.20	0.20
query27	0.46	0.23	0.23
query28	13.34	1.01	0.98
query29	12.61	3.44	3.38
query30	0.25	0.06	0.05
query31	2.87	0.38	0.38
query32	3.27	0.47	0.47
query33	2.88	2.89	2.88
query34	17.09	4.45	4.32
query35	4.41	4.43	4.41
query36	0.66	0.48	0.47
query37	0.18	0.16	0.15
query38	0.16	0.15	0.14
query39	0.04	0.04	0.03
query40	0.16	0.12	0.13
query41	0.10	0.04	0.05
query42	0.05	0.05	0.05
query43	0.04	0.03	0.05
Total cold run time: 109.5 s
Total hot run time: 31.22 s

amorynan

LGTM

github-actions · 2024-07-25T02:17:47Z

PR approved by anyone and no changes requested.

#38318 #38291

xiaokang

LGTM

github-actions · 2024-07-25T07:39:27Z

PR approved by at least one committer and no changes requested.

…nt_at for variant type (apache#38318) …nt_at for variant type src subcolumns empty but src row count may not be 0, so need to padding rows to at least src.size() and finlize at last ``` [CANCELLED][E6] Parameter out of bound in IColumnStr<T>::insert_range_from me ! ```

#38318 #38364 #38291 #38213 #38413

[Fix](Variant) fix outof range exception after calling function eleme…

a443c56

…nt_at for variant type src subcolumns empty but src row count may not be 0, so need to padding rows to at least src.size() and finlize at last

eldenmoon added dev/2.1.x dev/3.0.x doing labels Jul 24, 2024

eldenmoon mentioned this pull request Jul 25, 2024

[Pick](Variant) fix some issue by RQG #38336

Merged

amorynan approved these changes Jul 25, 2024

View reviewed changes

github-actions bot added the reviewed label Jul 25, 2024

yiguolei pushed a commit that referenced this pull request Jul 25, 2024

[Pick](Variant) fix some issue by RQG (#38336)

73fc55b

#38318 #38291

yiguolei added dev/2.1.6-merged and removed dev/2.1.x labels Jul 25, 2024

xiaokang changed the title ~~[Fix](Variant) fix outof range exception after calling function eleme…~~ [Fix](Variant) fix outof range exception after calling function element_at for variant type Jul 25, 2024

xiaokang approved these changes Jul 25, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 25, 2024

eldenmoon merged commit 20c4cad into apache:master Jul 25, 2024

eldenmoon mentioned this pull request Jul 30, 2024

[Pick](Variant) pick some fix #38513

Merged

eldenmoon added dev/3.0.1-merged and removed dev/3.0.x doing labels Jul 30, 2024

eldenmoon added a commit that referenced this pull request Jul 30, 2024

[Pick](Variant) pick some fix (#38513)

70c308c

#38318 #38364 #38291 #38213 #38413

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix](Variant) fix outof range exception after calling function element_at for variant type #38318

[Fix](Variant) fix outof range exception after calling function element_at for variant type #38318

Uh oh!

eldenmoon commented Jul 24, 2024 •

edited

Loading

Uh oh!

doris-robot commented Jul 24, 2024

Uh oh!

eldenmoon commented Jul 24, 2024

Uh oh!

github-actions bot commented Jul 24, 2024

Uh oh!

doris-robot commented Jul 24, 2024

Uh oh!

doris-robot commented Jul 24, 2024

Uh oh!

doris-robot commented Jul 24, 2024

Uh oh!

amorynan left a comment

Uh oh!

github-actions bot commented Jul 25, 2024

Uh oh!

xiaokang left a comment

Uh oh!

github-actions bot commented Jul 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[Fix](Variant) fix outof range exception after calling function element_at for variant type #38318

[Fix](Variant) fix outof range exception after calling function element_at for variant type #38318

Uh oh!

Conversation

eldenmoon commented Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Uh oh!

doris-robot commented Jul 24, 2024

Uh oh!

eldenmoon commented Jul 24, 2024

Uh oh!

github-actions bot commented Jul 24, 2024

Uh oh!

doris-robot commented Jul 24, 2024

Uh oh!

doris-robot commented Jul 24, 2024

Uh oh!

doris-robot commented Jul 24, 2024

Uh oh!

amorynan left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 25, 2024

Uh oh!

xiaokang left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

eldenmoon commented Jul 24, 2024 •

edited

Loading