[Fix](Variant) check storage type before apply get_row_ranges_by_dict
#38413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. storage type maybe missmatch with predicate type eg. cast(v['a'] as date) = '2020-01-01'. v['a'] in storage is string type, but predicate type is date type
2. serialization object with empty subcolumns may lost num_rows, so need to record num_rows and set back num_rows in serdes
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39221 ms |
TPC-DS: Total hot run time: 173703 ms |
ClickBench: Total hot run time: 31.07 s |
xiaokang
reviewed
Jul 28, 2024
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
eldenmoon
force-pushed
the
fix-rqg-0726
branch
4 times, most recently
from
4e283cc to
6084257
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
2 similar comments
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
Member
Author
|
run performance |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 42059 ms |
TPC-H: Total hot run time: 41593 ms |
TPC-DS: Total hot run time: 170426 ms |
TPC-DS: Total hot run time: 171368 ms |
ClickBench: Total hot run time: 30 s |
ClickBench: Total hot run time: 30.12 s |
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Jul 30, 2024
…t` (apache#38413) 1. storage type maybe missmatch with predicate type eg. cast(v['a'] as date) = '2020-01-01'. v['a'] in storage is string type, but predicate type is date type 2. serialization object with empty subcolumns may lost num_rows, so need to record num_rows and set back num_rows in serdes
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Jul 30, 2024
…t` (apache#38413) 1. storage type maybe missmatch with predicate type eg. cast(v['a'] as date) = '2020-01-01'. v['a'] in storage is string type, but predicate type is date type 2. serialization object with empty subcolumns may lost num_rows, so need to record num_rows and set back num_rows in serdes
xiaokang
pushed a commit
that referenced
this pull request
Jul 31, 2024
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Sep 28, 2024
… empty (apache#38413) serialization object with empty subcolumns may lost num_rows, so need to record num_rows and set back num_rows in serdes backport apache#38413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storage type maybe missmatch with predicate type eg. cast(v['a'] as date) = '2020-01-01'. v['a'] in storage is string type, but predicate type is date type
serialization object with empty subcolumns may lost num_rows, so need to record num_rows and set back num_rows in serdes
Proposed changes
Issue Number: close #xxx