[Pick](Variant) pick some fix #38513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt_at for variant type (apache#38318) …nt_at for variant type src subcolumns empty but src row count may not be 0, so need to padding rows to at least src.size() and finlize at last ``` [CANCELLED][E6] Parameter out of bound in IColumnStr<T>::insert_range_from me ! ```
…ns` is empty (apache#38364) Set rows correct when subcolumns is empty, and implement resize method with correct semantic This fix the potential crash with stack bellow ``` 6# doris::vectorized::ColumnObject::get(unsigned long, doris::vectorized::Field&) const at /root/doris/be/src/vec/columns/column_object.cpp:841 7# doris::vectorized::ColumnObject::operator[](unsigned long) const at /root/doris/be/src/vec/columns/column_object.cpp:838 8# doris::vectorized::ColumnObject::insert_from(doris::vectorized::IColumn const&, unsigned long) in /home/work/unlimit_teamcity/TeamCity/Agents/20240725170551agent_172.16.0.48_1/work/60183217f6ee2a9c/output/be/lib/doris_be 9# doris::vectorized::ColumnObject::insert_indices_from(doris::vectorized::IColumn const&, unsigned int const*, unsigned int const*) at /root/doris/be/src/vec/columns/column_object.cpp:1581 ```
…tring_as_string` should consider others types include date,datateime,array ... (apache#38291)
…th (apache#38213) ``` curl --location-trusted -u root: -T value.json -H "read_json_by_line:true" -H "format:json" -H "max_filter_ratio:0.5" -H "jsonpaths: [\"$.id\", \"$.entity_id\", \"$.\"]" http://127.0.0.1:8149/api/regression_test/records/_stream_load ```
…t` (apache#38413) 1. storage type maybe missmatch with predicate type eg. cast(v['a'] as date) = '2020-01-01'. v['a'] in storage is string type, but predicate type is date type 2. serialization object with empty subcolumns may lost num_rows, so need to record num_rows and set back num_rows in serdes
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#38318
#38364
#38291
#38213
#38413