MINOR: Remove RaftManager.maybeDeleteMetadataLogDir and AutoTopicCreationManagerTest.scala#17365
Merged
chia7712 merged 2 commits intoapache:trunkfrom Jan 7, 2025
Merged
MINOR: Remove RaftManager.maybeDeleteMetadataLogDir and AutoTopicCreationManagerTest.scala#17365chia7712 merged 2 commits intoapache:trunkfrom
chia7712 merged 2 commits intoapache:trunkfrom
Conversation
chia7712
reviewed
Oct 6, 2024
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@cmccabe could you please check the failed test? testDefaultTopicConfig, testMetricsReporterUpdate, and testThreadPoolResize need to add @ParameterizedTest and @ValueSource(strings = Array("kraft")) to ensure they are running with kraft.
Member
|
@cmccabe Can you rebase to resolve the conflicts? Thanks |
cmccabe
added a commit
that referenced
this pull request
Dec 19, 2024
Remove ReplicationQuotaUtils.scala since it's not used any more. Remove DynamicBrokerConfigTest.testEnableDefaultUncleanLeaderElection since it tests the ZK-based controller, and we have other tests for configuring unclean leader election in KRaft mode. Remove RaftManager.maybeDeleteMetadataLogDir since it was only used during ZK migration, and that code has been removed. Similarly, remove RaftManagerTest.testKRaftBrokerDoesNotDeleteMetadataLog which tested that function. Move KafkaServer.MIN_INCREMENTAL_FETCH_SESSION_EVICTION_MS to KafkaBroker. Remove AutoTopicCreationManagerTest since it tests the ZK-mode-only AutoTopicReationManager.
cmccabe
changed the title
Contributor
Author
|
@mimaison : just rebased. |
Remove ReplicationQuotaUtils.scala since it's not used any more. Remove DynamicBrokerConfigTest.testEnableDefaultUncleanLeaderElection since it tests the ZK-based controller, and we have other tests for configuring unclean leader election in KRaft mode. Remove RaftManager.maybeDeleteMetadataLogDir since it was only used during ZK migration, and that code has been removed. Similarly, remove RaftManagerTest.testKRaftBrokerDoesNotDeleteMetadataLog which tested that function. Move KafkaServer.MIN_INCREMENTAL_FETCH_SESSION_EVICTION_MS to KafkaBroker. Remove AutoTopicCreationManagerTest since it tests the ZK-mode-only AutoTopicReationManager.
cmccabe
changed the title
Member
|
The test failure is https://issues.apache.org/jira/browse/KAFKA-18297, so it's not related to this PR. |
Member
|
oh, sorry that the PR I just merge causes the conflicts on |
chia7712
approved these changes
Jan 7, 2025
chia7712
changed the title
chia7712
pushed a commit
that referenced
this pull request
Jan 7, 2025
…tionManagerTest.scala (#17365) Remove RaftManager.maybeDeleteMetadataLogDir since it was only used during ZK migration, and that code has been removed. Similarly, remove RaftManagerTest.testKRaftBrokerDoesNotDeleteMetadataLog which tested that function. Remove AutoTopicCreationManagerTest since it tests the ZK-mode-only AutoTopicReationManager. Reviewers: Mickael Maison <mickael.maison@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Jan 8, 2025
…og-compaction-write-record-v2 * apache-github/trunk: (34 commits) MINOR: Bump year to 2025 in NOTICE file (apache#18427) KAFKA-18411 Remove ZkProducerIdManager (apache#18413) KAFKA-18408 tweak the 'tag' field for BrokerHeartbeatRequest.json, BrokerRegistrationChangeRecord.json and RegisterBrokerRecord.json (apache#18421) KAFKA-18414 Remove KRaftRegistrationResult (apache#18401) KAFKA-17921 Support SASL_PLAINTEXT protocol with java.security.auth.login.config (apache#17671) KAFKA-18384 Remove ZkAlterPartitionManager (apache#18364) KAFKA-10790: Add deadlock detection to producer#flush (apache#17946) KAFKA-18412: Remove EmbeddedZookeeper (apache#18399) MINOR : Improve Exception log in NotEnoughReplicasException(apache#12394) MINOR: Improve PlaintextAdminIntegrationTest#testConsumerGroups (apache#18409) MINOR: Remove unused local variable (apache#18410) MINOR: Remove RaftManager.maybeDeleteMetadataLogDir and AutoTopicCreationManagerTest.scala (apache#17365) KAFKA-18368 Remove TestUtils#MockZkConnect and remove zkConnect from TestUtils#createBrokerConfig (apache#18352) MINOR: Update Consumer group timeout default to 30 sec (apache#16406) MINOR: Fix typo in CommitRequestManager (apache#18407) MINOR: cleanup JavaDocs for deprecation warnings (apache#18402) KAFKA-18303; Update ShareCoordinator to use new record format (apache#18396) MINOR: Update Consumer and Producer JavaDocs for committing offsets (apache#18336) KAFKA-16446: Improve controller event duration logging (apache#15622) KAFKA-18388 test-kraft-server-start.sh should use log4j2.yaml (apache#18370) ...
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
…tionManagerTest.scala (apache#17365) Remove RaftManager.maybeDeleteMetadataLogDir since it was only used during ZK migration, and that code has been removed. Similarly, remove RaftManagerTest.testKRaftBrokerDoesNotDeleteMetadataLog which tested that function. Remove AutoTopicCreationManagerTest since it tests the ZK-mode-only AutoTopicReationManager. Reviewers: Mickael Maison <mickael.maison@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
…tionManagerTest.scala (apache#17365) Remove RaftManager.maybeDeleteMetadataLogDir since it was only used during ZK migration, and that code has been removed. Similarly, remove RaftManagerTest.testKRaftBrokerDoesNotDeleteMetadataLog which tested that function. Remove AutoTopicCreationManagerTest since it tests the ZK-mode-only AutoTopicReationManager. Reviewers: Mickael Maison <mickael.maison@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove RaftManager.maybeDeleteMetadataLogDir since it's not used any more. also remove AutoTopicCreationManagerTest since it tests the ZK-mode-only AutoTopicReationManager.