KAFKA-18384 Remove ZkAlterPartitionManager#18364
Merged
mimaison merged 4 commits intoapache:trunkfrom Jan 7, 2025
Merged
Conversation
# Conflicts: # core/src/main/scala/kafka/server/KafkaServer.scala
mimaison
reviewed
Jan 6, 2025
Member
mimaison
left a comment
mimaison
left a comment
There was a problem hiding this comment.
Thanks for the PR. I left a suggestion.
| import org.junit.jupiter.api.Test | ||
| import org.mockito.ArgumentMatchers | ||
| import org.mockito.ArgumentMatchers.{any, anyBoolean, anyInt, anyLong, anyString} | ||
| import org.mockito.ArgumentMatchers.{any, anyBoolean, anyInt, anyLong} |
Member
There was a problem hiding this comment.
Can you also remove the ZooKeeper bits in testIsrNotExpandedIfReplicaIsFencedOrShutdown()?
Member
|
We can also delete |
mimaison
reviewed
Jan 7, 2025
| if (kraft) { | ||
| addBrokerEpochToMockMetadataCache(metadataCache.asInstanceOf[KRaftMetadataCache], replicas) | ||
| } | ||
| val metadataCache: MetadataCache = mock(classOf[KRaftMetadataCache]) |
Member
There was a problem hiding this comment.
We can use KRaftMetadataCache as the type so we don't need the multiple asInstanceOf calls later
Collaborator
Author
|
Thanks for @mimaison review, addressed all comments :) |
mimaison
pushed a commit
that referenced
this pull request
Jan 7, 2025
Reviewers: Mickael Maison <mickael.maison@gmail.com>
Member
|
Applied to 4.0: 5bcbf24 |
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Jan 8, 2025
…og-compaction-write-record-v2 * apache-github/trunk: (34 commits) MINOR: Bump year to 2025 in NOTICE file (apache#18427) KAFKA-18411 Remove ZkProducerIdManager (apache#18413) KAFKA-18408 tweak the 'tag' field for BrokerHeartbeatRequest.json, BrokerRegistrationChangeRecord.json and RegisterBrokerRecord.json (apache#18421) KAFKA-18414 Remove KRaftRegistrationResult (apache#18401) KAFKA-17921 Support SASL_PLAINTEXT protocol with java.security.auth.login.config (apache#17671) KAFKA-18384 Remove ZkAlterPartitionManager (apache#18364) KAFKA-10790: Add deadlock detection to producer#flush (apache#17946) KAFKA-18412: Remove EmbeddedZookeeper (apache#18399) MINOR : Improve Exception log in NotEnoughReplicasException(apache#12394) MINOR: Improve PlaintextAdminIntegrationTest#testConsumerGroups (apache#18409) MINOR: Remove unused local variable (apache#18410) MINOR: Remove RaftManager.maybeDeleteMetadataLogDir and AutoTopicCreationManagerTest.scala (apache#17365) KAFKA-18368 Remove TestUtils#MockZkConnect and remove zkConnect from TestUtils#createBrokerConfig (apache#18352) MINOR: Update Consumer group timeout default to 30 sec (apache#16406) MINOR: Fix typo in CommitRequestManager (apache#18407) MINOR: cleanup JavaDocs for deprecation warnings (apache#18402) KAFKA-18303; Update ShareCoordinator to use new record format (apache#18396) MINOR: Update Consumer and Producer JavaDocs for committing offsets (apache#18336) KAFKA-16446: Improve controller event duration logging (apache#15622) KAFKA-18388 test-kraft-server-start.sh should use log4j2.yaml (apache#18370) ...
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
Reviewers: Mickael Maison <mickael.maison@gmail.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
Reviewers: Mickael Maison <mickael.maison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/KAFKA-18384
Committer Checklist (excluded from commit message)