KAFKA-18368 Remove TestUtils#MockZkConnect and remove zkConnect from TestUtils#createBrokerConfig by m1a2st · Pull Request #18352 · apache/kafka

m1a2st · 2024-12-30T13:06:26Z

as title

Committer Checklist (excluded from commit message)

Verify design and implementation
Verify test coverage and CI build status
Verify documentation (including upgrade notes)

m1a2st · 2024-12-30T14:06:57Z

This PR should wait for KAFKA-18730

chia7712

@m1a2st thanks for this patch!

chia7712 · 2024-12-30T14:41:29Z

  private def createTopic(topic: String, numPartitions: Int, leader: Int): Unit = {
    val assignment = (0 until numPartitions).map { i => i -> Seq(leader) }.toMap
-    TestUtils.createTopic(null, topic, assignment, servers)
+    val adminZkClient = new AdminZkClient(null)


this test is disabled, so we can just comment the code TestUtils.createTopic(null, topic, assignment, servers)

chia7712 · 2024-12-30T14:48:25Z

@@ -173,14 +173,14 @@ class KafkaApisTest extends Logging {
                      overrideProperties: Map[String, String] = Map.empty,
                      featureVersions: Seq[FeatureVersion] = Seq.empty): KafkaApis = {
    val properties = if (raftSupport) {


Could you please remove raftSupport as well?

# Conflicts: # core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala

chia7712

@m1a2st thanks for update. This PR removes several test cases. We should carefully review each case to determine if it's exclusively related to ZooKeeper or if it should be rewritten with KRaft. If a more thorough investigation is required, we can create a follow-up issue to address the removal of the raftSupport flag.

chia7712 · 2024-12-30T17:47:15Z

  }

+  @Test
+  def testEnableDefaultUncleanLeaderElection(): Unit = {


we did not have such test case before?

chia7712 · 2024-12-30T17:49:44Z

@@ -614,136 +288,12 @@ class KafkaApisTest extends Logging {
    assertEquals(cgConfigs.size, configs.size)
  }

-  @Test
-  def testAlterConfigsClientMetrics(): Unit = {


why to remove this test case? Does this scenario belong to zk only?

m1a2st · 2024-12-31T00:51:46Z

Thanks for @chia7712 comment, I open a Jira to trace it.
https://issues.apache.org/jira/browse/KAFKA-18380

chia7712 · 2025-01-04T15:20:13Z

@m1a2st could you please check the failed tests?

m1a2st · 2025-01-04T15:21:59Z

@chia7712, the fail test will deal in this #18354

chia7712 · 2025-01-04T15:34:05Z

@m1a2st could you please disable the failed tests if they will be handled by #18354

chia7712 · 2025-01-06T20:14:18Z

    )
  }

+  @Disabled("KAFKA-18730")


typo: KAFKA-18370

chia7712 · 2025-01-06T20:14:22Z

    verify(mockBlockingSend).sendRequest(any())
  }

+  @Disabled("KAFKA-18730")


chia7712 · 2025-01-06T20:14:25Z

    assertEquals(3, mockNetwork.fetchCount)
  }

+  @Disabled("KAFKA-18730")


chia7712 · 2025-01-06T20:14:28Z

               "Expected " + t2p1 + " to truncate to offset 172 (truncation offsets: " + truncateToCapture.getAllValues + ")")
  }

+  @Disabled("KAFKA-18730")


chia7712 · 2025-01-06T20:14:30Z

               " (truncation offsets: " + truncateToCapture.getAllValues + ")")
  }

+  @Disabled("KAFKA-18730")


…TestUtils#createBrokerConfig (#18352) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>

…og-compaction-write-record-v2 * apache-github/trunk: (34 commits) MINOR: Bump year to 2025 in NOTICE file (apache#18427) KAFKA-18411 Remove ZkProducerIdManager (apache#18413) KAFKA-18408 tweak the 'tag' field for BrokerHeartbeatRequest.json, BrokerRegistrationChangeRecord.json and RegisterBrokerRecord.json (apache#18421) KAFKA-18414 Remove KRaftRegistrationResult (apache#18401) KAFKA-17921 Support SASL_PLAINTEXT protocol with java.security.auth.login.config (apache#17671) KAFKA-18384 Remove ZkAlterPartitionManager (apache#18364) KAFKA-10790: Add deadlock detection to producer#flush (apache#17946) KAFKA-18412: Remove EmbeddedZookeeper (apache#18399) MINOR : Improve Exception log in NotEnoughReplicasException(apache#12394) MINOR: Improve PlaintextAdminIntegrationTest#testConsumerGroups (apache#18409) MINOR: Remove unused local variable (apache#18410) MINOR: Remove RaftManager.maybeDeleteMetadataLogDir and AutoTopicCreationManagerTest.scala (apache#17365) KAFKA-18368 Remove TestUtils#MockZkConnect and remove zkConnect from TestUtils#createBrokerConfig (apache#18352) MINOR: Update Consumer group timeout default to 30 sec (apache#16406) MINOR: Fix typo in CommitRequestManager (apache#18407) MINOR: cleanup JavaDocs for deprecation warnings (apache#18402) KAFKA-18303; Update ShareCoordinator to use new record format (apache#18396) MINOR: Update Consumer and Producer JavaDocs for committing offsets (apache#18336) KAFKA-16446: Improve controller event duration logging (apache#15622) KAFKA-18388 test-kraft-server-start.sh should use log4j2.yaml (apache#18370) ...

…TestUtils#createBrokerConfig (apache#18352) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>

github-actions Bot added triage PRs from the community core Kafka Broker tests Test fixes (including flaky tests) labels Dec 30, 2024

chia7712 reviewed Dec 30, 2024

View reviewed changes

m1a2st force-pushed the KAFKA-18368 branch from 18654ee to 1703b00 Compare December 30, 2024 15:45

m1a2st added 8 commits December 31, 2024 00:15

remove code

587e3ae

remove code

4b9d596

remove code

55f6061

remove code

ca409fe

remove zookeeper test

d4a6958

addressed by comments

1cf353e

wip

c3e5c0b

wip

37b3eb1

m1a2st force-pushed the KAFKA-18368 branch from 1703b00 to 37b3eb1 Compare December 30, 2024 16:27

m1a2st added 8 commits December 31, 2024 00:42

API ENVELOPE with version 0 is not enabled

63f4dfd

remove mock ZkClient test

f2106b9

remove ZkMetadataCache test

ba0c1be

remove unsupported api test

cf93c9b

remove request channel test

c46da44

remove request channel test

655c19a

wip

471c528

Merge branch 'trunk' into KAFKA-18368

1d43052

# Conflicts: # core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala

chia7712 reviewed Dec 30, 2024

View reviewed changes

m1a2st added 4 commits December 31, 2024 08:13

revert unused change

b64df30

revert unused change

a177899

revert unused change

cedbe04

revert unused change

1567f5c

github-actions Bot removed the triage PRs from the community label Dec 31, 2024

chia7712 added the ci-approved label Jan 1, 2025

m1a2st added 2 commits January 1, 2025 21:30

Merge branch 'trunk' into KAFKA-18368

7039494

remove some unused method

d182dc0

github-actions Bot added tools performance labels Jan 1, 2025

disabled test in ReplicaFetcherThreadTest

9347871

chia7712 reviewed Jan 6, 2025

View reviewed changes

addressed by comments

93366e8

chia7712 approved these changes Jan 7, 2025

View reviewed changes

chia7712 merged commit d874aa4 into apache:trunk Jan 7, 2025

chia7712 pushed a commit that referenced this pull request Jan 7, 2025

KAFKA-18368 Remove TestUtils#MockZkConnect and remove zkConnect from …

3061e9c

…TestUtils#createBrokerConfig (#18352) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>

pranavt84 pushed a commit to pranavt84/kafka that referenced this pull request Jan 27, 2025

KAFKA-18368 Remove TestUtils#MockZkConnect and remove zkConnect from …

87a6ca9

…TestUtils#createBrokerConfig (apache#18352) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>

manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025

KAFKA-18368 Remove TestUtils#MockZkConnect and remove zkConnect from …

091b3ac

…TestUtils#createBrokerConfig (apache#18352) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>

Conversation

m1a2st commented Dec 30, 2024

Committer Checklist (excluded from commit message)

Uh oh!

m1a2st commented Dec 30, 2024

Uh oh!

chia7712 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chia7712 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

m1a2st commented Dec 31, 2024

Uh oh!

chia7712 commented Jan 4, 2025

Uh oh!

m1a2st commented Jan 4, 2025

Uh oh!

chia7712 commented Jan 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants