Skip to content

MINOR: cleanup JavaDocs for deprecation warnings#18402

Merged
clolov merged 2 commits intoapache:trunkfrom
mjsax:minor-javadoc-deprecation
Jan 7, 2025
Merged

MINOR: cleanup JavaDocs for deprecation warnings#18402
clolov merged 2 commits intoapache:trunkfrom
mjsax:minor-javadoc-deprecation

Conversation

@mjsax
Copy link
Copy Markdown
Member

@mjsax mjsax commented Jan 6, 2025

No description provided.

bbejeck
bbejeck approved these changes Jan 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Jan 6, 2025

Re-running Java 23:

Found 3 test failures:
FAILED ❌ TransactionsTest > "testBumpTransactionalEpochWithTV2Disabled(String, String, boolean).quorum=kraft, groupProtocol=classic, isTV2Enabled=false"
FAILED ❌ MetricsDuringTopicCreationDeletionTest > "testMetricsDuringTopicCreateDelete(String).quorum=kraft"
FAILED ❌ PlaintextAdminIntegrationTest > testConsumerGroupsDeprecatedConsumerGroupState(String, String).quorum=kraft.groupProtocol=consumer
Found 1 flaky test failures:
FLAKY ⚠️  AbstractCoordinatorTest > testWakeupAfterSyncGroupReceivedExternalCompletion()

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Jan 7, 2025

Java 23 (again TransactionsTest... Lets give it a third try)

FAILED ❌ PlaintextConsumerTest > testCoordinatorFailover(String, String).quorum=kraft.groupProtocol=classic
FAILED ❌ ConsumerProtocolMigrationTest > testDowngradeFromEmptyConsumerToClassicGroupWithDowngradePolicy [1] Type=Raft-Isolated, MetadataVersion=4.0-IV3,BrokerSecurityProtocol=PLAINTEXT,BrokerListenerName=ListenerName(EXTERNAL),ControllerSecurityProtocol=PLAINTEXT,ControllerListenerName=ListenerName(CONTROLLER)
FAILED ❌ TransactionsTest > "testBumpTransactionalEpochWithTV2Disabled(String, String, boolean).quorum=kraft, groupProtocol=classic, isTV2Enabled=false"
Found 1 flaky test failures:
FLAKY ⚠️  AbstractCoordinatorTest > testWakeupAfterSyncGroupReceivedExternalCompletion()

@clolov
Copy link
Copy Markdown
Contributor

clolov commented Jan 7, 2025

Third time's the charm 😊 - merging!

@clolov clolov merged commit 738bd92 into apache:trunk Jan 7, 2025
@mjsax mjsax deleted the minor-javadoc-deprecation branch January 8, 2025 02:55
mjsax added a commit that referenced this pull request Jan 8, 2025
@mjsax
MINOR: cleanup JavaDocs for deprecation warnings (#18402)
eaab8b6 
Reviewers: Bill Bejeck <bbejeck@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Jan 8, 2025

Thanks. Cherry-picked to 4.0 branch.

ijuma added a commit to ijuma/kafka that referenced this pull request Jan 8, 2025
@ijuma
Merge remote-tracking branch 'apache-github/trunk' into kafka-13093-l…
6689ade 
…og-compaction-write-record-v2

* apache-github/trunk: (34 commits)
  MINOR: Bump year to 2025 in NOTICE file (apache#18427)
  KAFKA-18411 Remove ZkProducerIdManager (apache#18413)
  KAFKA-18408 tweak the 'tag' field for BrokerHeartbeatRequest.json, BrokerRegistrationChangeRecord.json and RegisterBrokerRecord.json (apache#18421)
  KAFKA-18414 Remove KRaftRegistrationResult (apache#18401)
  KAFKA-17921 Support SASL_PLAINTEXT protocol with java.security.auth.login.config (apache#17671)
  KAFKA-18384 Remove ZkAlterPartitionManager (apache#18364)
  KAFKA-10790: Add deadlock detection to producer#flush (apache#17946)
  KAFKA-18412: Remove EmbeddedZookeeper (apache#18399)
  MINOR : Improve Exception log in NotEnoughReplicasException(apache#12394)
  MINOR: Improve PlaintextAdminIntegrationTest#testConsumerGroups (apache#18409)
  MINOR: Remove unused local variable (apache#18410)
  MINOR: Remove RaftManager.maybeDeleteMetadataLogDir and AutoTopicCreationManagerTest.scala (apache#17365)
  KAFKA-18368 Remove TestUtils#MockZkConnect and remove zkConnect from TestUtils#createBrokerConfig (apache#18352)
  MINOR: Update Consumer group timeout default to 30 sec (apache#16406)
  MINOR: Fix typo in CommitRequestManager (apache#18407)
  MINOR: cleanup JavaDocs for deprecation warnings (apache#18402)
  KAFKA-18303; Update ShareCoordinator to use new record format (apache#18396)
  MINOR: Update Consumer and Producer JavaDocs for committing offsets (apache#18336)
  KAFKA-16446: Improve controller event duration logging (apache#15622)
  KAFKA-18388 test-kraft-server-start.sh should use log4j2.yaml (apache#18370)
  ...
manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
@mjsax @manoj-mathivanan
MINOR: cleanup JavaDocs for deprecation warnings (apache#18402)
8afdd3e 
Reviewers: Bill Bejeck <bbejeck@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
frankvicky
frankvicky reviewed Mar 1, 2025
View reviewed changes
Comment thread streams/src/main/java/org/apache/kafka/streams/kstream/JoinWindows.java
* @throws IllegalArgumentException if the {@code afterWindowEnd} is negative or can't be represented as {@code long milliseconds}
* @throws IllegalStateException if {@link #grace(Duration)} is called after {@link #ofTimeDifferenceAndGrace(Duration, Duration)} or {@link #ofTimeDifferenceWithNoGrace(Duration)}
* @deprecated since 3.0. Use {@link #ofTimeDifferenceAndGrace(Duration, Duration)} instead
* @deprecated Since 3.0. Use {@link #ofTimeDifferenceAndGrace(Duration, Duration)} instead.
Copy link
Copy Markdown
Contributor

@frankvicky frankvicky Mar 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mjsax
I notice that this has been deprecated since 3.0 which is passed one year since it was deprecated.
Do we need to delete this one in 4.0?

Copy link
Copy Markdown
Member Author

@mjsax mjsax Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for paying attention! We decided to keep this old API on purpose and not remove with 4.0.

Cf https://issues.apache.org/jira/browse/KAFKA-13813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frankvicky frankvicky frankvicky left review comments

@bbejeck bbejeck bbejeck approved these changes

@chia7712 chia7712 chia7712 approved these changes

Assignees

No one assigned

Labels

clients consumer docs small Small PRs streams tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mjsax @clolov @bbejeck @chia7712 @frankvicky