KAFKA-7502: Cleanup KTable materialization logic in a single place (filter)#6453
Merged
guozhangwang merged 5 commits intoapache:trunkfrom Mar 28, 2019
Merged
Conversation
dongjinleekr
changed the title
Member
|
Java 8 passed, Java 11 failed. Results already cleaned up. retest this please |
Member
|
ping @guozhangwang @mjsax @vvcephei @ableegoldman for reviews |
bbejeck
approved these changes
Mar 21, 2019
Member
bbejeck
left a comment
bbejeck
left a comment
There was a problem hiding this comment.
Thanks @dongjinleekr, I've made a pass over overall this looks good to me. I just have a couple of minor comments.
bbejeck
reviewed
Mar 21, 2019
Member
bbejeck
left a comment
bbejeck
left a comment
There was a problem hiding this comment.
Actually meant to hit comment first.
Thanks @dongjinleekr, I've made a pass over overall this looks good to me. I just have a couple of minor comments.
bbejeck
reviewed
Mar 24, 2019
Member
bbejeck
left a comment
bbejeck
left a comment
There was a problem hiding this comment.
Thanks for the updates @dongjinleekr looks good to me.
However, the build failure is related.
Take a look at line 314 in KTableImpl the TableProcessorNode constructor parameters need adjusting.
1. TableProcessorNode: remove materializedInternal, use storeBuilder instead. 2. Instantiate StoreBuilder in KTableImpl#[doFilter, doMapValues, doTransformValues], instead of TableProcessorNode#init.
…with other methods.)
… 2. Reformat+trivial changes on TableProcessorNode.java.
dongjinleekr
force-pushed
the
feature/KAFKA-7502-filter
branch
from
dac3d7a to
e44aa46
Compare
Contributor
Author
|
@bbejeck I'm sorry, I omitted a line from commit; here is the fix with rebasing onto the latest trunk. |
bbejeck
approved these changes
Mar 25, 2019
Member
bbejeck
left a comment
bbejeck
left a comment
There was a problem hiding this comment.
Thanks for the updates @dongjinleekr, LGTM
Member
|
call for second review @guozhangwang |
Contributor
guozhangwang
left a comment
guozhangwang
left a comment
There was a problem hiding this comment.
Left two comments, otherwise LGTM!
Contributor
|
Jenkins failure: https://issues.apache.org/jira/browse/KAFKA-7965 |
Contributor
|
retest this please |
Contributor
|
Thanks @dongjinleekr ! |
This was referenced Mar 28, 2019
bbejeck
pushed a commit
that referenced
this pull request
Mar 29, 2019
jarekr
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Apr 18, 2019
* apache/trunk: KAFKA-8030: Fix flaky tests in TopicCommandWithAdminClientTest fix compile error for example (apache#6526) MINOR: Comment spelling nit MINOR: Optimize ConnectionStressWorker KAFKA-8034: Use automatic RPC generation in DeleteTopics MINOR: Move KTable source topic for changelog to optimization framework (apache#6500) KAFKA-7502: Cleanup KTable materialization logic in a single place (doMapValues) (apache#6520) Cleanup KTableImpl#doTransformValues (apache#6519) MINOR: Streams input topic corrected (apache#6513) MINOR: WorkerUtils#abort: fix bug in abort logic (apache#6516) KAFKA-7502: Cleanup KTable materialization logic in a single place (filter) (apache#6453) MINOR: Fix some spelling corrections in comments (apache#6507) KAFKA-3522: Add RocksDBTimestampedSegmentedBytesStore (apache#6186) MINOR: Add 2.2.0 upgrade instructions (apache#6501)
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…ilter) (apache#6453) This PR is a follow-up of apache#6174, which handles doFilter / doMapValues / doTransformValues methods. Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <guozhang@confluent.io>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
This PR is a follow-up of apache#6174 and apache#6453, which cleans up KTableImpl#doTransformValues method. Reviewers: Bill Bejeck <bbejeck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #6174, which handles
doFiltermethod.cc/ @guozhangwang @bbejeck
Committer Checklist (excluded from commit message)