MINOR: Move KTable source topic for changelog to optimization framework#6500
Merged
bbejeck merged 3 commits intoapache:trunkfrom Mar 29, 2019
Conversation
Member
Author
|
ping @guozhangwang @mjsax @vvcephei @ableegoldman for reviews. |
bbejeck
commented
Mar 25, 2019
Member
Author
There was a problem hiding this comment.
This is the optimization and we only apply it for materialized KTable objects.
guozhangwang
approved these changes
Mar 27, 2019
Contributor
guozhangwang
left a comment
guozhangwang
left a comment
There was a problem hiding this comment.
One nit, otherwise LGTM.
Feel free to merge afterwards.
Contributor
There was a problem hiding this comment.
nit: we can move this line up outside the if condition and remove else?
bbejeck
force-pushed
the
MINOR_move_ktable_materialization_to_internal_streams_builder
branch
from
9847c1a to
0fd9b6a
Compare
Member
Author
|
Addressed comments and rebased with trunk, waiting for Jenkins to complete for merging |
bbejeck
deleted the
MINOR_move_ktable_materialization_to_internal_streams_builder
branch
Member
Author
|
Merged #6500 into trunk. |
jarekr
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Apr 18, 2019
* apache/trunk: KAFKA-8030: Fix flaky tests in TopicCommandWithAdminClientTest fix compile error for example (apache#6526) MINOR: Comment spelling nit MINOR: Optimize ConnectionStressWorker KAFKA-8034: Use automatic RPC generation in DeleteTopics MINOR: Move KTable source topic for changelog to optimization framework (apache#6500) KAFKA-7502: Cleanup KTable materialization logic in a single place (doMapValues) (apache#6520) Cleanup KTableImpl#doTransformValues (apache#6519) MINOR: Streams input topic corrected (apache#6513) MINOR: WorkerUtils#abort: fix bug in abort logic (apache#6516) KAFKA-7502: Cleanup KTable materialization logic in a single place (filter) (apache#6453) MINOR: Fix some spelling corrections in comments (apache#6507) KAFKA-3522: Add RocksDBTimestampedSegmentedBytesStore (apache#6186) MINOR: Add 2.2.0 upgrade instructions (apache#6501)
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…rk (apache#6500) Since we've added Kafka Streams optimizations in 2.1 we need to move the optimization for source KTable nodes (use source topic as changelog) to the optimization framework. Reviewers: Guozhang Wang <wangguoz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we've added Kafka Streams optimizations in
2.1we need to move the optimization for sourceKTablenodes (use source topic as changelog) to the optimization framework.Updated streams tests.
Committer Checklist (excluded from commit message)