KAFKA-7502: Cleanup KTable materialization logic in a single place (doMapValues)#6520
Merged
bbejeck merged 3 commits intoapache:trunkfrom Mar 29, 2019
Merged
Conversation
1. TableProcessorNode: remove materializedInternal, use storeBuilder instead. 2. Instantiate StoreBuilder in KTableImpl#[doFilter, doMapValues, doTransformValues], instead of TableProcessorNode#init.
… 2. Reformat+trivial changes on TableProcessorNode.java.
dongjinleekr
changed the title
Contributor
Author
Contributor
Contributor
Author
|
retest this please |
Member
|
Merged #6520 into trunk. |
jarekr
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Apr 18, 2019
* apache/trunk: KAFKA-8030: Fix flaky tests in TopicCommandWithAdminClientTest fix compile error for example (apache#6526) MINOR: Comment spelling nit MINOR: Optimize ConnectionStressWorker KAFKA-8034: Use automatic RPC generation in DeleteTopics MINOR: Move KTable source topic for changelog to optimization framework (apache#6500) KAFKA-7502: Cleanup KTable materialization logic in a single place (doMapValues) (apache#6520) Cleanup KTableImpl#doTransformValues (apache#6519) MINOR: Streams input topic corrected (apache#6513) MINOR: WorkerUtils#abort: fix bug in abort logic (apache#6516) KAFKA-7502: Cleanup KTable materialization logic in a single place (filter) (apache#6453) MINOR: Fix some spelling corrections in comments (apache#6507) KAFKA-3522: Add RocksDBTimestampedSegmentedBytesStore (apache#6186) MINOR: Add 2.2.0 upgrade instructions (apache#6501)
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…oMapValues) (apache#6520) * Move materialization logic from TableProcessorNode to KTableImpl 1. TableProcessorNode: remove materializedInternal, use storeBuilder instead. 2. Instantiate StoreBuilder in KTableImpl#[doFilter, doMapValues, doTransformValues], instead of TableProcessorNode#init. * Cleanup KTableImpl#doMapValues * 1. Add TableProcessorNode(String, ProcessorParameters, StoreBuilder). 2. Reformat+trivial changes on TableProcessorNode.java.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the final part of KAFKA-7502, which cleans up
KTableImpl#doMapValuesmethod. (follow up of #6174, #6453, and #6519)Committer Checklist (excluded from commit message)