Skip to content

MINOR: Add 2.2.0 upgrade instructions#6501

Merged
mjsax merged 3 commits intoapache:trunkfrom
mjsax:add-220-upgrade-instructions
Mar 26, 2019
Merged

MINOR: Add 2.2.0 upgrade instructions#6501
mjsax merged 3 commits intoapache:trunkfrom
mjsax:add-220-upgrade-instructions

Conversation

@mjsax
Copy link
Copy Markdown
Member

@mjsax mjsax commented Mar 25, 2019

No description provided.

@mjsax mjsax requested review from hachikuji and ijuma March 25, 2019 20:23
Copy link
Copy Markdown
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one comment.

Comment thread docs/upgrade.html
It is still possible to downgrade at this point if there are any problems.
</li>
<li> Once the cluster's behavior and performance has been verified, bump the protocol version by editing
<code>inter.broker.protocol.version</code> and setting it to 2.2.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly we want to refer users to the note for 2.1 on t he impact of changing this for downgrades?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by this? As I copied the 2.1 instructions, I am not sure what information is missing?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you change the inter.broker.protocol.version to the latest, downgrades are generally not supported. There is a note below for 2.1. See line 75.

Copy link
Copy Markdown
Contributor

@hachikuji hachikuji Mar 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, the next entry is already clear. Maybe it's fine. I guess the question is whether we should make this the official rule or if it was an exception for 2.1.

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Mar 26, 2019

Updated this.

Comment thread docs/upgrade.html Outdated

<h4><a id="upgrade_2_2_0" href="#upgrade_2_2_0">Upgrading from 0.8.x, 0.9.x, 0.10.0.x, 0.10.1.x, 0.10.2.x, 0.11.0.x, 1.0.x, 1.1.x, 2.0.x or 2.1.x to 2.2.0</a></h4>

<p><b>Note that 2.2.x contains a change to the internal schema used to store consumer offsets. Once the upgrade is
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not quite right. The change was in 2.1.x. I would suggest this:

If you are upgrading from a version prior to 2.1.x, please see the note below about the change to the schema used to store consumer offsets. Once you have changed the inter.broker.protocol.version to the latest version, it will not be possible to downgrade to a version prior to 2.1.

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Mar 26, 2019

Thanks @hachikuji! Updated this PR.

Copy link
Copy Markdown
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@mjsax mjsax force-pushed the add-220-upgrade-instructions branch from 227e307 to aa2753f Compare March 26, 2019 16:37
@mjsax mjsax merged commit f47b849 into apache:trunk Mar 26, 2019
mjsax added a commit that referenced this pull request Mar 26, 2019
Reviewers: Jason Gustafson <jason@confluent.io>
@mjsax mjsax deleted the add-220-upgrade-instructions branch March 26, 2019 16:42
@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Mar 26, 2019

Merged to trunk and cherry-picked to 2.2.

jarekr pushed a commit to confluentinc/kafka that referenced this pull request Apr 18, 2019
* apache/trunk:
  KAFKA-8030: Fix flaky tests in TopicCommandWithAdminClientTest
  fix compile error for example (apache#6526)
  MINOR: Comment spelling nit
  MINOR: Optimize ConnectionStressWorker
  KAFKA-8034: Use automatic RPC generation in DeleteTopics
  MINOR: Move KTable source topic for changelog to optimization framework (apache#6500)
  KAFKA-7502: Cleanup KTable materialization logic in a single place (doMapValues) (apache#6520)
  Cleanup KTableImpl#doTransformValues (apache#6519)
  MINOR: Streams input topic corrected (apache#6513)
  MINOR: WorkerUtils#abort: fix bug in abort logic (apache#6516)
  KAFKA-7502: Cleanup KTable materialization logic in a single place (filter) (apache#6453)
  MINOR: Fix some spelling corrections in comments (apache#6507)
  KAFKA-3522: Add RocksDBTimestampedSegmentedBytesStore (apache#6186)
  MINOR: Add 2.2.0 upgrade instructions (apache#6501)
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
Reviewers: Jason Gustafson <jason@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants