MINOR: Update stream documentation by showuon · Pull Request #8622 · apache/kafka

showuon · 2020-05-06T03:27:09Z

fix broken links
rephrase a sentence
update the version number

Committer Checklist (excluded from commit message)

Verify design and implementation
Verify test coverage and CI build status
Verify documentation (including upgrade notes)

1. fix broken links 2. rephrase a sentence 3. update the version number

showuon · 2020-05-06T03:28:48Z

    <p>
        Upgrading from any older version to {{fullDotVersion}} is possible: you will need to do two rolling bounces, where during the first rolling bounce phase you set the config <code>upgrade.from="older version"</code>
-        (possible values are <code>"0.10.0" - "2.3"</code>) and during the second you remove it. This is required to safely upgrade to the new cooperative rebalancing protocol of the embedded consumer. Note that you will remain using the old eager
+        (possible values are <code>"0.10.0" - "2.4"</code>) and during the second you remove it. This is required to safely upgrade to the new cooperative rebalancing protocol of the embedded consumer. Note that you will remain using the old eager


2.4 is now the possible old version value

I think 2.4 already launches the incremental rebalancing, cc @ableegoldman

I think this change is ok as it describes the rolling upgrades from an older version. But we should @ableegoldman to confirm.

@showuon Boyang is right, there is no upgrade.from config for 2.4 since that's when cooperative rebalancing was enabled. So if you upgrade to 2.5 from any version lower than 2.4, you will need to go through this upgrade path and set the config.

Thank you, @ableegoldman @abbccdda @bbejeck , I've reverted back this version to 2.3 now in this commit 460768e. Thank you very much!

showuon · 2020-05-06T03:30:25Z

        that allows to aggregate multiple streams in a single operation.
        Cogrouped streams can also be windowed before they are aggregated.
-        We refer to the <a href="/{{version}}/documentation/streams/developer-guide/dsl-api.html">developer guide</a> for more details.
+        Please refer to the <a href="/{{version}}/documentation/streams/developer-guide/dsl-api.html">developer guide</a> for more details.


Rephrase this sentence.
Before: We refer to the developer guide for more details.
After: Please refer to the developer guide for more details.

showuon · 2020-05-06T03:32:16Z

        The task ids, store names and processor names are no longer in the sensor metrics names, but instead are added as tags of the sensors to achieve consistent metrics hierarchy.
        As a result you may need to make corresponding code changes on your metrics reporting and monitoring tools when upgrading to 1.0.0.
-        Detailed metrics sensor can be found in the <a href="#kafka_streams_monitoring">Streams Monitoring</a> section.
+        Detailed metrics sensor can be found in the <a href="/{{version}}/documentation/#kafka_streams_monitoring">Streams Monitoring</a> section.


#kafka_streams_monitoring is located in /documentation, not the current path (i.e. documentation/streams/upgrade-guide)

showuon · 2020-05-07T03:40:44Z

Hi @bbejeck , could you please review this small PR? Thanks.

bbejeck · 2020-05-07T14:24:54Z

@showuon thanks for the contribution, I'll take a look soon

showuon · 2020-05-08T01:00:27Z

Thanks, @bbejeck , take your time.

…oc_update

showuon · 2020-05-14T11:06:17Z

        </div>
        <div class="section" id="testing-a-streams-app">
-            <a class="headerlink" href="#testing-a-streams-app" title="Permalink to this headline"><h2>Testing a Streams application</h2></a>
+            <h2><a class="headerlink" href="#testing-a-streams-app" title="Permalink to this headline">Testing a Streams application</a></h2>


Currently, the TESTING A STREAMS APPLICATION header is in blue, which is different from others. Turns out that it's because we put <h2> tag inside <a>, and cause to apply the wrong css format.

showuon · 2020-05-14T11:07:05Z

      <p>If there are other instances of this stream processing application running elsewhere (e.g., on another machine), Kafka
        Streams transparently re-assigns tasks from the existing instances to the new instance that you just started.
-        For more information, see <a class="reference internal" href="../architecture.html#streams_architecture_tasks"><span class="std std-ref">Stream Partitions and Tasks</span></a> and <a class="reference internal" href="../architecture.html#streams-architecture-threads"><span class="std std-ref">Threading Model</span></a>.</p>
+        For more information, see <a class="reference internal" href="../architecture.html#streams_architecture_tasks"><span class="std std-ref">Stream Partitions and Tasks</span></a> and <a class="reference internal" href="../architecture.html#streams_architecture_threads"><span class="std std-ref">Threading Model</span></a>.</p>


fix the broken link from wrong href="../architecture.html#streams-architecture-threads" to href="../architecture.html#streams_architecture_threads" (the one with underscore)

showuon · 2020-05-14T11:07:43Z


      <div class="section" id="testing-a-streams-app">
-          <a class="headerlink" href="#testing-a-streams-app" title="Permalink to this headline"><h2>Testing a Streams application</a></h2>
+          <h2><a class="headerlink" href="#testing-a-streams-app" title="Permalink to this headline">Testing a Streams application</a></h2>


wrong HTML formatting. The starting/ending <h2> tag and <a> tag are mixed places.

showuon · 2020-05-14T11:08:26Z

          <p>You can run Java applications that use the Kafka Streams library without any additional configuration or requirements. Kafka Streams
              also provides the ability to receive notification of the various states of the application. The ability to monitor the runtime
-              status is discussed in <a class="reference internal" href="../monitoring.html#streams-monitoring"><span class="std std-ref">the monitoring guide</span></a>.</p>
+              status is discussed in <a class="reference internal" href="/documentation/#kafka_streams_monitoring"><span class="std std-ref">the monitoring guide</span></a>.</p>


Fix the broken link.

showuon · 2020-05-14T11:10:22Z

Hi @bbejeck , I appended more fixs for the streams documents while I'm reading it. Please review it when available. Thank you.

abbccdda

Thanks for the patch! Overall LGTM, just a minor comment.

abbccdda · 2020-05-16T05:46:47Z

    <p>
        Upgrading from any older version to {{fullDotVersion}} is possible: you will need to do two rolling bounces, where during the first rolling bounce phase you set the config <code>upgrade.from="older version"</code>
-        (possible values are <code>"0.10.0" - "2.3"</code>) and during the second you remove it. This is required to safely upgrade to the new cooperative rebalancing protocol of the embedded consumer. Note that you will remain using the old eager
+        (possible values are <code>"0.10.0" - "2.4"</code>) and during the second you remove it. This is required to safely upgrade to the new cooperative rebalancing protocol of the embedded consumer. Note that you will remain using the old eager


I think 2.4 already launches the incremental rebalancing, cc @ableegoldman

showuon · 2020-05-16T08:17:14Z

Thanks @abbccdda , I'll wait for @ableegoldman 's confirmation to see if I have to revert this version back to 2.3. Thank you very much.

bbejeck

@showuon thanks for the contribution! LGTM. Once we get confirmation on the rolling upgrade section we can merge this.

I validated these changes by running asf-site locally.

Also, can you prepare an identical PR for https://github.com/apache/kafka-site/tree/asf-site/25 ? This is needed so the current live docs are updated. Thanks!

bbejeck · 2020-05-16T15:29:46Z

    <p>
        Upgrading from any older version to {{fullDotVersion}} is possible: you will need to do two rolling bounces, where during the first rolling bounce phase you set the config <code>upgrade.from="older version"</code>
-        (possible values are <code>"0.10.0" - "2.3"</code>) and during the second you remove it. This is required to safely upgrade to the new cooperative rebalancing protocol of the embedded consumer. Note that you will remain using the old eager
+        (possible values are <code>"0.10.0" - "2.4"</code>) and during the second you remove it. This is required to safely upgrade to the new cooperative rebalancing protocol of the embedded consumer. Note that you will remain using the old eager


I think this change is ok as it describes the rolling upgrades from an older version. But we should @ableegoldman to confirm.

showuon · 2020-05-18T02:29:25Z

No problem @bbejeck . PR to update the version 25 doc inkafka-site repo is ready: apache/kafka-site#265. Thank you.

…ancing after 2.4

ableegoldman · 2020-05-19T03:32:17Z

    <p>
        Upgrading from any older version to {{fullDotVersion}} is possible: you will need to do two rolling bounces, where during the first rolling bounce phase you set the config <code>upgrade.from="older version"</code>
-        (possible values are <code>"0.10.0" - "2.4"</code>) and during the second you remove it. This is required to safely upgrade to the new cooperative rebalancing protocol of the embedded consumer. Note that you will remain using the old eager
+        (possible values are <code>"0.10.0" - "2.3"</code>) and during the second you remove it. This is required to safely upgrade to the new cooperative rebalancing protocol of the embedded consumer. Note that you will remain using the old eager


@showuon Can we clarify that you only need to do this if you're upgrading from 2.3 or below? I know this seems implied by the fact that the config's possible values stop at 2.3 but there are always creative interpretations of seemingly obvious things 🙂

hi @ableegoldman , After reading the whole paragraph again, I think you're right.

(possible values are "0.10.0" - "2.3") and during the second you remove it. ....
This is required to safely upgrade to the new cooperative rebalancing protocol of the embedded consumer. ....
you can safely switch over to cooperative at any time once the entire group is on 2.4+ by removing the config value and bouncing.

So, Because we explicitly said since 2.4+, there'll be cooperative rebalancing protocol available, I think here we keep it as 2.3 is fine and correct.

Or do you have any other suggestion?
Thank you.

Can we just add a small qualifier in the first line?
you will need to do two rolling bounces --> if upgrading from 2.3 or below, you will need to do two rolling bounces

Thanks for suggestion, @ableegoldman , it makes it more clear! I've updated in this commit a3accf6. Thank you.

Awesome, thank you!

I've also updated in the kafka-site repo: apache/kafka-site@513a820. Thank you.

bbejeck · 2020-05-19T15:06:25Z

Thanks @showuon for the contribution!

bbejeck · 2020-05-19T15:06:42Z

Merged #8622 into trunk.

* 'trunk' of github.com:apache/kafka: MINOR: Increase gradle daemon’s heap size to 2g (apache#8700) KAFKA-9603: Do not turn on bulk loading for segmented stores on stand-by tasks (apache#8661) KAFKA-9859 / kafka-streams-application-reset tool doesn't take into account topics generated by KTable foreign key join operation (apache#8671) MINOR: Fix redundant typos in comments and javadocs (apache#8693) KAFKA-10010: Should make state store registration idempotent (apache#8681) KAFKA-10011: Remove task id from lockedTaskDirectories during handleLostAll (apache#8682) KAFKA-9992: Eliminate JavaConverters in EmbeddedKafkaCluster (apache#8673) KAFKA-6145: Add unit tests to verify fix of bug KAFKA-9173 (apache#8689) MINOR: Update stream documentation (apache#8622) MINOR: Small fixes in the documentation (apache#8623)

update stream documentation

e0cab36

1. fix broken links 2. rephrase a sentence 3. update the version number

showuon commented May 6, 2020

View reviewed changes

showuon changed the title ~~update stream documentation~~ MINOR: Update stream documentation May 6, 2020

bbejeck added docs streams labels May 7, 2020

showuon added 2 commits May 14, 2020 18:45

Merge branch 'trunk' of https://github.com/apache/kafka into stream_d…

c0e3a97

…oc_update

fix broken links and HTML format error

3165ae7

showuon commented May 14, 2020

View reviewed changes

abbccdda reviewed May 16, 2020

View reviewed changes

bbejeck approved these changes May 16, 2020

View reviewed changes

showuon mentioned this pull request May 18, 2020

MINOR: Update stream documentation for version 2.5 apache/kafka-site#265

Merged

revert back to version 2.3 since since 2.4, we have cooperative rebal…

460768e

…ancing after 2.4

ableegoldman reviewed May 19, 2020

View reviewed changes

addressing reviewer's comments

a3accf6

bbejeck merged commit 82fb6e9 into apache:trunk May 19, 2020

showuon deleted the stream_doc_update branch May 20, 2020 01:39

Conversation

showuon commented May 6, 2020

Committer Checklist (excluded from commit message)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bbejeck May 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

showuon commented May 7, 2020

Uh oh!

bbejeck commented May 7, 2020

Uh oh!

showuon commented May 8, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

showuon May 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

showuon commented May 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abbccdda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

showuon commented May 16, 2020

Uh oh!

bbejeck left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bbejeck May 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

showuon commented May 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ableegoldman May 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

showuon May 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bbejeck commented May 19, 2020

Uh oh!

bbejeck commented May 19, 2020

Uh oh!

Reviewers

Assignees

Labels

bbejeck May 16, 2020 •

edited

Loading

showuon May 14, 2020 •

edited

Loading

showuon commented May 14, 2020 •

edited

Loading

bbejeck left a comment •

edited

Loading

bbejeck May 16, 2020 •

edited

Loading

showuon commented May 18, 2020 •

edited

Loading

ableegoldman May 19, 2020 •

edited

Loading

showuon May 19, 2020 •

edited

Loading