MINOR: Small fixes in the documentation#8623
Merged
kkonstantine merged 7 commits intoapache:trunkfrom May 19, 2020
Merged
Conversation
1. fix broken links 2. remove redundant sentences 3. fix content format issue
showuon
commented
May 6, 2020
showuon
commented
May 6, 2020
| <pre class="brush: text;"> | ||
| leader.replication.throttled.rate | ||
| follower.replication.throttled.rate | ||
| </pre> |
Member
Author
There was a problem hiding this comment.
Fix the wrong indent issue on UI
showuon
commented
May 6, 2020
showuon
commented
May 6, 2020
showuon
commented
May 6, 2020
showuon
commented
May 6, 2020
showuon
commented
May 6, 2020
Member
Author
|
Hi @kkonstantine , could you please review this small PR? Thanks. |
Member
Author
|
Hi @ijuma , could you please review this small PR? Thanks. |
showuon
commented
May 15, 2020
showuon
commented
May 15, 2020
showuon
commented
May 15, 2020
showuon
commented
May 15, 2020
showuon
commented
May 15, 2020
showuon
commented
May 15, 2020
showuon
commented
May 15, 2020
showuon
commented
May 15, 2020
showuon
commented
May 15, 2020
showuon
commented
May 15, 2020
Member
Author
|
hi @ijuma @kkonstantine @mjsax , I've put more fix in the documentation while I'm reading it. Please help review it when available. Thank you. |
Member
Author
|
hi @cmccabe @guozhangwang @gwenshap , a simple doc fix/update to connect.html/op.html/security.html. Please help review. Thanks. |
Contributor
kkonstantine
left a comment
kkonstantine
left a comment
There was a problem hiding this comment.
Thanks for the suggestions @showuon
I took a pass and left a few comments.
kkonstantine
approved these changes
May 19, 2020
Contributor
kkonstantine
left a comment
kkonstantine
left a comment
There was a problem hiding this comment.
LGTM!
Thanks @showuon
Contributor
|
ok to test |
Member
Author
|
Thank you, @kkonstantine for many nice catches!! |
Contributor
|
A few flaky test failures but otherwise clean builds. Merging to |
kkonstantine
changed the title
Kvicii
pushed a commit
to Kvicii/kafka
that referenced
this pull request
May 21, 2020
* 'trunk' of github.com:apache/kafka: MINOR: Increase gradle daemon’s heap size to 2g (apache#8700) KAFKA-9603: Do not turn on bulk loading for segmented stores on stand-by tasks (apache#8661) KAFKA-9859 / kafka-streams-application-reset tool doesn't take into account topics generated by KTable foreign key join operation (apache#8671) MINOR: Fix redundant typos in comments and javadocs (apache#8693) KAFKA-10010: Should make state store registration idempotent (apache#8681) KAFKA-10011: Remove task id from lockedTaskDirectories during handleLostAll (apache#8682) KAFKA-9992: Eliminate JavaConverters in EmbeddedKafkaCluster (apache#8673) KAFKA-6145: Add unit tests to verify fix of bug KAFKA-9173 (apache#8689) MINOR: Update stream documentation (apache#8622) MINOR: Small fixes in the documentation (apache#8623)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)